From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
kernel-janitors@vger.kernel.org, linux-mmc@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Colin Ian King <colin.king@canonical.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: atmel-mci: Reduce scope for the variable “slot” in atmci_request_end()
Date: Thu, 10 Dec 2020 19:21:50 +0100 [thread overview]
Message-ID: <20201210182150.GE1578121@piout.net> (raw)
In-Reply-To: <2667790c-fad2-aaa9-36e8-6be66949ac8d@web.de>
On 10/12/2020 18:23:05+0100, Markus Elfring wrote:
> >> Can the extra null pointer initialisation trigger a source code analysis warning
> >> like “Addresses-Coverity: ("Unused value")” for this function implementation?
> >>
> >
> > Did you check, does it? It doesn't.
> >
> > Are you wasting maintainer and reviewer's time? Yes you are.
>
> How do you think about a patch like “staging: speakup: remove redundant initialization
> of pointer p_key” for comparison?
> https://lore.kernel.org/patchwork/patch/1199128/
> https://lore.kernel.org/driverdev-devel/20200223153954.420731-1-colin.king@canonical.com/
>
> Would you tolerate to omit the initialisation for the variable “slot”?
>
If you were able to provide one good technical reason.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-10 18:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 15:01 [PATCH] mmc: atmel-mci: Reduce scope for the variable “slot” in atmci_request_end() Markus Elfring
2020-12-10 15:10 ` Alexandre Belloni
2020-12-10 16:35 ` Markus Elfring
2020-12-10 17:07 ` Alexandre Belloni
2020-12-10 17:23 ` Markus Elfring
2020-12-10 18:21 ` Alexandre Belloni [this message]
2020-12-11 6:34 ` Markus Elfring
2020-12-11 8:03 ` Alexandre Belloni
2020-12-12 9:16 ` Joe Perches
2020-12-12 11:00 ` Markus Elfring
2020-12-12 13:17 ` Alexandre Belloni
2020-12-12 18:48 ` Joe Perches
2020-12-11 8:37 ` [PATCH] " Dan Carpenter
2020-12-11 9:08 ` Markus Elfring
2020-12-14 7:05 ` Dan Carpenter
2020-12-14 10:27 ` …: Reduce scope for the variable “…” in …() Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210182150.GE1578121@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=Markus.Elfring@web.de \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).