From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
coresight@lists.linaro.org, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>, Leo Yan <leo.yan@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCH] coresight: cti: Reduce scope for the variable “cs_fwnode” in cti_plat_create_connection()
Date: Thu, 10 Dec 2020 14:55:40 -0700 [thread overview]
Message-ID: <20201210215540.GA1860012@xps15> (raw)
In-Reply-To: <c1b09b27-9012-324f-28d0-ba820dc468a5@web.de>
On Wed, Dec 09, 2020 at 09:42:20PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 9 Dec 2020 21:34:48 +0100
>
> A local variable was used only within an else branch.
> Thus move the definition for the variable “cs_fwnode” into
> the corresponding code block.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/hwtracing/coresight/coresight-cti-platform.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-cti-platform.c b/drivers/hwtracing/coresight/coresight-cti-platform.c
> index 98f830c6ed50..ccef04f27f12 100644
> --- a/drivers/hwtracing/coresight/coresight-cti-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-cti-platform.c
> @@ -343,7 +343,6 @@ static int cti_plat_create_connection(struct device *dev,
> {
> struct cti_trig_con *tc = NULL;
> int cpuid = -1, err = 0;
> - struct fwnode_handle *cs_fwnode = NULL;
> struct coresight_device *csdev = NULL;
> const char *assoc_name = "unknown";
> char cpu_name_str[16];
> @@ -397,8 +396,9 @@ static int cti_plat_create_connection(struct device *dev,
> assoc_name = cpu_name_str;
> } else {
> /* associated device ? */
> - cs_fwnode = fwnode_find_reference(fwnode,
> - CTI_DT_CSDEV_ASSOC, 0);
> + struct fwnode_handle *cs_fwnode = fwnode_find_reference(fwnode,
> + CTI_DT_CSDEV_ASSOC,
> + 0);
I have applied your patch.
Thanks,
Mathieu
> if (!IS_ERR(cs_fwnode)) {
> assoc_name = cti_plat_get_csdev_or_node_name(cs_fwnode,
> &csdev);
> --
> 2.29.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-12-10 21:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 20:42 [PATCH] coresight: cti: Reduce scope for the variable “cs_fwnode” in cti_plat_create_connection() Markus Elfring
2020-12-10 21:55 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210215540.GA1860012@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=Markus.Elfring@web.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox