From: Maxime Ripard <maxime@cerno.tech>
To: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
dri-devel@lists.freedesktop.org, Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/8] drm/vc4: dsi: Correct DSI register definition
Date: Fri, 11 Dec 2020 11:17:36 +0100 [thread overview]
Message-ID: <20201211101736.e26kyrbdaq4qhk7p@gilmour> (raw)
In-Reply-To: <cfcfd349-e0fc-8bd0-4c9e-6cc33bf5f056@kontron.de>
[-- Attachment #1.1: Type: text/plain, Size: 1051 bytes --]
Hi,
On Tue, Dec 08, 2020 at 09:34:05AM +0100, Frieder Schrempf wrote:
> On 03.12.20 14:25, Maxime Ripard wrote:
> > From: Dave Stevenson <dave.stevenson@raspberrypi.com>
> >
> > The DSI1_PHY_AFEC0_PD_DLANE1 and DSI1_PHY_AFEC0_PD_DLANE3 register
> > definitions were swapped, so trying to use more than a single data
> > lane failed as lane 1 would get powered down.
> > (In theory a 4 lane device would work as all lanes would remain
> > powered).
> >
> > Correct the definitions.
> >
> > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> Wouldn't this deserve a "Fixes: ..." and "Cc: stable@vger.kernel.org" tag,
> as this bug is present in all stable releases since this driver was
> introduced? I think it would be really helpful to have it backported.
Sorry I forgot it. The patch is applied however and drm-misc-next
doesn't get rebased, so I can't add it now.
We can always send it for stable by hand though once it's in Linus' tree
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-11 10:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 13:25 [PATCH 0/8] drm/vc4: DSI improvements and BCM2711 support Maxime Ripard
2020-12-03 13:25 ` [PATCH 1/8] drm/vc4: drv: Remove the DSI pointer in vc4_drv Maxime Ripard
2020-12-09 11:02 ` Nicolas Saenz Julienne
2020-12-03 13:25 ` [PATCH 2/8] drm/vc4: dsi: Correct DSI register definition Maxime Ripard
2020-12-08 8:34 ` Frieder Schrempf
2020-12-09 11:04 ` Nicolas Saenz Julienne
2020-12-11 10:17 ` Maxime Ripard [this message]
2020-12-03 13:25 ` [PATCH 3/8] drm/vc4: dsi: Use snprintf for the PHY clocks instead of an array Maxime Ripard
2020-12-03 13:25 ` [PATCH 4/8] drm/vc4: dsi: Introduce a variant structure Maxime Ripard
2020-12-03 13:25 ` [PATCH 5/8] drm/vc4: dsi: Add support for DSI0 Maxime Ripard
2020-12-03 13:25 ` [PATCH 6/8] dt-bindings: Add compatible for BCM2711 DSI1 Maxime Ripard
2020-12-03 13:25 ` [PATCH 7/8] drm/vc4: dsi: Add configuration " Maxime Ripard
2020-12-03 13:25 ` [PATCH 8/8] ARM: dts: bcm2711: Use compatible string " Maxime Ripard
2020-12-21 12:18 ` Nicolas Saenz Julienne
2020-12-03 15:19 ` [PATCH 0/8] drm/vc4: DSI improvements and BCM2711 support Dave Stevenson
2020-12-07 9:34 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211101736.e26kyrbdaq4qhk7p@gilmour \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=frieder.schrempf@kontron.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox