From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42834C4361B for ; Fri, 11 Dec 2020 11:47:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBCAF23DE3 for ; Fri, 11 Dec 2020 11:47:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBCAF23DE3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9S6gI0jebeFqppaTlGwcYoMccN+NY+pXDOqLL8cCWEA=; b=lKO6Or2jEJNqabht+e/5kqnkL kpul8iMvF/Br6K1/rV7a2bWFDAMqnY8CTjKsugS6DalNGUdy3IfgSyafON/E2lw0eT6z5W9iznzWs CjBMXN6e7U49BMJ092a+wDOuHQLvZywv9md8L6RzKQzvJOr9mTKBRGiiv0uw2Gx6bWoTBrre0ePtY JYf+0suMmqQR5/O2FJjPHVowrCZdJTUzcctOs7ZX6a54SPBroz65DvMr4G9oJKxuRI5YdHOX0OoLC v/1Lb/aA2+8NPcSCABXjG6QQTQvEwnK16paNVqhk/seWQ0dCTCvBNuLHSMO+ZCmeLQWH6GNvA8pcF UoZqtd+qw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kngrR-0003lq-Na; Fri, 11 Dec 2020 11:45:21 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kngrO-0003lI-Ei for linux-arm-kernel@lists.infradead.org; Fri, 11 Dec 2020 11:45:19 +0000 X-Originating-IP: 86.194.74.19 Received: from localhost (lfbn-lyo-1-997-19.w86-194.abo.wanadoo.fr [86.194.74.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 83978240006; Fri, 11 Dec 2020 11:45:15 +0000 (UTC) Date: Fri, 11 Dec 2020 12:45:15 +0100 From: Alexandre Belloni To: Sudeep Holla Subject: Re: [PATCH] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs Message-ID: <20201211114515.GF1781038@piout.net> References: <20201211103143.1332302-1-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201211103143.1332302-1-sudeep.holla@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201211_064518_604651_BBCB872D X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ludovic Desroches , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 11/12/2020 10:31:43+0000, Sudeep Holla wrote: > Since at91_soc_init is called unconditionally from atmel_soc_device_init, > we get the following warning on all non AT91 SoCs: > " AT91: Could not find identification node" > > Fix the same by filtering with allowed AT91 SoC list. > > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Ludovic Desroches > Signed-off-by: Sudeep Holla > --- > drivers/soc/atmel/soc.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c > index c4472b68b7c2..ba9fc07cd91c 100644 > --- a/drivers/soc/atmel/soc.c > +++ b/drivers/soc/atmel/soc.c > @@ -271,8 +271,19 @@ struct soc_device * __init at91_soc_init(const struct at91_soc *socs) > return soc_dev; > } > > +static const struct of_device_id at91_soc_allowed_list[] __initconst = { > + { .compatible = "atmel,at91rm9200", }, > + { .compatible = "atmel,at91sam9260", }, > + { .compatible = "atmel,sama5d2", }, This is a very small subset of the supported SoCs. a proper list would be: atmel,at91rm9200 atmel,at91sam9 atmel,sama5 atmel,samv7 -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel