From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A56C4361B for ; Fri, 11 Dec 2020 11:52:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08A7723EB1 for ; Fri, 11 Dec 2020 11:52:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08A7723EB1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=myL7uSM4BCc2gqR9F/C9KxOb9u2U31sXL1g/UG6VDsI=; b=R0bJ0Hf8/d1/qsr8R0PrJua4+ Iz1QDQaZifrhoMiT/42KmO5ibPb7+yCIvM+CsbepvnrE9wJuNjIcXJVGMjlafDV5OY7Y6gpfHUgjr 8buRkarz386z5kKOBasv8x67pF8sGbAUj0SdCKlLlqByoiBItLuCU6ltrY+pAQU6m2ChBhoNsMg8N uvNCtNsFHYyOOsiONH/P+GyxR7o+KHzGPas4b1kLXlYjGvVxL1b0LBVRZY5dYCa8wVgbpOqiLTiiC aT3DxUSv9ecwDxzO8w3OfAf4a6TqZVPHYqMmH005e94YkmiWDXVoaeM5luE+AQIgqwTcHbrUmSTO0 ctznBvQqw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kngwy-0004Rs-Gy; Fri, 11 Dec 2020 11:51:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kngwv-0004RR-MH for linux-arm-kernel@lists.infradead.org; Fri, 11 Dec 2020 11:51:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 800B831B; Fri, 11 Dec 2020 03:50:59 -0800 (PST) Received: from bogus (unknown [10.57.54.168]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 271A63F68F; Fri, 11 Dec 2020 03:50:57 -0800 (PST) Date: Fri, 11 Dec 2020 11:50:55 +0000 From: Sudeep Holla To: Alexandre Belloni Subject: Re: [PATCH] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs Message-ID: <20201211115055.acoezgrwh45hw6is@bogus> References: <20201211103143.1332302-1-sudeep.holla@arm.com> <20201211114515.GF1781038@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201211114515.GF1781038@piout.net> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201211_065101_780887_62F6D8DD X-CRM114-Status: GOOD ( 19.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ludovic Desroches , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 11, 2020 at 12:45:15PM +0100, Alexandre Belloni wrote: > Hello, > > On 11/12/2020 10:31:43+0000, Sudeep Holla wrote: > > Since at91_soc_init is called unconditionally from atmel_soc_device_init, > > we get the following warning on all non AT91 SoCs: > > " AT91: Could not find identification node" > > > > Fix the same by filtering with allowed AT91 SoC list. > > > > Cc: Nicolas Ferre > > Cc: Alexandre Belloni > > Cc: Ludovic Desroches > > Signed-off-by: Sudeep Holla > > --- > > drivers/soc/atmel/soc.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c > > index c4472b68b7c2..ba9fc07cd91c 100644 > > --- a/drivers/soc/atmel/soc.c > > +++ b/drivers/soc/atmel/soc.c > > @@ -271,8 +271,19 @@ struct soc_device * __init at91_soc_init(const struct at91_soc *socs) > > return soc_dev; > > } > > > > +static const struct of_device_id at91_soc_allowed_list[] __initconst = { > > + { .compatible = "atmel,at91rm9200", }, > > + { .compatible = "atmel,at91sam9260", }, > > + { .compatible = "atmel,sama5d2", }, > > This is a very small subset of the supported SoCs. a proper list would > be: > > atmel,at91rm9200 > atmel,at91sam9 > atmel,sama5 > atmel,samv7 > Sure I can update it but the existing functions at91_get_cidr_exid_from_chipid and at91_get_cidr_exid_from_dbgu check for following 3 compatibles and bail out if not found: "atmel,at91rm9200-dbgu" "atmel,at91sam9260-dbgu" "atmel,sama5d2-chipid" Quick check on DTS upstream suggested only 3 platforms, hence the choice. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel