From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7751C433FE for ; Sun, 13 Dec 2020 12:06:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D26523121 for ; Sun, 13 Dec 2020 12:06:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D26523121 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iP/Cl4tZkea7rxnIGymyBRAOf8zgSiqqipRe6t2YMu0=; b=GOGHnXqbiDIWJInq1rsCVT8EY Em+/j/vbpbSSSb+0WJrJkbfaAMMx73l/WITxYOa+3jXe6bxDeUvAFbyOkLMMpI1GI+r0d+bqUIioZ 9hhvVA2jRzgxneoxKTB6ioit4NpvuaPJ2QF800x3IG1KZIm3KKVZ/UMehCexcunvvzG4MnfdfXeum bCpK9cTV4b+lxcQok0tj0brgcb8ycyPpN9fTT49I+0kqXk3vbJ9/82l6jCO5G+/LoeDSvdzvyeZla n1SU4vUI3EbvdrQWfFBpJodU9tGaB7OhpMC5x5wWIZp8Wxu3e3bU7W65EjKVlRwvU0NPm+hppk5o/ 5GrY3YbWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1koQ7S-0004uJ-Hb; Sun, 13 Dec 2020 12:04:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1koQ7O-0004tb-KJ for linux-arm-kernel@lists.infradead.org; Sun, 13 Dec 2020 12:04:51 +0000 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C105F23121; Sun, 13 Dec 2020 12:04:45 +0000 (UTC) Date: Sun, 13 Dec 2020 12:04:42 +0000 From: Jonathan Cameron To: Anand Ashok Dumbre Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres Message-ID: <20201213120442.3f98814a@archlinux> In-Reply-To: References: <20201130142759.28216-1-brgl@bgdev.pl> <20201130202110.62e7f989@archlinux> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201213_070450_797105_D3F68760 X-CRM114-Status: GOOD ( 25.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lars-Peter Clausen , "linux-iio@vger.kernel.org" , Bartosz Golaszewski , "linux-kernel@vger.kernel.org" , Bartosz Golaszewski , Michal Simek , Peter Meerwald-Stadler , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 11 Dec 2020 12:15:15 +0000 Anand Ashok Dumbre wrote: > > -----Original Message----- > > From: Jonathan Cameron > > Sent: Monday 30 November 2020 8:21 PM > > To: Bartosz Golaszewski > > Cc: Lars-Peter Clausen ; Peter Meerwald-Stadler > > ; Michal Simek ; linux- > > iio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; Bartosz Golaszewski > > ; Anand Ashok Dumbre > > > > Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres > > > > On Mon, 30 Nov 2020 15:27:56 +0100 > > Bartosz Golaszewski wrote: > > > > > From: Bartosz Golaszewski > > > > > > This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc: > > > use devm_krealloc()"). I noticed we can use even more devres helpers > > > and entirely drop the remove() callback. > > > > > > v1 -> v2: > > > - squash three patches adding more devres calls into one for easier > > > review > > > - don't insist on the 80 characters limit > > > - add a new helper: devm_krealloc_array() and use it > > > > > > v2 -> v3: > > > - drop the devm_krealloc_array() helper > > > > > > Bartosz Golaszewski (3): > > > iio: adc: xilinx: use helper variable for &pdev->dev > > > iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc() > > > iio: adc: xilinx: use more devres helpers and remove remove() > > > > > > drivers/iio/adc/xilinx-xadc-core.c | 157 > > > ++++++++++++++--------------- > > > 1 file changed, 74 insertions(+), 83 deletions(-) > > > > > > > Series looks good to me but would like to leave it a little longer to let others > > take a look at it. That will probably mean it falls into next cycle now. > > > > +CC Anand who is looking at another series touching this driver and > > +might > > give this one a spin as well. > > > > Thanks, > > > > Jonathan > > Hi Jonathan, Bartosz, > > I have tested and reviewed the patch and everything looks good. > I have another patch series on the same files that might cause conflicts. > > Reviewed-by: Anand Ashok Dumbre > Tested-by: Anand Ashok Dumbre Thanks, Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. There was a small amount of fuzz. Thanks, Jonathan > > Thanks, > Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel