From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF362C4361B for ; Mon, 14 Dec 2020 09:39:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4107922AB0 for ; Mon, 14 Dec 2020 09:39:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4107922AB0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sB/pqdLYNwB9Vqqp6XUEvP10FnGbqVzcRR+0KfuJe2M=; b=cd4LZzibIobreybkhgI7RD51g TN1q2twrA/6MOSI2BLW/2/WpBxEySFE5GZR327S5xJE8DY62hX0GOb2hlqID8KP/mz9sOnAnDhDbU tW6/AeD83LthhU+X0hcWKouLU1T1X8Yb1QpLFQhDD1WQJny1KamHkfFOczGuq/Bnxy2gyyhX6RLZf 1+sswY3m0hcUxDwFKjeNgGlyzVFUjOCtP8y1wP7tBvMuSVv44sgwNRzoyLlfhWc03eX2EM0oeQIeB vH38GO9iI/z6X5L2+mvSKFVfGPF0sCY8duL5OhDeNxY9XpgEBR+UG5WtTTTIFZWqTeMrIQsE/xMR3 va7BIpasg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kokIV-0000Tz-Jr; Mon, 14 Dec 2020 09:37:39 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kokIS-0000Sv-EU for linux-arm-kernel@lists.infradead.org; Mon, 14 Dec 2020 09:37:37 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 63B17580392; Mon, 14 Dec 2020 04:37:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 14 Dec 2020 04:37:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=HWHAg7xpE7CitXLNsFfZMevT63D F9AXAXnEVExpoqhQ=; b=R+UJ4OEqqfYuz0cFPUVKj+CReQjIpmHFv4DcBgsAOUP KpthKRYwqiv6+PruBC8xlOYr0J9sryjeO/nHWjKuUcm67yCu+bkPQeKTgIArT52I lXVSECorzWInoAtEIAukQGnP1fiT1Wq/UhP750uyJ++pMxzOEb2cACEwltjq5322 LbR2trlqWuZ33p4E6KRAYanFc3VKEwq/sf9GgASY+V2R8caldcniktciFX+Lpb1B a2i2HqyuG26lay5wPLZyDpf83m3cNlWEhFDUBmADy9oegMu827y9Lpf9qqMjtBkr fcFsrVZAhLqXKdkQrWFRao9Gja/LRUvaynXwWeEeNfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=HWHAg7 xpE7CitXLNsFfZMevT63DF9AXAXnEVExpoqhQ=; b=IGEyRPcmDONLzmRhmwptS1 7sBVDSiuxDUzEG2s7jW8yFc5nd2U3qxWM+5tWYL5F7Hl3SxrxYvL7K9YZKMbByV2 +/M3CY5mUxzCu8mi+d81udonMXxrQRxIK+CygYRn/k0Ke+SQUWKbtKWSQaNvLJgb dgJnerJYDWP/3grTln95J4RrOCCKHK9P/WjRCYqPmVbzk6EJf0ECoEmob3dN7ms0 PReBCXW2V4lvrWn94f8bs0+z5w7ZNVK7n20sbgRfSSb9XVlbXKp9Ci/bqB+ipUMv vI0xatn6HUxHjpCPHv7Em2kq2KihsreYGbrl73pkTW5rfO5cbuQpH0uEFrGFffEQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekkedgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id C7D6524005D; Mon, 14 Dec 2020 04:37:29 -0500 (EST) Date: Mon, 14 Dec 2020 10:37:28 +0100 From: Maxime Ripard To: Andre Przywara Subject: Re: [PATCH v2 02/21] dt-bindings: pinctrl: Add Allwinner H616 compatible strings Message-ID: <20201214093728.ehd2362jzclbxwp5@gilmour> References: <20201211011934.6171-1-andre.przywara@arm.com> <20201211011934.6171-3-andre.przywara@arm.com> MIME-Version: 1.0 In-Reply-To: <20201211011934.6171-3-andre.przywara@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201214_043736_693088_639196C1 X-CRM114-Status: GOOD ( 17.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Jernej Skrabec , devicetree@vger.kernel.org, Yangtao Li , Linus Walleij , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Chen-Yu Tsai , =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Icenowy Zheng , Shuosheng Huang , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1245565089018537167==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1245565089018537167== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="teps3mzqehr2ukhi" Content-Disposition: inline --teps3mzqehr2ukhi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 11, 2020 at 01:19:15AM +0000, Andre Przywara wrote: > A new SoC, a new compatible string. > Also we were too miserly with just allowing seven interrupt banks. >=20 > Signed-off-by: Andre Przywara > --- > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a1= 0-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-= a10-pinctrl.yaml > index 5240487dfe50..292b05d9ed08 100644 > --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinct= rl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinct= rl.yaml > @@ -53,6 +53,8 @@ properties: > - allwinner,sun50i-h5-pinctrl > - allwinner,sun50i-h6-pinctrl > - allwinner,sun50i-h6-r-pinctrl > + - allwinner,sun50i-h616-pinctrl > + - allwinner,sun50i-h616-r-pinctrl > - allwinner,suniv-f1c100s-pinctrl > - nextthing,gr8-pinctrl > =20 > @@ -61,7 +63,7 @@ properties: > =20 > interrupts: > minItems: 1 > - maxItems: 7 > + maxItems: 8 > description: > One interrupt per external interrupt bank supported on the > controller, sorted by bank number ascending order. > @@ -91,7 +93,7 @@ properties: > bank found in the controller > $ref: /schemas/types.yaml#/definitions/uint32-array > minItems: 1 > - maxItems: 5 > + maxItems: 8 > =20 > patternProperties: > # It's pretty scary, but the basic idea is that: > @@ -145,6 +147,18 @@ allOf: > # boards are defining it at the moment so it would generate a lot of > # warnings. > =20 > + - if: > + properties: > + compatible: > + enum: > + - allwinner,sun50i-h616-pinctrl > + > + then: > + properties: > + interrupts: > + minItems: 8 > + maxItems: 8 > + You don't need to have both if they are equals, and in this particular case we already check that the maximum is 8 so there's no need to repeat that check here. Maxime --teps3mzqehr2ukhi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9cyWAAKCRDj7w1vZxhR xYfnAQDBD2pe+FNR4IA9GRNzIHQdPJoicvUpXdOkIZ3Vg4PxnwEAwDkKO+5X8qIm 0YBiAOU4IfGNDdKT2j1xV9fMEDkLqwk= =T4BT -----END PGP SIGNATURE----- --teps3mzqehr2ukhi-- --===============1245565089018537167== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1245565089018537167==--