From: Maxime Ripard <maxime@cerno.tech>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Ondrej Jirman <megous@megous.com>,
devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT binding
Date: Mon, 14 Dec 2020 11:37:04 +0100 [thread overview]
Message-ID: <20201214103704.bkgwh4bdelrtovgd@gilmour> (raw)
In-Reply-To: <20201210084232.1913871-1-icenowy@aosc.io>
[-- Attachment #1.1: Type: text/plain, Size: 1219 bytes --]
On Thu, Dec 10, 2020 at 04:42:32PM +0800, Icenowy Zheng wrote:
> Early adopters' PineTabs (and all further releases) will have a new LCD
> panel different with the one that is used when in development (because
> the old panel's supply discontinued).
>
> Add a new DT compatible for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 6db32fbf813f..73a6c8421172 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -700,6 +700,11 @@ properties:
> - const: pine64,pinetab
> - const: allwinner,sun50i-a64
>
> + - description: Pine64 PineTab with new LCD panel
> + items:
> + - const: pine64,pinetab-new-panel
> + - const: allwinner,sun50i-a64
> +
We're on the right track, but new panel seems a bit too vague. What is
going to happen when they will change the panel again?
pinetab-early-adopter seems more robust there
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-14 10:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 8:37 [PATCH 0/3] PineTab with new panel DT Icenowy Zheng
2020-12-10 8:42 ` [PATCH 1/3] dt-bindings: arm: sunxi: add PineTab new panel DT binding Icenowy Zheng
2020-12-11 3:39 ` Rob Herring
2020-12-14 10:37 ` Maxime Ripard [this message]
2020-12-14 22:59 ` [linux-sunxi] " Icenowy Zheng
2020-12-16 13:00 ` Maxime Ripard
2020-12-16 13:18 ` Icenowy Zheng
2020-12-10 8:44 ` [PATCH 2/3] arm64: allwinner: dts: a64: add DT for PineTab with new LCD panel Icenowy Zheng
2020-12-10 8:45 ` [PATCH 3/3] dt-bindings: arm: sunxi: note that old PineTab compatible has old panel Icenowy Zheng
2020-12-11 3:39 ` Rob Herring
2020-12-14 10:39 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214103704.bkgwh4bdelrtovgd@gilmour \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=megous@megous.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox