From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E524C4361B for ; Mon, 14 Dec 2020 12:55:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B583C2074B for ; Mon, 14 Dec 2020 12:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B583C2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RNNVUI72y9/kM1Dhgrgn2BBe9Eu+X0awSL49HPlk0TQ=; b=0+PrHDZgOfSCYYQLY2y4x+30P 96tSI3n1RJh54sNu0WIv9jFWazuRlu49pxkAWYiI2VYxuKgCPKFrAQmZ139gjUKFIu5MLUOHNFGBz Qjm5FpffsdQsLqFatv4zBTVS/l9wM9zwVwhPOJkPccfnsZl4nv7wV8jUoNb+AyddGP9ScKB11Y8JF jlb31Jw0PkdByMT8Z4fOU3Tl7l5fpyKiJr5cgjOn8f76lBOICCcHnNhm8exSgvY8Prw4sH2Pn/zgY U1n0cCEJWHSAihAgA/H5Ti7Y8PMOVoBfW0/kXw5tfz9A3bH1m/+8YPtJDIYdPXUG7stk3zWKG23My 29DZNQESg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1konMX-0008W7-M8; Mon, 14 Dec 2020 12:54:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1konMV-0008Vh-55 for linux-arm-kernel@lists.infradead.org; Mon, 14 Dec 2020 12:54:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 013E11FB; Mon, 14 Dec 2020 04:53:55 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5299A3F66B; Mon, 14 Dec 2020 04:53:53 -0800 (PST) Date: Mon, 14 Dec 2020 12:53:43 +0000 From: Andre Przywara To: Maxime Ripard Subject: Re: [PATCH v2 19/21] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Message-ID: <20201214125343.0cd1bc6a@slackpad.fritz.box> In-Reply-To: <20201214095831.j63nks3fqxlaw75w@gilmour> References: <20201211011934.6171-1-andre.przywara@arm.com> <20201211011934.6171-20-andre.przywara@arm.com> <20201214095831.j63nks3fqxlaw75w@gilmour> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201214_075359_287025_B595BB9B X-CRM114-Status: GOOD ( 17.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Jernej Skrabec , devicetree@vger.kernel.org, Yangtao Li , Linus Walleij , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Chen-Yu Tsai , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Icenowy Zheng , Shuosheng Huang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 14 Dec 2020 10:58:31 +0100 Maxime Ripard wrote: Hi, > On Fri, Dec 11, 2020 at 01:19:32AM +0000, Andre Przywara wrote: > > + reserved-memory { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + > > + /* 512KiB reserved for ARM Trusted Firmware (BL31) > > */ > > + secmon_reserved: secmon@40000000 { > > + reg = <0x0 0x40000000 0x0 0x80000>; > > + no-map; > > + }; > > + }; > > This should still be set by the firmware > > > + mmc0: mmc@4020000 { > > + compatible = "allwinner,sun50i-h616-mmc", > > + "allwinner,sun50i-a100-mmc"; > > + reg = <0x04020000 0x1000>; > > + clocks = <&ccu CLK_BUS_MMC0>, <&ccu > > CLK_MMC0>; > > + clock-names = "ahb", "mmc"; > > + resets = <&ccu RST_BUS_MMC0>; > > + reset-names = "ahb"; > > + interrupts = > IRQ_TYPE_LEVEL_HIGH>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&mmc0_pins>; > > + status = "disabled"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > Somewhat related: we shouldn't set the MMC speed flags in the drivers. > This is biting us on the already supported SoCs, so it would be great > to not repeat the same mistake with the new ones Do you mean to list the "sd-uhs-sdr50" and friends properties here in the DT? What is the best practice here in terms putting them in the .dts vs. the .dtsi? Surely the controller has limits, but bad traces on a board could impose further restrictions, right? Though that's probably rare, so it sounds like a lot of churn to list them in every board DT. So can we list everything in here (.dtsi), then delete in those affected boards only? Cheers, Andre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel