From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2237C4361B for ; Mon, 14 Dec 2020 14:13:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87CDC20798 for ; Mon, 14 Dec 2020 14:13:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87CDC20798 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rogJpRW+mwXzlI/gqPkN8oxHqM0lQOzWoPgN8ZGPyF0=; b=lfoirRCktsIr0TkN4ERP9elI1 V3dh8vGsFZR2kj3ZEl8ZgqtiVrcCAjfauT+KSyFeKVcCtN01XEQlPilO5hhACxFBJYTb5QKmpMJxl dIeDcWDVvRIQoPLoRwuHXayKYmwr6XyBomaMmdKOEGg1lalT21m+j2N000R9WO+WENErrOk3nBe1W 2iRcmxfl+/xqhLuz0sByqEkLAxyrYNV93NKxn42kamo4TisJ8H4q+ekg3CQ2MQ3XuM2pJ2VVJEc0w ExrduUPTc0X5WgNdSLJv7xTjWkZbFxjgmYfPfb+Im9kAKgn416VMWGqN+/n7cwSJyroHDSWJPrqqF 0UWr2dQ0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kooaJ-0000Tb-BG; Mon, 14 Dec 2020 14:12:19 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kooaG-0000SK-Vu for linux-arm-kernel@lists.infradead.org; Mon, 14 Dec 2020 14:12:17 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id AAE91580264; Mon, 14 Dec 2020 09:12:13 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 14 Dec 2020 09:12:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=oPI5HgnVfN7c7xc2RC5PhDz4rdE fvl2DDBtK4UExMW4=; b=ET4gdNm3wukJ27HyFZde/XQSFbT1fP+rwoXRooGD6vw qIVImpYo4EY71ON7gzZzBs2jFRdFrA639vOgGBIH/DghTA7mhBKQzmQGEY2swlON gX/NDO7zk+2e3r+/FnHvjp1pDffOJtiyeAPy73f3DDAQqF9lsQiwyKmXeG/qHg9Q fDW99Tg6JcnqReGlf5xlyvd7DPMN49HpWf4kpdM9t4oBOhYcTNfiOT0FUZ5HJaB0 zhenrW8aptxuQ+CPeOA/ARb2UrYnYExv/AweLhHhEaemTJBy1+4xW25E3Mdr17So AwuNFP6FQ0FO35Dfk553/5KulSjZdcXwk3COcp/w5EQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=oPI5Hg nVfN7c7xc2RC5PhDz4rdEfvl2DDBtK4UExMW4=; b=X700nfHOOwF8Fcblg6tXnW NVZEbmR8WECEvZlIjR8J7nEdx++Zd85CF+EHr6xyS5KfvIibWtLDffW+5X06TlA8 jmP3hmkn7Z1nXocXlsjmiewYscJ249vwQVNQTumK+zQkMHV4Pt57pBHxnYt/J5pd I/FT3MRy+rRy4e0EM8vANavVE/XIggsSc6eqZXHCGgtdmCjfzbogjJ8Y6ogN3e5z 1FQN9c+5DCNnURhV64DWGIHzjtmlJ4nkw5ZuALRT1vKFNhdHeKSSGjvGduDkfSPw m5P/SALBy0ZxIcJf9ayfLSUItcmQ10rPgooEYA1dNde/l7DaGHsu8yKN3Z9qWxGg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekkedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 0FF8724005D; Mon, 14 Dec 2020 09:12:10 -0500 (EST) Date: Mon, 14 Dec 2020 15:12:09 +0100 From: Maxime Ripard To: Andre Przywara Subject: Re: [PATCH v2 19/21] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Message-ID: <20201214141209.xky5dn42dkrv4vvm@gilmour> References: <20201211011934.6171-1-andre.przywara@arm.com> <20201211011934.6171-20-andre.przywara@arm.com> <20201214095831.j63nks3fqxlaw75w@gilmour> <20201214125343.0cd1bc6a@slackpad.fritz.box> MIME-Version: 1.0 In-Reply-To: <20201214125343.0cd1bc6a@slackpad.fritz.box> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201214_091217_212238_49647AFD X-CRM114-Status: GOOD ( 19.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Jernej Skrabec , devicetree@vger.kernel.org, Yangtao Li , Linus Walleij , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Chen-Yu Tsai , =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Icenowy Zheng , Shuosheng Huang , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0811579432683712520==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0811579432683712520== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4tjwk5mvzqfd55qc" Content-Disposition: inline --4tjwk5mvzqfd55qc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 14, 2020 at 12:53:43PM +0000, Andre Przywara wrote: > On Mon, 14 Dec 2020 10:58:31 +0100 > Maxime Ripard wrote: > > On Fri, Dec 11, 2020 at 01:19:32AM +0000, Andre Przywara wrote: > > > + reserved-memory { > > > + #address-cells =3D <2>; > > > + #size-cells =3D <2>; > > > + ranges; > > > + > > > + /* 512KiB reserved for ARM Trusted Firmware (BL31) > > > */ > > > + secmon_reserved: secmon@40000000 { > > > + reg =3D <0x0 0x40000000 0x0 0x80000>; > > > + no-map; > > > + }; > > > + }; =20 > >=20 > > This should still be set by the firmware > >=20 > > > + mmc0: mmc@4020000 { > > > + compatible =3D "allwinner,sun50i-h616-mmc", > > > + "allwinner,sun50i-a100-mmc"; > > > + reg =3D <0x04020000 0x1000>; > > > + clocks =3D <&ccu CLK_BUS_MMC0>, <&ccu > > > CLK_MMC0>; > > > + clock-names =3D "ahb", "mmc"; > > > + resets =3D <&ccu RST_BUS_MMC0>; > > > + reset-names =3D "ahb"; > > > + interrupts =3D > > IRQ_TYPE_LEVEL_HIGH>; > > > + pinctrl-names =3D "default"; > > > + pinctrl-0 =3D <&mmc0_pins>; > > > + status =3D "disabled"; > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + }; =20 > >=20 > > Somewhat related: we shouldn't set the MMC speed flags in the drivers. > > This is biting us on the already supported SoCs, so it would be great > > to not repeat the same mistake with the new ones >=20 > Do you mean to list the "sd-uhs-sdr50" and friends properties here in > the DT? > What is the best practice here in terms putting them in the .dts vs. > the .dtsi? Surely the controller has limits, but bad traces on a board > could impose further restrictions, right? > > Though that's probably rare, so it sounds like a lot of churn to list > them in every board DT. So can we list everything in here (.dtsi), then > delete in those affected boards only? Yeah, I completely agree :) Maxime --4tjwk5mvzqfd55qc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9dyuQAKCRDj7w1vZxhR xfOmAQDAUlEjonuvKgzrcKb89bymLb1GtDfICxmZo8pcsDYFkAEAymQgz1ZZR/ev 9cwmWik25ODTVmrSb0Mf+AKo6XJ2eQM= =8BAy -----END PGP SIGNATURE----- --4tjwk5mvzqfd55qc-- --===============0811579432683712520== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0811579432683712520==--