From: Maxime Ripard <maxime@cerno.tech>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 05/12] pinctrl: sunxi: add pinctrl driver for V831/V833
Date: Mon, 14 Dec 2020 15:21:18 +0100 [thread overview]
Message-ID: <20201214142118.bxdzu7z7cdomhgy7@gilmour> (raw)
In-Reply-To: <20201212040430.3640418-2-icenowy@aosc.io>
[-- Attachment #1.1: Type: text/plain, Size: 1408 bytes --]
On Sat, Dec 12, 2020 at 12:04:23PM +0800, Icenowy Zheng wrote:
> V831/V833 are new chips from Allwinner. They're the same die with
> different package.
>
> Add a pinctrl driver for them.
>
> The difference between V831/V833 pinctrl is implemented based on the
> user manual.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> drivers/pinctrl/sunxi/Kconfig | 5 +
> drivers/pinctrl/sunxi/Makefile | 1 +
> drivers/pinctrl/sunxi/pinctrl-sun8i-v83x.c | 743 +++++++++++++++++++++
> drivers/pinctrl/sunxi/pinctrl-sunxi.h | 2 +
> 4 files changed, 751 insertions(+)
> create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun8i-v83x.c
>
> diff --git a/drivers/pinctrl/sunxi/Kconfig b/drivers/pinctrl/sunxi/Kconfig
> index 593293584ecc..fc13335a3eda 100644
> --- a/drivers/pinctrl/sunxi/Kconfig
> +++ b/drivers/pinctrl/sunxi/Kconfig
> @@ -73,6 +73,11 @@ config PINCTRL_SUN8I_V3S
> default MACH_SUN8I
> select PINCTRL_SUNXI
>
> +config PINCTRL_SUN8I_V83X
> + bool "Support for the Allwinner V831/V833 PIO"
> + default MACH_SUN8I
> + select PINCTRL_SUNXI
> +
We're not using the wildcard much, and I'd rather be consistent with the
name / Kconfig option scheme used for the clock driver (and the rest of
the SoCs in a similar situation)
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-14 14:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-12 4:01 [RFC PATCH 00/12] Support for Allwinner V831 SoC Icenowy Zheng
2020-12-12 4:01 ` [RFC PATCH 01/12] dt-bindings: clock: sunxi-ng: add compatible for V831/V833 CCU Icenowy Zheng
2020-12-15 16:16 ` Rob Herring
2020-12-12 4:03 ` [RFC PATCH 02/12] dt-bindings: clk: sunxi-ng: add V833 CCU clock/reset indices headers Icenowy Zheng
2020-12-15 16:18 ` Rob Herring
2020-12-12 4:03 ` [RFC PATCH 03/12] clk: sunxi-ng: add CCU driver for V831/V833 Icenowy Zheng
2020-12-12 4:04 ` [RFC PATCH 04/12] dt-bindings: pinctrl: sunxi: add compatible for V831/V833 pinctrl Icenowy Zheng
2020-12-15 16:18 ` Rob Herring
2020-12-12 4:04 ` [RFC PATCH 05/12] pinctrl: sunxi: add pinctrl driver for V831/V833 Icenowy Zheng
2020-12-14 14:21 ` Maxime Ripard [this message]
2020-12-14 15:19 ` Icenowy Zheng
2020-12-14 16:42 ` Maxime Ripard
2021-01-04 14:47 ` Linus Walleij
2020-12-12 4:06 ` [RFC PATCH 06/12] dt-bindings: rtc: sun6i: add compatible string for V831/V833 RTC Icenowy Zheng
2020-12-14 14:19 ` Rob Herring
2020-12-12 4:09 ` [RFC PATCH 07/12] " Icenowy Zheng
2020-12-12 5:03 ` [RFC PATCH 08/12] dt-bindings: mmc: sunxi: add compatible strings for V831 MMC Icenowy Zheng
2020-12-14 14:38 ` Maxime Ripard
2020-12-12 5:05 ` [RFC PATCH 09/12] dt-bindings: watchdog: sunxi: add compatible string for V831/V833 WDT Icenowy Zheng
2020-12-15 16:27 ` Rob Herring
2020-12-12 5:12 ` [RFC PATCH 10/12] dt-bindings: spi: sun6i: add compatible for V831 SPI Icenowy Zheng
2020-12-15 16:32 ` Rob Herring
2020-12-12 5:12 ` [RFC PATCH 11/12] ARM: dts: sun8i: add DTSI file for V831 Icenowy Zheng
2020-12-14 14:39 ` Maxime Ripard
2020-12-12 5:13 ` [RFC PATCH 12/12] [DO NOT MERGE] ARM: dts: sun8i: v831: add a device tree file for Y20GA Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214142118.bxdzu7z7cdomhgy7@gilmour \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox