From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 334F9C2BB9A for ; Mon, 14 Dec 2020 20:04:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1877207A0 for ; Mon, 14 Dec 2020 20:04:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1877207A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VAYuLRkx4UoQYpOp2g33RW7uH08JaAMp8DqPLVJDuRo=; b=O28zEXvvB2e/IpyAH65ezsJkJ+ m7nrSeDn4Z1ggMAOLsaPxdNUIIhyx17RGBJ8ho7n846TqY52gfa77hGyH5RS395KtMPK++FoS4ZFS J25Dxyq1MGi/SK1/o8aCM1Ky2YNm0RFfTP/KLZxNQZTcKIIIgbf2aixCSye6IDD1mLhtsfEGl37vl B0XJsLEC8mSO5K8sT5znGty5kFPiTe/6atbflMhagfuGlIgvMC7SfNDDkokVh3Iuw+ekZ0BuhLusa dTZkTj5wnPjl2YpC8YNQvZVIKkL9xACmymMhSSQ5acbh5vqu3QkWb22jeqQChbh1p7LKU67QQKO7h rFwfqp9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kou48-0007UE-6q; Mon, 14 Dec 2020 20:03:28 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kou45-0007T2-EE for linux-arm-kernel@lists.infradead.org; Mon, 14 Dec 2020 20:03:26 +0000 Received: by mail-pl1-x641.google.com with SMTP id y8so9378570plp.8 for ; Mon, 14 Dec 2020 12:03:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=id/Q5ao6THistubUC4V3inH2fBZpq87NgTKXp27iujY=; b=Ah7IwggI4z9FHB9YbqLDpj0nCp9uUjVuQkXErTXTYqynlfQmuvYA/CfhxB8gw6N9BC HG67Iq68JFApt8mGenms10a8fNTb5JsuoWXEtogvyqPdZP7FmFkB9ljRwdL4NRpuwzjG M0Bpfdrwg3x31h+drs15tcIqwfjErlthCxte5M7XGlRzs02sCnVvcLOYKhedn8YGB0vE KzlYatfyyvZVCZ2VOypXNWPdCmSDNoTSDYLhI4cHDorUzuAOrqbFJmx8qb3mUHU+ghLD TmzGTf1nHnES3uxiI8qn3B6pkHyELmsBOf6IK5Dn/JaVIaOYWJgIKwlIQRx/g61ecqAx ME3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=id/Q5ao6THistubUC4V3inH2fBZpq87NgTKXp27iujY=; b=beoNVgh6DESStLURjZMvUr3dd1foBJhN/jCWhYpFlbvnmULxd7qhZUu7QsPe8x19Q6 MYZrE7gFRAorpgmEk242A2GRHANutlvi32+qwQ2pjikqqWcg0RW4VtwmY45JszqsfSVI 2PbV9pBD4omPxZT7CLbf0PxJ+oD5CXuC+ZohRWzHWBxpMylGEXjulMZ8OCt8ajaGIfAb NxidQ+1CpE45eKNNFZHZ5eVovf4fBx5rIHpeC6FK/qBnok2c904xY8hjlni8PStUWDLY AEBstbCQ2H1AHkJQsjT2sZ7OuU+v138hfB4XVToGdgIc5utjyholJYo87Kd30xqr5Op5 h4WQ== X-Gm-Message-State: AOAM530Hv76EkXQMb/1WVF7CZPUw6BLzVXny5NIDhOXmpM3nDdZMnKNG JqK4hnM84Am2hCCqju2lJXuC/g== X-Google-Smtp-Source: ABdhPJwqXwB839aTHuuRfA5fv8f6XIPiV7G7EQ2SPaHJbY5OdwVed//y4tVkvbHpfUDXRFHMnDxotg== X-Received: by 2002:a17:90b:1294:: with SMTP id fw20mr26654548pjb.187.1607976203320; Mon, 14 Dec 2020 12:03:23 -0800 (PST) Received: from localhost.localdomain ([163.172.76.58]) by smtp.googlemail.com with ESMTPSA id js9sm22434109pjb.2.2020.12.14.12.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Dec 2020 12:03:22 -0800 (PST) From: Corentin Labbe To: arnd@arndb.de, davem@davemloft.net, herbert@gondor.apana.org.au, jernej.skrabec@siol.net, mripard@kernel.org, wens@csie.org Subject: [PATCH v4 5/8] crypto: sun4i-ss: initialize need_fallback Date: Mon, 14 Dec 2020 20:02:29 +0000 Message-Id: <20201214200232.17357-6-clabbe@baylibre.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201214200232.17357-1-clabbe@baylibre.com> References: <20201214200232.17357-1-clabbe@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201214_150325_535888_7E50F272 X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-sunxi@googlegroups.com, Corentin Labbe , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The need_fallback is never initialized and seem to be always true at runtime. So all hardware operations are always bypassed. Fixes: 0ae1f46c55f87 ("crypto: sun4i-ss - fallback when length is not multiple of blocksize") Cc: Signed-off-by: Corentin Labbe --- drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c index e097f4c3e68f..5759fa79f293 100644 --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c @@ -179,7 +179,7 @@ static int sun4i_ss_cipher_poll(struct skcipher_request *areq) unsigned int obo = 0; /* offset in bufo*/ unsigned int obl = 0; /* length of data in bufo */ unsigned long flags; - bool need_fallback; + bool need_fallback = false; if (!areq->cryptlen) return 0; -- 2.26.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel