From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B5BFC4361B for ; Tue, 15 Dec 2020 09:13:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D972222225 for ; Tue, 15 Dec 2020 09:13:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D972222225 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sJf1O/o6O01hSd+mEmOKR1NWdRMjLsV4me1hxCI7BGE=; b=WFrWA97tn99FjHqbr+MsiE/Ro z3fWSRBSq6g/NwneZoCDT0u7JPYbnIUbqI9v8MaL07mbV8zrdg+tIubz1FWe8tmdvudUHH39RlqZX 00Pjh2P3Lx5BE6Xm2dEGjOxXrfBQj6p0lQiTfU+a982zEIuOrRUr+YEDz2uIiEIlxgOMFWhmlJ0n/ uOlJ8njNbyO/rkgoQ7hLtwDUCcc9bKcoXXggxtTGGveUCeTWC0oFjN352OEqVOblLhHz4fPP9UG+T vsIc+8/h285B5FkEldGk1w41OcPw9SaybFUPHWxeihMNelVW2bjYkGTz/fNxM/EXxMmAJ0xC5v/eY UmOHQdERA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp6Mf-0005bj-86; Tue, 15 Dec 2020 09:11:25 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp6Mb-0005b9-RQ for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 09:11:22 +0000 Received: by mail-ed1-f67.google.com with SMTP id q16so20155626edv.10 for ; Tue, 15 Dec 2020 01:11:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=76YNNvedxwQavmwaTRQKT3yfhwPKPqBSFxsGhUfBxyc=; b=V5U14Aa6q/zj47pJLoeM5hwCi1Wcu3eDhyXdDXGv1dIQaSCWlBDuUFMkcG6fvqjrEv 6QazZKpmLhUVLWDxfSlEV7rEcU129hjl9t039QFvETNjLqwdRih4d4XXng3O4fCs9uvj 5pZVjd0ilW9ZSWVCRC+ZNYMT0d5GzWnPA4prLDnir/rDmEJ0N649lC17JAr26VW2UfS+ 5UPTL8AMQ9HrDmmE2+Q8m0Weh6LsiqsQdAF3FfSF9vvfnETHvQs+fAwrV6nzCuVGjKTR vKWN6wLd17c3fKfAtE6WMJvT9TiBIe0WP7W4U1AlSjBRfyMzWxtKFsvbFxYE5Fv8KSgS MkpQ== X-Gm-Message-State: AOAM531g7RDzAFFvgaGGgWFkFvbd7vHW2eCY6qUijUsbUS1JgjV6wH5S pdyZbDOex7mwRABu1uxA1ds= X-Google-Smtp-Source: ABdhPJxiThtphqQmSV9KKflcAj0vuSGsG4tG5fs8gYfwTz2ko3RETBBR9qsNQj6TcljGF9n3m7sdfA== X-Received: by 2002:aa7:d6d8:: with SMTP id x24mr29163229edr.105.1608023480321; Tue, 15 Dec 2020 01:11:20 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id d8sm14289205edm.75.2020.12.15.01.11.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 01:11:19 -0800 (PST) Date: Tue, 15 Dec 2020 10:11:18 +0100 From: Krzysztof Kozlowski To: "Alice Guo (OSS)" Subject: Re: [PATCH v7 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Message-ID: <20201215091118.GB9386@kozik-lap> References: <20201215083551.6067-1-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201215083551.6067-1-alice.guo@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_041121_938865_AAF49490 X-CRM114-Status: GOOD ( 22.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 15, 2020 at 04:35:48PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo > --- > > Changes for v7: > - change to a separate schema file > Changes for v6: > - none > Changes for v5: > - correct the error of using allOf > Changes for v4: > - use allOf to limit new version DTS files for i.MX8M to include > "fsl,imx8m*-soc", nvmem-cells and nvmem-cells-names > Changes for v3: > - put it into Documentation/devicetree/bindings/arm/fsl.yaml > - modify the description of nvmem-cells > - use "make ARCH=arm64 dtbs_check" to make sure it is right > Changes for v2: > - remove the subject prefix "LF-2571-1" > > .../bindings/soc/imx/imx8m-soc.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > new file mode 100644 > index 000000000000..a2f7dc0c9b35 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/imx/imx8m-soc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8M Series SoC > + > +maintainers: > + - Alice Guo > + > +description: | > + NXP i.MX8M series SoCs contain fuse entries from which SoC Unique ID can be > + obtained. > + > +select: Mhm, there are other compatibles here so indeed, select is needed. > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mm > + - fsl,imx8mn > + - fsl,imx8mp > + - fsl,imx8mq > + required: > + - compatible This does not work - does not match anything. It seems you missed proper "required" for the matched node. Provide also an example. Best regards, Krzysztof > + > +properties: > + soc: > + type: object > + properties: > + compatible: > + items: > + - enum: > + - fsl,imx8mm-soc > + - fsl,imx8mn-soc > + - fsl,imx8mp-soc > + - fsl,imx8mq-soc > + - const: simple-bus > + > + nvmem-cells: > + maxItems: 1 > + description: Phandle to the SOC Unique ID provided by a nvmem node > + > + nvmem-cells-names: > + const: soc_unique_id > + > + required: > + - compatible > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: true > +... > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel