From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F41DC4361B for ; Tue, 15 Dec 2020 09:16:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C476222225 for ; Tue, 15 Dec 2020 09:16:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C476222225 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HOi6GuXxdPgcqkNr9JcPiApCe1bMOqrmE7gvjbvgnbU=; b=OvUICJk4YGD2ONxfhOufreOsV hc7edkO6EIbiuRnb1IVKniJ78Zdjq+Ea1CFhuNHBrd9efd06W2MlO/6iLpPWz09PDJpQ3+2bzIi/J gF6tFXxfzkvb90ys/N2FRw43/IkP7fSyCyAwYiECjV1BiXk8pcIyUqcM/ItfSQws/QrCcSFlFpo4t tdAW9waNukKuijoMtyTgkOR8s94orWGIVfbsXdLf8Xcn29RtIstU8SDYv5a1imYBgqVHc9y663cDT MzHPG/z8JDUVESTWUDRuN14s86ZGQxBaL7xI/8E/ZcsaCkIijjc3hOfOTwLWfspIHp86QwB5lgjr6 2UauIE2RQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp6Q0-0006CK-24; Tue, 15 Dec 2020 09:14:52 +0000 Received: from aserp2130.oracle.com ([141.146.126.79]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp6Py-0006BA-0h for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 09:14:51 +0000 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BF9E5Hc149147; Tue, 15 Dec 2020 09:14:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=QTr9uNr7ii2CFktvUpD4C/m814MZe6sSbFaDTHiN46s=; b=Fkyi3/n9DUBQFJo65Z7mZWx3xDrAOIPfYAsbGHyltczTEU1cBlFx1+Zpmbbih3webVhr DYAhx++YpuFWYFzuiqrI2ISY2mOQazsntUegr2Q2iXbIk4I+eKERsDjcmjNISbSs5P7g //AXwGiVpC+HsBiASWI4swzFuzBLsfHZRzyGFaCsFRUczlb68QRgfWeg2Cu+l3vu77iS IfLdZUijOr6ejWOaieB7/sWFc1ZWZRI+Wru0uEDE/ypx/ylvvAvfuD3YpJtuaH2FRAwU VQtQsF3WilLy8Ysb5XiWkWOJAmgIhZoxB7RyeUnH9Fhu9lc6E7Qi9eg1AIdcqSm7XXyr MA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 35ckcb9jyv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 15 Dec 2020 09:14:11 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BF94wZH034720; Tue, 15 Dec 2020 09:12:10 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 35e6eq5chg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Dec 2020 09:12:10 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BF9C50e031675; Tue, 15 Dec 2020 09:12:07 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 15 Dec 2020 01:12:04 -0800 Date: Tue, 15 Dec 2020 12:11:53 +0300 From: Dan Carpenter To: Maxime Ripard Subject: Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function Message-ID: <20201215091153.GH2809@kadam> References: <20201214202117.146293-1-christophe.jaillet@wanadoo.fr> <20201215085655.ddacjfvogc3e33vz@gilmour> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201215085655.ddacjfvogc3e33vz@gilmour> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9835 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012150063 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9835 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 priorityscore=1501 mlxscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1011 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012150064 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_041450_209400_1B5C814E X-CRM114-Status: GOOD ( 19.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: song.bao.hua@hisilicon.com, jernej.skrabec@siol.net, f.fainelli@gmail.com, leon@kernel.org, timur@kernel.org, netdev@vger.kernel.org, wangyunjian@huawei.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, wens@csie.org, Christophe JAILLET , kuba@kernel.org, sr@denx.de, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: > > 'irq_of_parse_and_map()' should be balanced by a corresponding > > 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks. > > Do you have a source to back that? It's not clear at all from the > documentation for those functions, and couldn't find any user calling it > from the ten-or-so random picks I took. It looks like irq_create_of_mapping() needs to be freed with irq_dispose_mapping() so this is correct. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel