From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E28D8C4361B for ; Tue, 15 Dec 2020 11:38:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95963206D5 for ; Tue, 15 Dec 2020 11:38:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95963206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XNTdnGyTBZnfjMr7hAWVxZt/+VNIA1RbyD7WMSjIML4=; b=gaoRED89TJs506126D374ZWKm T+darRN/pneThWxmxLZFnr83DX2RyvnnsN/90TqdiA/PdZE68WUPK4nAvAYYn4d/lg47ckysCOrsA n70ifRQPV/Zra7V3K2AFAhAmm7hV52c64z13fMFQaxC+oqAO2WEdFjJv9Ye8AITIBwp6dUnenlAdk JNJ0AazVMwg9EEhgVoOvHhgiLPiDAR/QKcFxILsc8jQKIhOcRo/FoLFBQ628N4re3HLTnp6VZK200 7JDNTR5sgXQ4EZoIbByL9hxEPRPV1cjCasQBh8fYEM2/J5fqf8lEQeEvKOeVmLiGQUewB4sZJ9qL4 Ka2nytwzg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp8dr-0007mi-RI; Tue, 15 Dec 2020 11:37:19 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp8dp-0007mN-I2 for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 11:37:18 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 5371A580397; Tue, 15 Dec 2020 06:37:13 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 15 Dec 2020 06:37:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=AFuIKgjw3WQKcS4EGTNGDedZlPw i+JZ5/cwhmXUQG3o=; b=WUkXbOedEpV8dAFGuREzjepXVrcDhZVExqGy1m5ttCI bwpO7qdL/dGLJh2DU9hjqyCEwB1aWMNRpHj+2dpvNVeCen3gD9RIAWYLsRAvfFrG cRwGH0Qg1ZwwaFXuHajTFtKx4T2rT1h7ewenLiJIM3BcJUGaKWeE1dg+rrpG8MlN 0XXltan4TaUWaUvDXE4qUvuH4ZDiSJIa8rXm1AtogOl2ZIT45q4wXJXO/cR/tpqw zRQCp2HDwi7lJs9hHdCVMSYy1sXg9Mg+IbMqh4ks8UEMxIkIXv5UAMNY2wb/0VxY /A878nE31KqgB+IFtvEEDFlLPd2ecJImpc2TlDMDMdA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=AFuIKg jw3WQKcS4EGTNGDedZlPwi+JZ5/cwhmXUQG3o=; b=f9S7kxHEYpCdmnSvZBuQhD 87kV0YBwQyoWt7zomfzEmARxlaxPJ49EKzmLodh6wGEEn+MSmOT4mJ62VeFWmCNs 7iVK1pnRJZkF+ivl5wre8j1LkcBdfmbh3Pe+jS/IUCURyo6lT1KHB+BUpSiu4n6E VQYYTI5j9Iek9DFduMuWoHja7LKn7RvvmweNAi/8wt9+6PCtqZxxfxo8cQo6ekVu pphqro4Y8IBk0nW2KilobmYLatY4uTwwzOp5UMhr1KvQHWbo5s5adknHw9oq2G6g 3weZK6pfefvNWryvyhpfuk2yAhg/Oj1cZNSyp51zOOi3FjpLWpg2RNI9HPc1GkmQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeltddgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 805E71080064; Tue, 15 Dec 2020 06:37:11 -0500 (EST) Date: Tue, 15 Dec 2020 12:37:10 +0100 From: Maxime Ripard To: Dan Carpenter Subject: Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function Message-ID: <20201215113710.wh4ezrvmqbpxd5yi@gilmour> References: <20201214202117.146293-1-christophe.jaillet@wanadoo.fr> <20201215085655.ddacjfvogc3e33vz@gilmour> <20201215091153.GH2809@kadam> MIME-Version: 1.0 In-Reply-To: <20201215091153.GH2809@kadam> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_063717_845599_11FD48B8 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: song.bao.hua@hisilicon.com, jernej.skrabec@siol.net, f.fainelli@gmail.com, leon@kernel.org, timur@kernel.org, netdev@vger.kernel.org, wangyunjian@huawei.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, wens@csie.org, Christophe JAILLET , kuba@kernel.org, sr@denx.de, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com Content-Type: multipart/mixed; boundary="===============6768558287139994370==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6768558287139994370== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3jnlnqak5zfuvw2l" Content-Disposition: inline --3jnlnqak5zfuvw2l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: > On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: > > Hi, > >=20 > > On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: > > > 'irq_of_parse_and_map()' should be balanced by a corresponding > > > 'irq_dispose_mapping()' call. Otherwise, there is some resources leak= s. > >=20 > > Do you have a source to back that? It's not clear at all from the > > documentation for those functions, and couldn't find any user calling it > > from the ten-or-so random picks I took. >=20 > It looks like irq_create_of_mapping() needs to be freed with > irq_dispose_mapping() so this is correct. The doc should be updated first to make that clear then, otherwise we're going to fix one user while multiples will have poped up Maxime --3jnlnqak5zfuvw2l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9if5gAKCRDj7w1vZxhR xcrsAQCAqxdmtzOx5x2uljGYBPES+hoL5VtWTPYJ7galIKwmeQD9FLlD8pXyN4+t mmaQfNPJYJvD1vLewe+K5RjOzDRO3wA= =v6FU -----END PGP SIGNATURE----- --3jnlnqak5zfuvw2l-- --===============6768558287139994370== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6768558287139994370==--