From: Catalin Marinas <catalin.marinas@arm.com>
To: John Millikin <jmillikin@gmail.com>
Cc: Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: Support running gen_vdso_offsets.sh with BSD userland.
Date: Tue, 15 Dec 2020 12:41:04 +0000 [thread overview]
Message-ID: <20201215124104.GC2511@gaia> (raw)
In-Reply-To: <CAL1ky9ptQT6G_Y37WWOkNohy50otWnc4dGAeGO_Gs6BTLX4Gag@mail.gmail.com>
On Mon, Dec 14, 2020 at 05:03:52PM +0900, John Millikin wrote:
> BSD sed ignores whitespace character escape sequences such as '\t' in
> the replacement string, causing this script to produce the following
> incorrect output:
>
> #define vdso_offset_sigtrampt0x089c
>
> Changing the hard tab to ' ' causes both BSD and GNU dialects of sed
> to produce equivalent output.
>
> Signed-off-by: John Millikin <john@john-millikin.com>
> ---
> arch/arm64/kernel/vdso/gen_vdso_offsets.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/vdso/gen_vdso_offsets.sh b/arch/arm64/kernel/
> vdso/gen_vdso_offsets.sh
> index 8b806eacd0a6..0387209d65b1 100755
> --- a/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
> +++ b/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
> @@ -13,4 +13,4 @@
>
> LC_ALL=C
> sed -n -e 's/^00*/0/' -e \
> -'s/^\([0-9a-fA-F]*\) . VDSO_\([a-zA-Z0-9_]*\)$/\#define vdso_offset_\2\t0x\1/
> p'
> +'s/^\([0-9a-fA-F]*\) . VDSO_\([a-zA-Z0-9_]*\)$/\#define vdso_offset_\2 0x\1/p'
> --
> 2.24.3 (Apple Git-128)
I'm ok with the patch but could you please send it with git send-email?
More importantly, as text/plain as it arrived as html in my inbox and
the mailing list blocked it.
Thanks.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2020-12-15 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAL1ky9ptQT6G_Y37WWOkNohy50otWnc4dGAeGO_Gs6BTLX4Gag@mail.gmail.com>
2020-12-15 12:41 ` Catalin Marinas [this message]
2020-12-23 5:10 [PATCH] arm64: Support running gen_vdso_offsets.sh with BSD userland John Millikin
2021-01-20 13:01 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215124104.GC2511@gaia \
--to=catalin.marinas@arm.com \
--cc=jmillikin@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).