From: Mark Brown <broonie@kernel.org>
To: Hsin-hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: devicetree@vger.kernel.org, Wen Su <wen.su@mediatek.com>,
srv_heupstream@mediatek.com, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/8] dt-bindings: regulator: Add document for MT6359 regulator
Date: Wed, 16 Dec 2020 13:05:48 +0000 [thread overview]
Message-ID: <20201216130548.GB4861@sirena.org.uk> (raw)
In-Reply-To: <1608093259.2412.1.camel@mtksdaap41>
[-- Attachment #1.1: Type: text/plain, Size: 897 bytes --]
On Wed, Dec 16, 2020 at 12:34:19PM +0800, Hsin-hsiung Wang wrote:
> On Wed, 2020-09-23 at 17:24 +0100, Mark Brown wrote:
> > On Mon, Sep 21, 2020 at 07:48:10PM +0800, Hsin-Hsiung Wang wrote:
> > > +Required properties:
> > > +- compatible: "mediatek,mt6359-regulator"
> > The compatible isn't used by the driver (which is good!) so should be
> > dropped from the binding document.
> Thanks for your comments, but I have a question about it.
> When I remove the compatible name in the dts, there will be some error
> message:
> [ 0.437562] mt6359-regulator: Failed to locate of_node [id: -1]
> [ 0.440612] mt6359-sound: Failed to locate of_node [id: -1]
> Do you mean that we don't need any compatible name in dts, mfd and
> regulator driver?
The MFD driver and DT node for the MFD will need a compatible. The
regulator function doesn't, it can just look things up based on the
parent.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-16 13:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 11:48 [PATCH v2 0/8] Add Support for MediaTek PMIC MT6359 Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 1/8] mfd: mt6358: refine interrupt code Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 2/8] dt-bindings: mfd: Add compatible for the MediaTek MT6359 PMIC Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 3/8] dt-bindings: regulator: Add document for MT6359 regulator Hsin-Hsiung Wang
2020-09-23 16:24 ` Mark Brown
2020-12-16 4:34 ` Hsin-hsiung Wang
2020-12-16 13:05 ` Mark Brown [this message]
2020-09-21 11:48 ` [PATCH v2 4/8] mfd: Add support for the MediaTek MT6359 PMIC Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 5/8] regulator: mt6359: Add support for MT6359 regulator Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 6/8] regulator: mt6359: Set the enable time for LDOs Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 7/8] regulator: mt6359: Add support for MT6359P regulator Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes Hsin-Hsiung Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216130548.GB4861@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=wen.su@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox