From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D5E7C4361B for ; Wed, 16 Dec 2020 13:41:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2879223105 for ; Wed, 16 Dec 2020 13:41:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2879223105 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HPfzPD5Yqb7uvdqY0okg0R2OvBWVRPJ2BMBKAsp5aSg=; b=ae6D+6/Rko3CXA1p+H2AwPb7f kQQMKuUQ6hvUELMaNiv3nXswtoYRUxFcdXvhXP82fNdo/DGVd4xMeaIqOgwqhBo+6p3sSmhVUJXMc aCWVdkLTtcFHasQyKH2omLzdeU/Wa3FiZ9BcW7TouJxBgrKWh9yTz/BYwe03cVj3lPaEjEzIiOkD8 LPh/NEURtKRctOvDFkIf4Y/WQOI+9d2d3WEgJFVpa7GyCzQHlUkCQw5ofm/7I2nVfvAd5kLyq9o3q HX6zo0R0EdTyK7xhf1S87oXd96wM4yV1RLl3TBNIQJBd0FNrHDF7+bKOLgT/OPhU4yCSENLhJWhpR LZjoGOpBg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpX2Y-0003Io-Mf; Wed, 16 Dec 2020 13:40:26 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpX2V-0003I4-Te for linux-arm-kernel@lists.infradead.org; Wed, 16 Dec 2020 13:40:25 +0000 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 02B31200005; Wed, 16 Dec 2020 13:40:15 +0000 (UTC) Date: Wed, 16 Dec 2020 14:40:15 +0100 From: Alexandre Belloni To: Claudiu Beznea Subject: Re: [PATCH 1/3] power: reset: at91-sama5d2_shdwc: fix wkupdbc mask Message-ID: <20201216134015.GF2814589@piout.net> References: <1608123453-1423-1-git-send-email-claudiu.beznea@microchip.com> <1608123453-1423-2-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1608123453-1423-2-git-send-email-claudiu.beznea@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201216_084024_057566_B0817556 X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, sre@kernel.org, ludovic.desroches@microchip.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/12/2020 14:57:31+0200, Claudiu Beznea wrote: > According to datasheet WKUPDBC mask is b/w bits 26..24. > > Fixes: f80cb48843987 ("power: reset: at91-shdwc: add new shutdown controller driver") > Signed-off-by: Claudiu Beznea Reviewed-by: Alexandre Belloni > --- > drivers/power/reset/at91-sama5d2_shdwc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c > index e90368ed6f71..3996167f676f 100644 > --- a/drivers/power/reset/at91-sama5d2_shdwc.c > +++ b/drivers/power/reset/at91-sama5d2_shdwc.c > @@ -37,7 +37,7 @@ > > #define AT91_SHDW_MR 0x04 /* Shut Down Mode Register */ > #define AT91_SHDW_WKUPDBC_SHIFT 24 > -#define AT91_SHDW_WKUPDBC_MASK GENMASK(31, 16) > +#define AT91_SHDW_WKUPDBC_MASK GENMASK(26, 24) > #define AT91_SHDW_WKUPDBC(x) (((x) << AT91_SHDW_WKUPDBC_SHIFT) \ > & AT91_SHDW_WKUPDBC_MASK) > Maybe you would switch to FIELD_PREP to remove the need for 2 of those 3 macros and would have made the issue apparent right away. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel