linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	linux-pm@vger.kernel.org, Rafael Wysocki <rjw@rjwysocki.net>,
	linux-kernel@vger.kernel.org,
	Peter Puhov <peter.puhov@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC V2 0/2] cpufreq: cppc: Add support for frequency invariance
Date: Wed, 16 Dec 2020 19:50:03 +0000	[thread overview]
Message-ID: <20201216195003.GA21585@arm.com> (raw)
In-Reply-To: <cover.1608030508.git.viresh.kumar@linaro.org>

Hi,

On Tuesday 15 Dec 2020 at 16:46:34 (+0530), Viresh Kumar wrote:
> Hello,
> 
> CPPC cpufreq driver is used for ARM servers and this patch series tries
> to provide frequency invariance support for them.
> 

Nitpick: cppc_cpufreq already supports cpufreq-based frequency
invariance, but not counter-based frequency invariance, when lacking
AMUs :).

> This is tested with some hacks, as I didn't have access to the right
> hardware, on the ARM64 hikey board to check the overall functionality
> and that works fine.
> 
> Ionela/Peter Puhov, it would be nice if you guys can give this a shot.
> 

I'll be on holiday starting tomorrow until January. I fully intend to
review and test this but I'll have to set myself a deadline for January
to do it.

Sorry for the delay,
Ionela.

> This is based of pm/linux-next and patches [1] and [2] which I sent
> recently to cleanup arm64 topology stuff.
> 
> Changes since V1:
> - The interface for setting the callbacks is improved, so different
>   parts looking to provide their callbacks don't need to think about
>   each other.
> 
> - Moved to per-cpu storage for storing the callback related data, AMU
>   counters have higher priority with this.
> 
> --
> viresh
> 
> [1] https://lore.kernel.org/lkml/7a171f710cdc0f808a2bfbd7db839c0d265527e7.1607579234.git.viresh.kumar@linaro.org/
> [2] https://lore.kernel.org/lkml/5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org/
> 
> Viresh Kumar (2):
>   topology: Allow multiple entities to provide sched_freq_tick()
>     callback
>   cpufreq: cppc: Add support for frequency invariance
> 
>  arch/arm64/include/asm/topology.h |   8 +-
>  arch/arm64/kernel/topology.c      |  89 +++++++++----------
>  drivers/base/arch_topology.c      |  56 +++++++++++-
>  drivers/cpufreq/cppc_cpufreq.c    | 140 +++++++++++++++++++++++++++++-
>  include/linux/arch_topology.h     |  14 ++-
>  kernel/sched/core.c               |   1 +
>  6 files changed, 244 insertions(+), 64 deletions(-)
> 
> -- 
> 2.25.0.rc1.19.g042ed3e048af
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2020-12-16 19:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 11:16 [RFC V2 0/2] cpufreq: cppc: Add support for frequency invariance Viresh Kumar
2020-12-15 11:16 ` [RFC V2 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback Viresh Kumar
2021-01-13 16:18   ` Ionela Voinescu
2021-01-15  7:48     ` Viresh Kumar
2021-01-19 19:05       ` Ionela Voinescu
2021-01-22  7:44         ` Viresh Kumar
2020-12-16 19:50 ` Ionela Voinescu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201216195003.GA21585@arm.com \
    --to=ionela.voinescu@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peter.puhov@linaro.org \
    --cc=rjw@rjwysocki.net \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).