[PATCH 0/2] Add watchdog dt nodes for TI's J7200 SoC

[PATCH 0/2] Add watchdog dt nodes for TI's J7200 SoC

[Gowtham Tammana]

Adds the watchdog dt node for TI's J7200 SoC. Also included a minor fix
to the dt binding document to make it consistent with naming convention.

Gowtham Tammana (2):
  dt-bindings: watchdog: change node name to generic
  arm64: dts: ti: k3-j7200-main: Add main domain watchdog entries

 .../bindings/watchdog/ti,rti-wdt.yaml          |  4 ++--
 arch/arm64/boot/dts/ti/k3-j7200-main.dtsi      | 18 ++++++++++++++++++
 2 files changed, 20 insertions(+), 2 deletions(-)

-- 
2.29.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/2] dt-bindings: watchdog: change node name to generic

[Gowtham Tammana]

Modifying the example to use generic as node name to keep it consistent
with the generic name recommendation.

Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
---
 Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
index c1348db59374..e21af390b3e9 100644
--- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
@@ -57,8 +57,8 @@ examples:
      */
     #include <dt-bindings/soc/ti,sci_pm_domain.h>
 
-    watchdog0: rti@2200000 {
-        compatible = "ti,rti-wdt";
+    watchdog0: watchdog@2200000 {
+        compatible = "ti,j7-rti-wdt";
         reg = <0x2200000 0x100>;
         clocks = <&k3_clks 252 1>;
         power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
-- 
2.29.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] dt-bindings: watchdog: change node name to generic

[Nishanth Menon]

On 18:07-20201216, Gowtham Tammana wrote:
> Modifying the example to use generic as node name to keep it consistent
^^ Please don't state in commit message the actual change you are
doing.. We can see that from the diffstat. There are lots of
documentation now a days on smart commit messages, I suggest reading
those.

> with the generic name recommendation.


I think what you are doing here is to fix a typo in the example
provided to match with the compatible that is supposed to be used.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation//devicetree/bindings/watchdog/ti,rti-wdt.yaml#n26

While this change is valid, please:
a) Rewrite the commit message
b) Fix $subject "dt-bindings: watchdog: change node name to generic"
"dt-bindings: watchdog" is a huge range of watchdog driver scope, you
want to narrow it to the ti,rti
dt-bindings: watchdog: ti,rti:" or What ever wdt/dt maintainers may prefer.

"change node name to generic" -> yes, diff tells us that, you are trying
to fix a typo in the example, so please use the word fix to indicate
this is a fixup, not a new 'change' ..

c) Please CC subsystem maintainers.. I suppose these go through
subsystem maintainer trees once Rob Acks..


> 
> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> ---
>  Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> index c1348db59374..e21af390b3e9 100644
> --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> @@ -57,8 +57,8 @@ examples:
>       */
>      #include <dt-bindings/soc/ti,sci_pm_domain.h>
>  
> -    watchdog0: rti@2200000 {
> -        compatible = "ti,rti-wdt";
> +    watchdog0: watchdog@2200000 {
> +        compatible = "ti,j7-rti-wdt";
>          reg = <0x2200000 0x100>;
>          clocks = <&k3_clks 252 1>;
>          power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
> -- 
> 2.29.0
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] dt-bindings: watchdog: change node name to generic

[Gowtham A Tammana]

Nishanth Menon wrote:
> On 18:07-20201216, Gowtham Tammana wrote:
> > Modifying the example to use generic as node name to keep it consistent
> ^^ Please don't state in commit message the actual change you are
> doing.. We can see that from the diffstat. There are lots of
> documentation now a days on smart commit messages, I suggest reading
> those.
> 
> > with the generic name recommendation.
> 
> 
> I think what you are doing here is to fix a typo in the example
> provided to match with the compatible that is supposed to be used.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation//devicetree/bindings/watchdog/ti,rti-wdt.yaml#n26
> 
> While this change is valid, please:
> a) Rewrite the commit message
> b) Fix $subject "dt-bindings: watchdog: change node name to generic"
> "dt-bindings: watchdog" is a huge range of watchdog driver scope, you
> want to narrow it to the ti,rti
> dt-bindings: watchdog: ti,rti:" or What ever wdt/dt maintainers may prefer.
> 
> "change node name to generic" -> yes, diff tells us that, you are trying
> to fix a typo in the example, so please use the word fix to indicate
> this is a fixup, not a new 'change' ..
> 
> c) Please CC subsystem maintainers.. I suppose these go through
> subsystem maintainer trees once Rob Acks..

Thanks for the review here Nishant. Will make the suggested changes for v2.

Gowtham
> 
> > 
> > Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> > ---
> >  Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> > index c1348db59374..e21af390b3e9 100644
> > --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> > @@ -57,8 +57,8 @@ examples:
> >       */
> >      #include <dt-bindings/soc/ti,sci_pm_domain.h>
> >  
> > -    watchdog0: rti@2200000 {
> > -        compatible = "ti,rti-wdt";
> > +    watchdog0: watchdog@2200000 {
> > +        compatible = "ti,j7-rti-wdt";
> >          reg = <0x2200000 0x100>;
> >          clocks = <&k3_clks 252 1>;
> >          power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
> > -- 
> > 2.29.0
> > 
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] arm64: dts: ti: k3-j7200-main: Add main domain watchdog entries

[Gowtham Tammana]

Add DT entries for main domain watchdog instances.

Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
index 72d6496e88dd..de430d44c2a6 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
@@ -303,6 +303,24 @@ main_uart9: serial@2890000 {
 		clock-names = "fclk";
 	};
 
+	watchdog0: watchdog@2200000 {
+		compatible = "ti,j7-rti-wdt";
+		reg = <0x0 0x2200000 0x0 0x100>;
+		clocks = <&k3_clks 252 1>;
+		power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
+		assigned-clocks = <&k3_clks 252 1>;
+		assigned-clock-parents = <&k3_clks 252 5>;
+	};
+
+	watchdog1: watchdog@2210000 {
+		compatible = "ti,j7-rti-wdt";
+		reg = <0x0 0x2210000 0x0 0x100>;
+		clocks = <&k3_clks 253 1>;
+		power-domains = <&k3_pds 253 TI_SCI_PD_EXCLUSIVE>;
+		assigned-clocks = <&k3_clks 253 1>;
+		assigned-clock-parents = <&k3_clks 253 5>;
+	};
+
 	main_i2c0: i2c@2000000 {
 		compatible = "ti,j721e-i2c", "ti,omap4-i2c";
 		reg = <0x00 0x2000000 0x00 0x100>;
-- 
2.29.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-main: Add main domain watchdog entries

[Nishanth Menon]

On 18:07-20201216, Gowtham Tammana wrote:
> Add DT entries for main domain watchdog instances.

Please add a note to indicate that these are the only watchdogs that
are visible to Linux and ARMv8 systems.


You may need to repost the dts patch once you have the 
> 
> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> index 72d6496e88dd..de430d44c2a6 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> @@ -303,6 +303,24 @@ main_uart9: serial@2890000 {
>  		clock-names = "fclk";
>  	};
>  
> +	watchdog0: watchdog@2200000 {

If you are going to strengthen the node-names up (recommend we
do that), you might want to use a regex and lock things down.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation//devicetree/bindings/watchdog/ti,rti-wdt.yaml#n26

That is much better option that expecting people to read the example and
follow the convention.

> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x0 0x2200000 0x0 0x100>;
we try and keep 0x00 instead of 0x0 -> see other places in the dtsi
> +		clocks = <&k3_clks 252 1>;
> +		power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 252 1>;
> +		assigned-clock-parents = <&k3_clks 252 5>;
> +	};
> +
> +	watchdog1: watchdog@2210000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x0 0x2210000 0x0 0x100>;
> +		clocks = <&k3_clks 253 1>;
> +		power-domains = <&k3_pds 253 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 253 1>;
> +		assigned-clock-parents = <&k3_clks 253 5>;
> +	};
> +
>  	main_i2c0: i2c@2000000 {
>  		compatible = "ti,j721e-i2c", "ti,omap4-i2c";
>  		reg = <0x00 0x2000000 0x00 0x100>;

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-main: Add main domain watchdog entries

[Gowtham A Tammana]

Nishanth Menon wrote:
> On 18:07-20201216, Gowtham Tammana wrote:
> > Add DT entries for main domain watchdog instances.
> 
> Please add a note to indicate that these are the only watchdogs that
> are visible to Linux and ARMv8 systems.

Will update in v2.
> 
> You may need to repost the dts patch once you have the 
> > 
> > Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> > index 72d6496e88dd..de430d44c2a6 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> > @@ -303,6 +303,24 @@ main_uart9: serial@2890000 {
> >  		clock-names = "fclk";
> >  	};
> >  
> > +	watchdog0: watchdog@2200000 {
> 
> If you are going to strengthen the node-names up (recommend we
> do that), you might want to use a regex and lock things down.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation//devicetree/bindings/watchdog/ti,rti-wdt.yaml#n26
> 
> That is much better option that expecting people to read the example and
> follow the convention.

there's one defined in [1] which is listed as included schema.

[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/watchdog/watchdog.yaml#19

> 
> > +		compatible = "ti,j7-rti-wdt";
> > +		reg = <0x0 0x2200000 0x0 0x100>;
> we try and keep 0x00 instead of 0x0 -> see other places in the dtsi

Do see them now, will fix them in v2.

Thanks for the review,
Gowtham

> > +		clocks = <&k3_clks 252 1>;
> > +		power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
> > +		assigned-clocks = <&k3_clks 252 1>;
> > +		assigned-clock-parents = <&k3_clks 252 5>;
> > +	};
> > +
> > +	watchdog1: watchdog@2210000 {
> > +		compatible = "ti,j7-rti-wdt";
> > +		reg = <0x0 0x2210000 0x0 0x100>;
> > +		clocks = <&k3_clks 253 1>;
> > +		power-domains = <&k3_pds 253 TI_SCI_PD_EXCLUSIVE>;
> > +		assigned-clocks = <&k3_clks 253 1>;
> > +		assigned-clock-parents = <&k3_clks 253 5>;
> > +	};
> > +
> >  	main_i2c0: i2c@2000000 {
> >  		compatible = "ti,j721e-i2c", "ti,omap4-i2c";
> >  		reg = <0x00 0x2000000 0x00 0x100>;
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel