From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C5DCC4361B for ; Thu, 17 Dec 2020 10:56:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FAD02389B for ; Thu, 17 Dec 2020 10:56:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FAD02389B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4p2CIamnoQ2r+DKCDjtZFWVtrSXdm6zdZVPtMB64oao=; b=whpwFwXMKmblk8o0zAROXzHW7 a8F6AwCphk9vnsnlRl6Gv8cH2OvQy/3uqp5guvBqNiigLsf0q+sDeE50GaZOvRHU2IZK7n6mgn9dq DKjW67BN8MZIvq7CwbLO6I7RdDqErDHutGGEEZ9A/bmvb+W49hWsjx80idwje8Ws3SHWs196ypYyG JMEN9e9l9TiPo/qElwBuiie2oPUod089sQJKOAgO6tEDfBFRgSlOsq4FLRRcG1pvaAy/dq0eJmqgS 2QkFqfdWk2plbVwE+uONtxJSpcLh56WYPSrR7Lsb4zUU/dssJ/6XZb2fY07oTGOeZJTfrwKPjTpKO elHMYCEyg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpqwW-0004vg-Ef; Thu, 17 Dec 2020 10:55:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpqwU-0004ut-M4 for linux-arm-kernel@lists.infradead.org; Thu, 17 Dec 2020 10:55:31 +0000 Date: Thu, 17 Dec 2020 10:55:25 +0000 From: Catalin Marinas To: Viresh Kumar Subject: Re: [PATCH V3 1/3] arm64: topology: Avoid the have_policy check Message-ID: <20201217105524.GA15336@gaia> References: <5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org> <20201217075732.blac5pbca7prmuum@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201217075732.blac5pbca7prmuum@vireshk-i7> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201217_055530_808432_C0EE8EF5 X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , Ionela Voinescu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vincent Guittot Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Viresh, On Thu, Dec 17, 2020 at 01:27:32PM +0530, Viresh Kumar wrote: > On 15-12-20, 11:04, Viresh Kumar wrote: > > Every time I have stumbled upon this routine, I get confused with the > > way 'have_policy' is used and I have to dig in to understand why is it > > so. Here is an attempt to make it easier to understand, and hopefully it > > is an improvement. > > > > The 'have_policy' check was just an optimization to avoid writing > > to amu_fie_cpus in case we don't have to, but that optimization itself > > is creating more confusion than the real work. Lets just do that if all > > the CPUs support AMUs. It is much cleaner that way. > > > > Reviewed-by: Ionela Voinescu > > Signed-off-by: Viresh Kumar > > --- > > V3: > > - Added Reviewed by tag. > > Catalin, please pick the first two patches for 5.11. I will send the > last one separately later on. I haven't figured out whether these are fixes (a cover letter would help ;)). They look like generic improvements to me and given that we are already in the 5.11 merging window, they would probably need to wait until 5.12. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel