From: Andrew Lunn <andrew@lunn.ch>
To: kostap@marvell.com
Cc: tmn505@gmail.com, jaz@semihalf.com, gregory.clement@bootlin.com,
nadavh@marvell.com, robh+dt@kernel.org, stefanc@marvell.com,
mw@semihalf.com, bpeled@marvell.com,
linux-arm-kernel@lists.infradead.org,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH v2 3/4] arm64: dts: cn913x: add device trees for topology B boards
Date: Thu, 17 Dec 2020 16:41:02 +0100 [thread overview]
Message-ID: <20201217154102.GC2943708@lunn.ch> (raw)
In-Reply-To: <20201217075542.12472-4-kostap@marvell.com>
> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
> index 3e5f2e7a040c..d9b924a63d89 100644
> --- a/arch/arm64/boot/dts/marvell/Makefile
> +++ b/arch/arm64/boot/dts/marvell/Makefile
> @@ -13,6 +13,9 @@ dtb-$(CONFIG_ARCH_MVEBU) += armada-8040-db.dtb
> dtb-$(CONFIG_ARCH_MVEBU) += armada-8040-mcbin.dtb
> dtb-$(CONFIG_ARCH_MVEBU) += armada-8040-mcbin-singleshot.dtb
> dtb-$(CONFIG_ARCH_MVEBU) += armada-8080-db.dtb
> -dtb-$(CONFIG_ARCH_MVEBU) += cn9130-db.dtb
> -dtb-$(CONFIG_ARCH_MVEBU) += cn9131-db.dtb
> -dtb-$(CONFIG_ARCH_MVEBU) += cn9132-db.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += cn9130-db-A.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += cn9130-db-B.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += cn9131-db-A.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += cn9131-db-B.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += cn9132-db-A.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += cn9132-db-B.dtb
Are the filenames consider ABI? I wonder if cn9130-db A should
continue to be called cn9130-db.dtb? Are bootloaders and image
installers going to break because the filename changed?
The rest of the changes look fine.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-17 15:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 7:55 [PATCH v2 0/4] DTS updates for Marvell Armada CN913x platforms kostap
2020-12-17 7:55 ` [PATCH v2 1/4] Documentation/bindings: phy: update references to cp11x kostap
2020-12-17 7:55 ` [PATCH v2 2/4] arch/arm64/boot/dts/marvell: fix NAND partitioning scheme kostap
2020-12-17 15:36 ` Andrew Lunn
2020-12-17 7:55 ` [PATCH v2 3/4] arm64: dts: cn913x: add device trees for topology B boards kostap
2020-12-17 15:41 ` Andrew Lunn [this message]
2020-12-20 7:32 ` [EXT] " Kostya Porotchkin
2020-12-20 16:34 ` Andrew Lunn
2020-12-21 6:57 ` Kostya Porotchkin
2020-12-21 13:58 ` Andrew Lunn
2020-12-21 15:55 ` Kostya Porotchkin
2020-12-17 7:55 ` [PATCH v2 4/4] arm64: dts: add support for Marvell cn9130-crb platform kostap
2020-12-17 15:43 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217154102.GC2943708@lunn.ch \
--to=andrew@lunn.ch \
--cc=bpeled@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=jaz@semihalf.com \
--cc=kostap@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stefanc@marvell.com \
--cc=tmn505@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).