Re: [PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION

Mark Rutland
2020-11-25T10:37:22Z

On Tue, Nov 24, 2020 at 05:01:31PM +0800, Lecopzer Chen wrote:
> From: "Lecopzer Chen" <lecopzer.chen@mediatek.com>
>
> Although most of modern devices use ACPI, there still has combination
> of APM + ARM64.
>
> In order to select CONFIG_APM_EMULATION, make SYS_SUPPORTS_APM_EMULATION
> default is y if ACPI isn't configured.

I'm a bit confused why this should be enabled for !ACPI. Which DT
platforms need this, and how do they use it? Why should this only be
enabled for kernels without ACPI support, and not for kernels that
support both ACPI and DT?

Thanks,
Mark.

>
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> Suggested-by: YJ Chiang <yj.chiang@mediatek.com>
> ---
> arch/arm64/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 1515f6f153a0..5e9e3694015a 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -260,6 +260,9 @@ config NO_IOPORT_MAP
> config STACKTRACE_SUPPORT
> def_bool y
>
> +config SYS_SUPPORTS_APM_EMULATION
> + def_bool y if !ACPI
> +
> config ILLEGAL_POINTER_VALUE
> hex
> default 0xdead000000000000
> --
> 2.18.0