From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7EF8C4361B for ; Fri, 18 Dec 2020 08:54:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 659C6233FD for ; Fri, 18 Dec 2020 08:54:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 659C6233FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/eG6JnEvOn/azO3joDJ2+hSbc7tIO2TGv6d/VrIzvXg=; b=vviddW7wVv9Y9BVp3uEOmKC7h g87WIrxTioNNYuEZVVSvpjsgg8HvcA9gxiRtVoWZxGoEhDYQp3Su5aqVGw7ZRIlE3iVjW+2mCDOF3 k6+Df9MwAtRSzDlarucRWfdbpB0rpWdnxmIVMhIo8gWrQ78Ilj29zoWldShv/rNc750J7PTTUjZST eGdqG0rJi55nwdQpIqU+pP0EGyrrFBCLa7AXnJnfGGk7gv7Wdgx45q4Ib42qPyolHPtVrw08NDqWL eVXO9l+51k9u5nGMl/t0h3jvnp4jEt2JQKT9eU4TpGoGAsPOltM+TVKl7p+9o6ezYzvrvy3Wfzh/X Z4+QInPUg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqBV2-0007oc-1w; Fri, 18 Dec 2020 08:52:32 +0000 Received: from mail-ed1-f51.google.com ([209.85.208.51]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqBUz-0007o6-U3 for linux-arm-kernel@lists.infradead.org; Fri, 18 Dec 2020 08:52:30 +0000 Received: by mail-ed1-f51.google.com with SMTP id g24so1524308edw.9 for ; Fri, 18 Dec 2020 00:52:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0csNOja+WKBRpwxt14NEEdfV8rsfLIdAaIbOthj2HVU=; b=R3EkTe3yy9WIYjvOORpLcNtSRdxWQdbvEo80VzaDLTFYt6M6RZOszSaRtNrxVbY0Xq w6RHNf3SaXhMEQJtPOSt+OD4/hKwcYhf9itD36qT78MH4+vAkq8FjZB74/zrr7Dc56is npPZKoNKxygQCRSyW5hbLC0iy6385no7A5M9l/qZayrQQnrHKmEwIfJXQxQDceuAr2rz HU5j8v3ySMxVOQSDXaDo+tOtiumhMItqyhW0WmroXZ5tBzFmdTFhTHR7AAEt86Ic2dtS 41FqQhxAK4Bvc0+ze5WXAikarwO1HpOTNoeoOC1fWio4za4b4omDxcCh1nczkg1M02sr QldA== X-Gm-Message-State: AOAM530oZ1MgcQrSG6NXzTUO68ZyG2Gt7mfwnltnKlrWKlXagW9vsMK2 a89SGBzLLdyK/bDTgEWy5RE= X-Google-Smtp-Source: ABdhPJxLBgM6Ei7flL0dbggRC5UrRw7NGVH6EFLkDPBWlFDfBqvepMbckaowWLUL++7eEbESAL/U0w== X-Received: by 2002:a05:6402:687:: with SMTP id f7mr3282876edy.314.1608281545935; Fri, 18 Dec 2020 00:52:25 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id c14sm24884111edy.56.2020.12.18.00.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 00:52:25 -0800 (PST) Date: Fri, 18 Dec 2020 09:52:23 +0100 From: Krzysztof Kozlowski To: "Alice Guo (OSS)" Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Message-ID: <20201218085223.GA17306@kozik-lap> References: <20201218083726.16427-1-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201218083726.16427-1-alice.guo@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201218_035229_984631_4AD37A67 X-CRM114-Status: GOOD ( 20.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 18, 2020 at 04:37:23PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo > --- > > Changes for v8: > - match soc node with regular expression > Changes for v7: > - change to a separate schema file > Changes for v6: > - none > Changes for v5: > - correct the error of using allOf > Changes for v4: > - use allOf to limit new version DTS files for i.MX8M to include > "fsl,imx8m*-soc", nvmem-cells and nvmem-cells-names > Changes for v3: > - put it into Documentation/devicetree/bindings/arm/fsl.yaml > - modify the description of nvmem-cells > - use "make ARCH=arm64 dtbs_check" to make sure it is right > Changes for v2: > - remove the subject prefix "LF-2571-1" > > .../bindings/soc/imx/imx8m-soc.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > new file mode 100644 > index 000000000000..f0b0fc7b3ac6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/imx/imx8m-soc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8M Series SoC > + > +maintainers: > + - Alice Guo > + > +description: | > + NXP i.MX8M series SoCs contain fuse entries from which SoC Unique ID can be > + obtained. > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mm > + - fsl,imx8mn > + - fsl,imx8mp > + - fsl,imx8mq > + required: > + - compatible > + > +patternProperties: > + "^soc@[0-9a-f]+$": Thanks, now it works. > + type: object > + properties: > + compatible: > + items: > + - enum: > + - fsl,imx8mm-soc > + - fsl,imx8mn-soc > + - fsl,imx8mp-soc > + - fsl,imx8mq-soc > + - const: simple-bus > + > + nvmem-cells: > + maxItems: 1 > + description: Phandle to the SOC Unique ID provided by a nvmem node > + > + nvmem-cells-names: > + const: soc_unique_id > + > + required: > + - compatible > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: true Don't leave comments unresolved (or resolve them against review without discussion). Rob asked for changing it. The same as with all schemas - you need to describe the missing properties. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel