From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D9D2C4361B for ; Fri, 18 Dec 2020 11:02:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEC1B20784 for ; Fri, 18 Dec 2020 11:02:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEC1B20784 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4D7InzT4GY5zEAhS469kXSggM5pD6Hi9DPA5FJ3hNNE=; b=wrszx3ltj4Rt3oj2k028MmhQ5 eBXdQz8DM9r27NXndj4/wK8BjjEKncOUR26aISE8DpjLPiu3lnAnmbdQGua2TUtjPm4ZmQngMnPeI JZclI49wMsnYLPAcRIHYFN4h/oZnUSwEaLczlOSErNtmb6zKkUamIeddKOHhxteJEcOTt7020JMI8 umeZjU41+VgSPDYkE1EzUlyyZC7QrcZQABWsjqvXsucNTYaIeh5bav7b/or613PjBnEZNdIqzolNT ATmEwHkYy+zwez6F9A2LsVGpmRNAF1eKV+Q96UmYoZyGjvPjpLEcr4HurmbhCKVybs1qOV/+4/Ybn Qmqt6UMPw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqDVk-0001zy-MN; Fri, 18 Dec 2020 11:01:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqDVh-0001z3-Kb for linux-arm-kernel@lists.infradead.org; Fri, 18 Dec 2020 11:01:22 +0000 Date: Fri, 18 Dec 2020 11:01:15 +0000 From: Catalin Marinas To: Viresh Kumar Subject: Re: [PATCH V3 1/3] arm64: topology: Avoid the have_policy check Message-ID: <20201218110114.GD5258@gaia> References: <5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org> <20201217075732.blac5pbca7prmuum@vireshk-i7> <20201217105524.GA15336@gaia> <20201218042602.4ymy4fg2zxeo6p4n@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201218042602.4ymy4fg2zxeo6p4n@vireshk-i7> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201218_060121_745957_F8D1B65F X-CRM114-Status: GOOD ( 22.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , Ionela Voinescu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vincent Guittot Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 18, 2020 at 09:56:02AM +0530, Viresh Kumar wrote: > On 17-12-20, 10:55, Catalin Marinas wrote: > > Hi Viresh, > > > > On Thu, Dec 17, 2020 at 01:27:32PM +0530, Viresh Kumar wrote: > > > On 15-12-20, 11:04, Viresh Kumar wrote: > > > > Every time I have stumbled upon this routine, I get confused with the > > > > way 'have_policy' is used and I have to dig in to understand why is it > > > > so. Here is an attempt to make it easier to understand, and hopefully it > > > > is an improvement. > > > > > > > > The 'have_policy' check was just an optimization to avoid writing > > > > to amu_fie_cpus in case we don't have to, but that optimization itself > > > > is creating more confusion than the real work. Lets just do that if all > > > > the CPUs support AMUs. It is much cleaner that way. > > > > > > > > Reviewed-by: Ionela Voinescu > > > > Signed-off-by: Viresh Kumar > > > > --- > > > > V3: > > > > - Added Reviewed by tag. > > > > > > Catalin, please pick the first two patches for 5.11. I will send the > > > last one separately later on. > > > > I haven't figured out whether these are fixes (a cover letter would > > help ;)). They look like generic improvements to me > > Right they are and since the merge window just opened I thought these > don't really need to wait for another full cycle to get in. Normally we freeze the arm64 tree around the -rc6 prior to the merging window to give the patches a bit of time in linux-next. This time around, given the holidays, Linus even stated that if not already in -next at 5.10, it won't be pulled: https://lkml.org/lkml/2020/12/13/290. So please re-post at -rc1 with the acks in place. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel