public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Gowtham Tammana <g-tammana@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: change node name to generic
Date: Fri, 18 Dec 2020 08:02:13 -0600	[thread overview]
Message-ID: <20201218140213.gmgyahowalljvp3t@skittle> (raw)
In-Reply-To: <20201217000716.11091-2-g-tammana@ti.com>

On 18:07-20201216, Gowtham Tammana wrote:
> Modifying the example to use generic as node name to keep it consistent
^^ Please don't state in commit message the actual change you are
doing.. We can see that from the diffstat. There are lots of
documentation now a days on smart commit messages, I suggest reading
those.

> with the generic name recommendation.


I think what you are doing here is to fix a typo in the example
provided to match with the compatible that is supposed to be used.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation//devicetree/bindings/watchdog/ti,rti-wdt.yaml#n26

While this change is valid, please:
a) Rewrite the commit message
b) Fix $subject "dt-bindings: watchdog: change node name to generic"
"dt-bindings: watchdog" is a huge range of watchdog driver scope, you
want to narrow it to the ti,rti
dt-bindings: watchdog: ti,rti:" or What ever wdt/dt maintainers may prefer.

"change node name to generic" -> yes, diff tells us that, you are trying
to fix a typo in the example, so please use the word fix to indicate
this is a fixup, not a new 'change' ..

c) Please CC subsystem maintainers.. I suppose these go through
subsystem maintainer trees once Rob Acks..


> 
> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> ---
>  Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> index c1348db59374..e21af390b3e9 100644
> --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> @@ -57,8 +57,8 @@ examples:
>       */
>      #include <dt-bindings/soc/ti,sci_pm_domain.h>
>  
> -    watchdog0: rti@2200000 {
> -        compatible = "ti,rti-wdt";
> +    watchdog0: watchdog@2200000 {
> +        compatible = "ti,j7-rti-wdt";
>          reg = <0x2200000 0x100>;
>          clocks = <&k3_clks 252 1>;
>          power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
> -- 
> 2.29.0
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-12-18 14:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17  0:07 [PATCH 0/2] Add watchdog dt nodes for TI's J7200 SoC Gowtham Tammana
2020-12-17  0:07 ` [PATCH 1/2] dt-bindings: watchdog: change node name to generic Gowtham Tammana
2020-12-18 14:02   ` Nishanth Menon [this message]
2021-01-07  1:46     ` Gowtham A Tammana
2020-12-17  0:07 ` [PATCH 2/2] arm64: dts: ti: k3-j7200-main: Add main domain watchdog entries Gowtham Tammana
2020-12-18 14:07   ` Nishanth Menon
2021-01-07  1:34     ` Gowtham A Tammana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201218140213.gmgyahowalljvp3t@skittle \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=g-tammana@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox