From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE714C4361B for ; Fri, 18 Dec 2020 14:24:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DCFF23A84 for ; Fri, 18 Dec 2020 14:24:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DCFF23A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r4WZf4cRQnwusvpt4Uuvwag/jqwB5Lqht0yn34SdCtM=; b=1SX5ZlfDDWqsuzKoalOXakpqJ WxX6Y9VO1ViNZTTfp38VagXQl/NZYGARgqRz+VMDys1Ed5mQ4XCLe+67A/u8wANdXKsvuBVtkDEBG +kwr6T17UXbwGU3N8+cnq46yYBJaACCYi4j95YT4Y5i4mMpzpBHrEuc7z/UqrhJ5sgDI2+QwNUdti SBruSjCiHvWCEbsJqvWfpSX2fhwWEE8U6L1gk0JBCOsVmHzaefe9Kj7xDHnboduPLgoD41PFg2U1F vn0ZUiVQj8mvOIvn2OS4tPfGUKr6NIojl1c5RC+RUaBYmrdFcRcZ13QCc4gJ9wGLmTq5UrgG1MVdY K6FHqKHvQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqGei-0002PJ-Vx; Fri, 18 Dec 2020 14:22:53 +0000 Received: from mail-ej1-f48.google.com ([209.85.218.48]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqGeh-0002Ol-Bf for linux-arm-kernel@lists.infradead.org; Fri, 18 Dec 2020 14:22:52 +0000 Received: by mail-ej1-f48.google.com with SMTP id lt17so3463027ejb.3 for ; Fri, 18 Dec 2020 06:22:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uQTJTNKkDlbCLDDKXRf++qDs0VZ1SBcgKS9o1XvOdT0=; b=bX3M0JB8Q+SuJ7xU/1Rjt/Gg4/vjmRvRqPOU3EOxljDR0ryQgWnxTkVnBqvSO93Ebg t8XyMWyrHuN1gNNqv47fULv39hNeTX7SSvrKUnlcmIMFAa5kYMMYdlq7epJlPFxRd/Zy 8BbXVEgOIy+bXslNWm9dq16UtWGmdFawpCcHeQCP8JG6crvWC6zzktRmeq+GjVIXVdVJ yL0x7daTuEFFy9LQBbpINPbCM8VWSXOCjOhyrHiLESU7cBVLXI/IflsB5Uw+YSXDvP4w juxc9k6LwXQIK7S/OLXR1WppBKmzmrxU3nLGUcVsXlZxIPwAXVwsapFYyGe2IB5SKg1o ytvw== X-Gm-Message-State: AOAM5322luK+/hfxyQ0lRwDIQzF4l0eTRjSRVWgaaaBZIGAXv+tQgChW xoCr37YTmCZMjU7Tx5E9X91BM03aSEUY6A== X-Google-Smtp-Source: ABdhPJzWcltOgqb/FpdNyYBvgBAhF/XpVWHDKNOqVDXjdPxiNEk4HfWFRZ6FFaQxNhwapxmmrHodYw== X-Received: by 2002:a17:906:7d91:: with SMTP id v17mr4281139ejo.522.1608301369788; Fri, 18 Dec 2020 06:22:49 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id op5sm5566452ejb.43.2020.12.18.06.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 06:22:48 -0800 (PST) Date: Fri, 18 Dec 2020 15:22:47 +0100 From: Krzysztof Kozlowski To: Marek Szyprowski Subject: Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type Message-ID: <20201218142247.GA2847@kozik-lap> References: <20201210212903.216728-1-krzk@kernel.org> <20201210212903.216728-9-krzk@kernel.org> <0f1509ef-9ae7-7a77-84b7-360b8f0071c7@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0f1509ef-9ae7-7a77-84b7-360b8f0071c7@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201218_092251_413054_9439B76B X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , Sylwester Nawrocki , linux-kernel@vger.kernel.org, Chanwoo Choi , Rob Herring , Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote: > On 10.12.2020 22:29, Krzysztof Kozlowski wrote: > > Interrupt line can be configured on different hardware in different way, > > even inverted. Therefore driver should not enforce specific trigger > > type - edge falling - but instead rely on Devicetree to configure it. > > > > The Samsung PMIC drivers are used only on Devicetree boards. > > > > Additionally, the PMIC datasheets describe the interrupt line as active > > low with a requirement of acknowledge from the CPU therefore the edge > > falling is not correct. > > > > Signed-off-by: Krzysztof Kozlowski > > Tested-by: Marek Szyprowski > > It looks that this together with DTS change fixes RTC alarm failure that > I've observed from time to time on TM2e board! Great! I'll add this to the commit msg. Thanks for testing. Best regards, Krzysztof > > > --- > > > > This patch should wait till DTS changes are merged, as it relies on > > proper Devicetree. > > --- _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel