From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8018EC4361B for ; Sat, 19 Dec 2020 11:07:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A2AE20867 for ; Sat, 19 Dec 2020 11:07:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A2AE20867 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cc+6HRcL7nUBA+tjn/DJSx/KLYf1Z3TlJxJh+kqPMLY=; b=DFnnAwAu73Dvxoiurujqm04pN RwgyCBw947x275O9qGiyE9nP0HcNyF6qj6qUjWFN2UHfhIVqqnSjJAbDSgLpIPD5Z1EtQaTSwG0aq SDx6KPHZOeIX7N3gojuJGIAe2nMCKDpIglrpEyuiWzTG/B8dNT2c75Frknl7xlFIywFKgHEJGbWvo AaNGqyFJGI1iZO1OxtgOMWBLrc8szJKc1g3R02gkfPeKIClNPWHTrrl906+xZYHFiLNeUNrAlDEei 8p8rgScBkJCosEuRDtNx2nvaZIBBchtIKZQNuBvF6saElf68zkfS1IpJGZ1zzSLsxU1sNPyDKp60n E59359Slg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqa3w-0005cw-O5; Sat, 19 Dec 2020 11:06:12 +0000 Received: from mail-ej1-f51.google.com ([209.85.218.51]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqa3t-0005cb-LC for linux-arm-kernel@lists.infradead.org; Sat, 19 Dec 2020 11:06:10 +0000 Received: by mail-ej1-f51.google.com with SMTP id jx16so6876326ejb.10 for ; Sat, 19 Dec 2020 03:06:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qNKpcAvCckFtSnR2woLhuVnvJHZHQ3Z8UruGn8Oav2o=; b=TJI53xDqjzjbAgyh039Eqah+nWfa4rnb2u3eyATln3NTiMNKlYRr8Og9JkTmSohA5O DMZLJX3pIuZUi7mMcXZCg4paMnjhHuGdCJ2LFz8zkvTetMcRiTH+rIbma8Zz7DkAtWjN lnFzliNLy0dWXUXDppBOkt1VTwMXAAEaNlYOZn0/et0zcB+tgpxYuhtGkZsEXnAnVK5X ZlIEPF4gkYwRK0b8qMwke8wbq8tAf9MjTd4WBJpfmj5jhJwAN0DIuQLHxCTanbb2JPE/ 7MjdG4U4Hux+h5Y3cflMi9zZqfnvZtKY4K/mVlsCPP81RTH5GEVfNIUB6KiJLeaf8OIT I7tA== X-Gm-Message-State: AOAM533wSPS/DC9JKhYrnfhhOV0f9xJYOYp0WQM2VSUvs+ctRPeAeKDq Qj2FcSA4hIykuYVgqnCUuS0= X-Google-Smtp-Source: ABdhPJzO9DNkFxh+zlxlbvHsEFM0VyzpmW79FhwTf3ogBtV+93P0q6SflgR8tQtTk1A7V51TjYNP0g== X-Received: by 2002:a17:907:4243:: with SMTP id np3mr7881715ejb.212.1608375966504; Sat, 19 Dec 2020 03:06:06 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id n22sm26169490edr.11.2020.12.19.03.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Dec 2020 03:06:05 -0800 (PST) Date: Sat, 19 Dec 2020 12:06:03 +0100 From: Krzysztof Kozlowski To: John Stultz Subject: Re: [PATCH v2 16/18] arm64: dts: hi3660: Harmonize DWC USB3 DT nodes name Message-ID: <20201219110603.GA8061@kozik-lap> References: <20201111091552.15593-1-Sergey.Semin@baikalelectronics.ru> <20201111091552.15593-17-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201219_060609_715277_70122F22 X-CRM114-Status: GOOD ( 26.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amit Pundir , Felipe Balbi , Florian Fainelli , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Greg Kroah-Hartman , lkml , Wei Xu , Serge Semin , Rob Herring , YongQin Liu , Serge Semin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 18, 2020 at 09:11:42PM -0800, John Stultz wrote: > On Wed, Nov 11, 2020 at 1:22 AM Serge Semin > wrote: > > > > In accordance with the DWC USB3 bindings the corresponding node > > name is suppose to comply with the Generic USB HCD DT schema, which > > requires the USB nodes to have the name acceptable by the regexp: > > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > > named. > > > > Signed-off-by: Serge Semin > > Acked-by: Krzysztof Kozlowski > > --- > > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > > index d25aac5e0bf8..aea3800029b5 100644 > > --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > > +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > > @@ -1166,7 +1166,7 @@ usb_phy: usb-phy { > > }; > > }; > > > > - dwc3: dwc3@ff100000 { > > + dwc3: usb@ff100000 { > > compatible = "snps,dwc3"; > > reg = <0x0 0xff100000 0x0 0x100000>; > > > Oof. So this patch is breaking the usb gadget functionality on HiKey960 w/ AOSP. > > In order to choose the right controller for gadget mode with AOSP, one > sets the "sys.usb.controller" property, which until now for HiKey960 > has been "ff100000.dwc3". > After this patch, the controller isn't found and we would have to > change userland to use "ff100000.usb", which would then break booting > on older kernels (testing various LTS releases on AOSP is one of the > key uses of the HiKey960). > > So while I understand the desire to unify the schema, as HiKey960 > really isn't likely to be used outside of AOSP, I wonder if reverting > this one change is in the best interest of not breaking existing > userland? The node names are not part of an ABI, are they? I expect only compatibles and properties to be stable. If user-space looks for something by name, it's a user-space's mistake. Not mentioning that you also look for specific address... Imagine remapping of addresses with ranges (for whatever reason) - AOSP also would be broken? Addresses are definitely not an ABI. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel