From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A8A2C4361B for ; Sat, 19 Dec 2020 12:19:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 092B523AC2 for ; Sat, 19 Dec 2020 12:19:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 092B523AC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9iMC1oO1ufZWQqj5SyeQhhAb0ip1nB4jkXulCJRyQeg=; b=imTmI8y4zzuGWjHHCbCmpRi5X 7XQ9esX8zp9GgdcsQMK1wazInmqf8eh02QqIRXcKvhZyRCONm1aGGUneox4aioA+6jBsuV/EKhyV5 3f+y/+p+DI0YMjNFC5hbHGRNNULRn7CW76mj/w4/H7IJ5319CfYLoRbnub1zQbgHxBluOUQFriqoY +kBdhVME2eNs9/TfF10ejS14d9rFNOYgaw4bQhuH7dC1yvyANDjsEWzO/cOxQeY1mbTDYuuI2HD2n KGmEbp5ts9u/r7zfXsQrdRwwzekv/RGHiZKkbfk155NyghDBCj7mDLblZm1tX6/3GZY2DvE07+UlZ K3CM5iPyw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqbC0-0000E0-D0; Sat, 19 Dec 2020 12:18:36 +0000 Received: from mail-ed1-f52.google.com ([209.85.208.52]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqbBx-0000DS-6h for linux-arm-kernel@lists.infradead.org; Sat, 19 Dec 2020 12:18:34 +0000 Received: by mail-ed1-f52.google.com with SMTP id b73so5039920edf.13 for ; Sat, 19 Dec 2020 04:18:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qi+cHJsutD0v/2D158E61pxGnRmCY1Auxgmi47GVOeE=; b=EOwzbjF5A6aHAjFm63S8w9ZrFGkGPVb9cKquNZlA3MviyHGroudtsqrj9UNEB5vXoG TZYRaI9ZfFJCiNEWWqxFdi4rwv6fMFrBkFZt1nofBKa6yPIimiCkWByCuvn1htzWHKB7 0exHy9UaUL0e7svkbPYRMOxIAy6GzssghaxM1GKJRfZ/geBQ4VQ/LncqA04Wgfqbk3N2 p025fJmhSXTdGyV3fT9FF9BHOJPAebfLEghe4p5Rb/CGYMJu7NuohRnmV9ueVvrkPEtj HrDMz+MpxlaO0O/5/e2hptKnBj/9Qohw8VvuiBAK5ymln2vK1O2Pjp1IL3b0AgzjuPMk 6ILQ== X-Gm-Message-State: AOAM53020CFcBULOqiHNQqVs+FVBCLyj2QfS9cMCRSR+Zwna7imh8hG9 b6MoXPH+1pSSnLRsW0l9SqA= X-Google-Smtp-Source: ABdhPJz3AF5UZHZA83wBIxOoi/qH0ktPREnG1PVUi4nAA1FyeEy8mQkPeLg7YijpfFupqZA6Pq/vAw== X-Received: by 2002:aa7:da8f:: with SMTP id q15mr8534914eds.239.1608380311889; Sat, 19 Dec 2020 04:18:31 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id d14sm28331645edn.31.2020.12.19.04.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Dec 2020 04:18:30 -0800 (PST) Date: Sat, 19 Dec 2020 13:18:29 +0100 From: Krzysztof Kozlowski To: "Alice Guo (OSS)" Subject: Re: [PATCH v8 4/4] soc: imx8m: change to use platform driver Message-ID: <20201219121829.GB13886@kozik-lap> References: <20201218083726.16427-1-alice.guo@oss.nxp.com> <20201218083726.16427-4-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201218083726.16427-4-alice.guo@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201219_071833_290237_1D255A24 X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 18, 2020 at 04:37:26PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Directly reading ocotp register depends on that bootloader enables ocotp > clk, which is not always effective, so change to use nvmem API. Using > nvmem API requires to support driver defer probe and thus change > soc-imx8m.c to use platform driver. > > The other reason is that directly reading ocotp register causes kexec > kernel hang because the 1st kernel running will disable unused clks > after kernel boots up, and then ocotp clk will be disabled even if > bootloader enables it. When kexec kernel, ocotp clk needs to be enabled > before reading ocotp registers, and nvmem API with platform driver > supported can accomplish this. > > Signed-off-by: Alice Guo > --- > Changes for v8: > - none > Changes for v7: > - solve the problem "drivers/soc/imx/soc-imx8m.c:174:34: warning: > unused variable" There was a reviewed-by part of changelog. The tag was in your commit. I am now confused, as changes for v8 say "none"... but shall I trust it? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel