From: Krzysztof Kozlowski <krzk@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: kernel@puri.sm, devicetree@vger.kernel.org, festevam@gmail.com,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description
Date: Sat, 19 Dec 2020 13:20:23 +0100 [thread overview]
Message-ID: <20201219122023.GC13886@kozik-lap> (raw)
In-Reply-To: <20201218103131.22013-3-martin.kepplinger@puri.sm>
On Fri, Dec 18, 2020 at 11:31:29AM +0100, Martin Kepplinger wrote:
> Add the pinctrl description for the interrupt.
Please describe why do you need to add it. From the patch contents I
easily see what you are doing. But neither the commit title nor the
message describe what you want to achieve (why are you doing it).
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-19 12:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 10:31 [PATCH 0/4] small Librem 5 phone dts updates Martin Kepplinger
2020-12-18 10:31 ` [PATCH 1/4] arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8 Martin Kepplinger
2020-12-18 10:31 ` [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description Martin Kepplinger
2020-12-19 12:20 ` Krzysztof Kozlowski [this message]
2020-12-18 10:31 ` [PATCH 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT Martin Kepplinger
2020-12-19 12:21 ` Krzysztof Kozlowski
2020-12-18 10:31 ` [PATCH 4/4] arm64: dts: imx8mq-librem5-r3: workaround i2c1 issue with 1GHz cpu voltage Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201219122023.GC13886@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).