From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D91C433E0 for ; Mon, 21 Dec 2020 14:08:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C97B722BEF for ; Mon, 21 Dec 2020 14:08:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C97B722BEF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B6GYbock65ghltpwN38wi5zQrlHPinW+MM93OYV0IYY=; b=RoKVE2k4BjZSj2CdBtGre+iz6 7pNCgqw3xPwgcMozznxtHIsIUeHvAFYEQFdBRHOMlysjLQG4cK4oLGZJvT9Wyak6MGK9HguxI7CHW Km1gzX5X2zeSwbjXHryMdyqbIu1GbATY6uCR1vrt+qLZ7p8VO+ZNIscIL589OHlxdMtIcng72vgpS G6vqpkjydfHGlhgelimAudrju+5C8BpoxEPUfLg/cYfccTQpjFzW+Ha3yaxCcmwJcJYzoac7EqtJk CJ6vbOoxIWg2IBkjTkoGnNAM3MAJkewAOoldzbncQmCdQ9GzYaYC92Tw++bVYq9lfCCxx4xe8l4Lt sf/ILQDbg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krLpo-0001rU-OC; Mon, 21 Dec 2020 14:06:48 +0000 Received: from mail-wr1-f51.google.com ([209.85.221.51]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krLpm-0001qr-DI for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 14:06:47 +0000 Received: by mail-wr1-f51.google.com with SMTP id y17so11169421wrr.10 for ; Mon, 21 Dec 2020 06:06:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xORP8jrGUXgQBvG+agQHXIF7BRNzLoX0I+Ry6aw/+W4=; b=YKS/g2crY2ZmomBFMz/PIpQWsJjEENmT93ZenwTeALgIHV3ij1bHoydHGdbsr0cqTu uM9m/lWkzxRhL8j9u++apioTVoZvi0TfFUuDiLuMEcvIdqdZb4ttaEviutmXGqsXaV0O 7Jz+Wz33ujHKbA6h4rWhcbo4JhGo6VBavV8GBaGhk1VpKazDXwzdGpB6IMxDaDy4eJZ7 I4rqBrzaH24D75E86eUPmmth/n2FVqUOFF6ooNwdjLiPR9O52pdnXrIOQxK83L7oB6Pe 9Rwt5b5Ce/o5zjjyGdEMW+eou2+Los19KLPU/evsoY6Y71z/arIy76RNsJY/XMYhfbNx SjLA== X-Gm-Message-State: AOAM532mjxOarV9pmWtW3c7J/s3ZO+nBvdQNRGnXRNF2z/sxqiApczQF k4bj0+5gYZCbGL48EWNYi9BGn39CUV88JQ== X-Google-Smtp-Source: ABdhPJzQ9DHU3zo/Mi/uVUbtutH0UYWGEA5VoYHXvwKIb7zUFlovYDlFOAB+6YohHI6P531FNnJlJQ== X-Received: by 2002:a5d:660b:: with SMTP id n11mr18853016wru.407.1608559605021; Mon, 21 Dec 2020 06:06:45 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id u9sm18596490wmb.32.2020.12.21.06.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 06:06:44 -0800 (PST) Date: Mon, 21 Dec 2020 15:06:42 +0100 From: Krzysztof Kozlowski To: Jagan Teki Subject: Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit Message-ID: <20201221140642.GF31176@kozik-lap> References: <20201221113151.94515-1-jagan@amarulasolutions.com> <20201221113151.94515-7-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201221113151.94515-7-jagan@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_090646_479809_47F6032C X-CRM114-Status: GOOD ( 22.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Matteo Lisi , Will Deacon , Shawn Guo , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Catalin Marinas , Fabio Estevam , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > Evaluation Board. > > Genaral features: > - LCD 7" C.Touch > - microSD slot > - Ethernet 1Gb > - Wifi/BT > - 2x LVDS Full HD interfaces > - 3x USB 2.0 > - 1x USB 3.0 > - HDMI Out > - Mini PCIe > - MIPI CSI > - 2x CAN > - Audio Out > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > Mainline Linux supported. > > Add support for it. > > Signed-off-by: Matteo Lisi > Signed-off-by: Jagan Teki > --- > Changes for v2: > - updated commit message > - dropped engicam from filename since it aligned with imx6 engicam > dts files naming conventions. > > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > 3 files changed, 29 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 8d49a2c74604..43783076f856 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > new file mode 100644 > index 000000000000..294df07289a2 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > @@ -0,0 +1,7 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2020 Engicam srl > + * Copyright (c) 2020 Amarula Solutions(India) > + */ > + > +#include "imx8mm-engicam-common.dtsi" It seems you ignored my comments from previous email. That's not how we go with the process. Don't create confusing or overcomplicated hierarchy of includes. Don't create files which do nothing. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel