Re: [PATCH 3/3] ARM: dts: exynos: Fix charging regulator voltage and current for i9100

Timon Bätz
2020-12-03T05:47:28Z

On Wednesday, December 2, 2020 11:04 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On Wed, Dec 02, 2020 at 09:07:28PM +0000, Timon Baetz wrote:
>
> > Set CHARGER current and CHARGER_CV voltage according to Galaxy S2 kernel
> > fork.
> >
> > Signed-off-by: Timon Baetz timon.baetz@protonmail.com
> >
> > ------------------------------------------------------
> >
> > arch/arm/boot/dts/exynos4210-i9100.dts | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> > diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts
> > index 9f8d927e0d21..2700d53ea01b 100644
> > --- a/arch/arm/boot/dts/exynos4210-i9100.dts
> > +++ b/arch/arm/boot/dts/exynos4210-i9100.dts
> > @@ -558,14 +558,14 @@ safe2_sreg: ESAFEOUT2 {
> >
> > charger_reg: CHARGER {
> > regulator-name = "CHARGER";
> >
> >
> > - regulator-min-microamp = <60000>;
> >
> >
> > - regulator-max-microamp = <2580000>;
> >
> >
> >
> > - regulator-min-microamp = <200000>;
> >
> >
> > - regulator-max-microamp = <950000>;
> > };
> >
> > chargercv_reg: CHARGER_CV {
> > regulator-name = "CHARGER_CV";
> >
> >
> >
> > - regulator-min-microvolt = <3800000>;
> >
> >
> > - regulator-max-microvolt = <4100000>;
> >
> >
> >
> > - regulator-min-microvolt = <4200000>;
> >
> >
> > - regulator-max-microvolt = <4200000>;
> >
> >
>
> I am looking at my sources of Android 3.0 for GT-I9100 but I cannot find
> charger voltages for it. Where did you find it?
>
> Best regards,
> Krzysztof

Thanks all the feedback Krzysztof,

Voltage is set in the charger probe function of the downstream kernel fork: https://github.com/LineageOS/android_kernel_samsung_smdk4412/blob/lineage-17.0/drivers/power/max8997_charger_u1.c#L390-L391

Mainline uses the regulator: https://github.com/torvalds/linux/blob/master/drivers/regulator/max8997-regulator.c#L418-L419