From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB17AC433E0 for ; Mon, 21 Dec 2020 14:24:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A08B522B3B for ; Mon, 21 Dec 2020 14:24:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A08B522B3B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LevkpZ4cvd+UzM5PtRzYwrjWPjtg3qd4rIex/P7ph10=; b=K92A5WiaPlJkBdvr9ytHSnkfB 4zb32pkLcGFMcoyvNLeLRNaqzhcqpK7b4EzHizwoyjvALuh04RgmxZYV7EYKKDuERTRPLeiBftz2A CioPtNxeFJA1F3l5KNvL9GaGvuH8zB6CpuTgNnPzI5BqbfGOliwnMZC9I0He2/K9bWHz2T/RAPY7p ukfwo38zChvo0VbU8lEstq8JbOSANjf794ukvcWnF5gfh4kMiErlDAFFLoV04TW9td0z0/8cPkaX5 c5ZsLhRDLoDct3bXj1kC3yXI7ZepBXnjIujo91PKM0R/tDOpk2B6DbJfCOKmv/ij6aAk2BsrihF7s uq7yjG+JA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krM5w-0003u2-Ks; Mon, 21 Dec 2020 14:23:28 +0000 Received: from mail-wm1-f45.google.com ([209.85.128.45]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krM5u-0003tP-65 for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 14:23:27 +0000 Received: by mail-wm1-f45.google.com with SMTP id q75so11118896wme.2 for ; Mon, 21 Dec 2020 06:23:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t92iU2s6tie/otzdcUrjmsNAfZxVxfg7pY63xjxoqR0=; b=cmYJ3Is4DKKSCtc1/BAlTVG8GY8Khu6e4ht/Fc69XXAlxyr8C34I/6q7vRjFCR1/4x 1zrq2OJy1qyKLQiqihPQiFW27h420pBIQYgcxgUErlHuwR9gBoWm6JtMXnB08YZqVzqu 3oY7ctn7j0NMQ4feQXeFAxPTbAcWNUp6B8naCrjXBQed6CGQ9CFv9kIHMubKeGEBxMUn WlFcclK13dhT6ycc5AxpS+nngvJoXjZL/ympNJN0uqgqVnu/rC9fJuNT0Qu6EghUmmsM T33xMs8m3AdZ+dnAshw2aoDI978Gvo/0xwQgSHSMU5JgMuxCBhukqQ0yswyS08JJjQCg ATgQ== X-Gm-Message-State: AOAM530SWtfkGcM5c40RntzvPAC9c6KICa80OLU6q5E0YjXQJwRfH299 /7oQvN/B0Td+jG0AeFEB4N9bnig/QOBtaA== X-Google-Smtp-Source: ABdhPJydHMJbjUHhJ6XejcwGmjRgE3+AwUk9spdEBcvmCbwYVI0W9dTUWUeG2jHzkMrCpRq4wEDJAQ== X-Received: by 2002:a1c:6144:: with SMTP id v65mr16759171wmb.125.1608560604690; Mon, 21 Dec 2020 06:23:24 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id h29sm29546011wrc.68.2020.12.21.06.23.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 06:23:23 -0800 (PST) Date: Mon, 21 Dec 2020 15:23:22 +0100 From: Krzysztof Kozlowski To: Timon Baetz Subject: Re: [PATCH v2 5/6] ARM: dts: exynos: Added top-off charging regulator node for i9100 Message-ID: <20201221142322.GE33797@kozik-lap> References: <20201202203516.43053-1-timon.baetz@protonmail.com> <20201221095001.595366-1-timon.baetz@protonmail.com> <20201221095001.595366-5-timon.baetz@protonmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201221095001.595366-5-timon.baetz@protonmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_092326_241187_F8A751F5 X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Liam Girdwood , Rob Herring , Sebastian Reichel , Chanwoo Choi , MyungJoo Ham , ~postmarketos/upstreaming@lists.sr.ht, Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 21, 2020 at 09:53:35AM +0000, Timon Baetz wrote: > Value taken from Galaxy S2 vendor kernel [0] which always sets 200mA. Subject: "Add", not "Added", as in Linux coding style. > > Also rearrange regulators based on definition in max8997.h. > > [0] https://github.com/krzk/linux-vendor-backup/blob/samsung/galaxy-s2-epic-4g-touch-sph-d710-exynos4210-dump/drivers/power/sec_battery_u1.c#L1525 > > Signed-off-by: Timon Baetz > --- > arch/arm/boot/dts/exynos4210-i9100.dts | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts > index 586d801af0b5..fec6da64f7c1 100644 > --- a/arch/arm/boot/dts/exynos4210-i9100.dts > +++ b/arch/arm/boot/dts/exynos4210-i9100.dts > @@ -560,6 +560,16 @@ safe2_sreg: ESAFEOUT2 { > regulator-boot-on; > }; > > + EN32KHZ_AP { > + regulator-name = "EN32KHZ_AP"; > + regulator-always-on; > + }; > + > + EN32KHZ_CP { > + regulator-name = "EN32KHZ_CP"; > + regulator-always-on; > + }; > + > charger_reg: CHARGER { > regulator-name = "CHARGER"; > regulator-min-microamp = <200000>; > @@ -573,13 +583,10 @@ chargercv_reg: CHARGER_CV { > regulator-always-on; > }; > > - EN32KHZ_AP { > - regulator-name = "EN32KHZ_AP"; > - regulator-always-on; > - }; > - > - EN32KHZ_CP { > - regulator-name = "EN32KHZ_CP"; > + chargertopoff_reg: CHARGER_TOPOFF { No need for label "chargertopoff_reg". Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel