From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7B0C433DB for ; Mon, 21 Dec 2020 18:48:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CC1023106 for ; Mon, 21 Dec 2020 18:48:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CC1023106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vw/I2gByc+QZ7vHe0vlOqVNw5dV+ok0UtEElu93x16U=; b=tZIwypCkpLjSU1fgKieafnfFJ JQd8b4mG4QEK/iiwu7O1EJv6wRMLr8d0n/RL44FF6b12MzxOLT2lGkORKxPd9F6znIthUFM3Pj73J rRk4N781b+vACYVxy04j+W/4QTmvayPqxbRxPI8avo7PFTz77zZ8f/92OdCzrIir1NbI5+k+bJ6PE V1zpJylUWAhXoNMzNSJ3ocueTjmiF5z3LtadbM3oCdOwPRsREtuaq5+bxvDuCBVp3iQ8Vqm4NfATx nQWP18+mP3Nf9tiL+QdJ718Ec8hKjC1LNxH99YX3qLrj+kpC9tthu4vDZOtuFfCXsC8Fojski9tPh jN1crXbfg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krQDC-0007NX-75; Mon, 21 Dec 2020 18:47:14 +0000 Received: from mail-oo1-f47.google.com ([209.85.161.47]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krQD9-0007Mf-C3 for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 18:47:12 +0000 Received: by mail-oo1-f47.google.com with SMTP id q6so2422211ooo.8 for ; Mon, 21 Dec 2020 10:47:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9c4Z1cR0okEDOva6ZJZicR2jBIUZ+5XrWMqkg7M3kpw=; b=kXyB2aFiMMuEl8b6n7LsQdSfP9FmMsMxxsbemosov/oSx28aW+lOtAf9xovVHtlz50 yXpW7RSVNbCVy5QpIZzdPEHlhY5lNNjeCyLo53HWkpb5h75Xupeg0MP0+A1d7JzHE3m0 t1xlQKyt78MxXIZ3JvLXWgWmM+0wTJHEJyBbJSQr5yNbVEopUQTxIP3nYWZky/t1/4xR /W5uxelwuK4diggEs7QRnAjiIwAcMj9W2FFDXIB73Y2Gdqi/Zjfzut22i+xQW8hcdu94 NQ5UA741OAEh+zl02gjNanmdV9kKH4lEQDcbBN1mFzCSJRvsSNELCmHhkQrqjlsBWPGX mwKw== X-Gm-Message-State: AOAM5305lv7eJ2+u8rB6Z52UcFs4QXoO5j5749Gk7CxfNZLeRXeBCW7M YDF/hRlU461Sf4qoLBDGqmGxC5JHqw== X-Google-Smtp-Source: ABdhPJxHtxtQavMpTMYOeQXfbwlNAzcd18hUq1nv29288DdMCrjnzy/vnMDlD21MGqurHNxrq5tuvg== X-Received: by 2002:a4a:8353:: with SMTP id q19mr7538448oog.40.1608576430556; Mon, 21 Dec 2020 10:47:10 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id t72sm3697688oie.47.2020.12.21.10.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 10:47:09 -0800 (PST) Received: (nullmailer pid 344465 invoked by uid 1000); Mon, 21 Dec 2020 18:47:07 -0000 Date: Mon, 21 Dec 2020 11:47:07 -0700 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [RFC 17/18] mfd: max14577: Do not enforce (incorrect) interrupt trigger type Message-ID: <20201221184707.GA344409@robh.at.kernel.org> References: <20201210212534.216197-1-krzk@kernel.org> <20201210212534.216197-17-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201210212534.216197-17-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_134711_452647_23BD8BB2 X-CRM114-Status: GOOD ( 18.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Liam Girdwood , Michael Turquette , Angus Ainslie , Sebastian Reichel , Iskren Chernev , Lee Jones , linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Matheus Castello , Chanwoo Choi , Andy Gross , devicetree@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-arm-msm@vger.kernel.org, Hans de Goede , Mark Brown , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , Stephen Boyd , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Sebastian Krzyszkowiak Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Dec 2020 22:25:33 +0100, Krzysztof Kozlowski wrote: > Interrupt line can be configured on different hardware in different way, > even inverted. Therefore driver should not enforce specific trigger > type - edge falling - but instead rely on Devicetree to configure it. > > The Maxim 14577/77836 datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU therefore the edge > falling is not correct. > > The interrupt line is shared between PMIC and charger driver, so using > level sensitive interrupt is here especially important to avoid races. > With an edge configuration in case if first PMIC signals interrupt > followed shortly after by the RTC, the interrupt might not be yet > cleared/acked thus the second one would not be noticed. > > Signed-off-by: Krzysztof Kozlowski > > --- > > This patch should wait till DTS changes are merged, as it relies on > proper Devicetree. > --- > Documentation/devicetree/bindings/mfd/max14577.txt | 4 ++-- > drivers/mfd/max14577.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel