From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B416C433E0 for ; Tue, 22 Dec 2020 08:55:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02E48221FA for ; Tue, 22 Dec 2020 08:55:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02E48221FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ky6Eo0kpiI+nkB40yRH3eBzB9qMRpytpwajWsHILIs4=; b=E9xMX8SJVe+edYnS1ciNAhovr ijaHJlbvnP/ybjZumizCqydgaKHs266yglNMU21Ml3YNvBWWX/uG42RlAX03m2JlmNOfkSTcNXCUT 3dJe2K2JeMTY01zrmnkmRIk+hrrOiEANXq1KJJLCuI2PNdJ57KEYLAVOz0dn5zOE2gxzWwzCuG7Hn +i1lvCaKCMsVDil1EXvrpd/ezmxaAdKHJQGgJk8aFch0xfVgBhuNVNj64hHPCEu/XXtjHq7ObkhIX oxXbDm2jgggos3UrPWB06rCSDrH5V6foTelGdnwvOgkoBi9k+LE71GOrem3b6ifsRZ88PkQ2e+l8d BhhaDzBXw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krdQK-0004z5-W5; Tue, 22 Dec 2020 08:53:41 +0000 Received: from mail-wm1-f45.google.com ([209.85.128.45]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krdQI-0004y1-6g for linux-arm-kernel@lists.infradead.org; Tue, 22 Dec 2020 08:53:39 +0000 Received: by mail-wm1-f45.google.com with SMTP id n16so1179698wmc.0 for ; Tue, 22 Dec 2020 00:53:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QtE5e6AYSIzZbtOwGMsWWC8Csg+80tvhfv7BAVQIge0=; b=qmk5LamrCqd8qg+EFWlNcfCtjVJFQEOe+JiIWvYjVyGXtYR3cUoL/Ko76wbms7XI3o HN9SIa7TsCr6Gpp0dg4CUx8BOJf1eX+nrSJ+RbJ0UyneLk8Uq+uDKWNgJ3k8PqpZC7dF G1ZorhIfFGuK1++BlFkd/SyeTTKFXMVFQqT8kCLBThr8n8FWZeB3WmbuVF2nBFs4lGql G0p3y1t0/feMQY2l8HAk0g9cPYfmo5oFqY3ROowo/K3kr7OpMMMk/rJd9sulpeJgleWi Dqz4K/ePFbBhOvoM+BS0HsuVhVJWZMAGD/81J5FfgwD9BuFrJ02CjFDJQHrsF+13QSav INTg== X-Gm-Message-State: AOAM531Kj/fsLr9M/RzDfSg900VCJlhqPWYWqAZCScPO/Sutcyrgn9v1 yN7dmrsWCYenwAiro8TxkmU= X-Google-Smtp-Source: ABdhPJxDmZ+hatd7pHWg3ft7wJ7iGB4B2ZASvd+18Obbp6kz5eMH5YAE0LxIclunGy8stz5FmbTwEg== X-Received: by 2002:a7b:c8cd:: with SMTP id f13mr19979547wml.56.1608627213429; Tue, 22 Dec 2020 00:53:33 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id m5sm19686723wrz.18.2020.12.22.00.53.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Dec 2020 00:53:32 -0800 (PST) Date: Tue, 22 Dec 2020 09:53:30 +0100 From: Krzysztof Kozlowski To: Jagan Teki Subject: Re: [PATCH v2 6/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini EDIMM2.2 Starter Kit Message-ID: <20201222085330.GA15568@kozik-lap> References: <20201221113151.94515-1-jagan@amarulasolutions.com> <20201221113151.94515-7-jagan@amarulasolutions.com> <20201221140642.GF31176@kozik-lap> <20201221210601.GB2504@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201222_035338_278688_CB009B15 X-CRM114-Status: GOOD ( 31.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Matteo Lisi , Will Deacon , Shawn Guo , linux-kernel , Li Yang , Rob Herring , NXP Linux Team , Catalin Marinas , Fabio Estevam , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 22, 2020 at 02:20:55PM +0530, Jagan Teki wrote: > On Tue, Dec 22, 2020 at 2:36 AM Krzysztof Kozlowski wrote: > > > > On Tue, Dec 22, 2020 at 01:03:07AM +0530, Jagan Teki wrote: > > > On Mon, Dec 21, 2020 at 7:36 PM Krzysztof Kozlowski wrote: > > > > > > > > On Mon, Dec 21, 2020 at 05:01:51PM +0530, Jagan Teki wrote: > > > > > Engicam EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive > > > > > Evaluation Board. > > > > > > > > > > Genaral features: > > > > > - LCD 7" C.Touch > > > > > - microSD slot > > > > > - Ethernet 1Gb > > > > > - Wifi/BT > > > > > - 2x LVDS Full HD interfaces > > > > > - 3x USB 2.0 > > > > > - 1x USB 3.0 > > > > > - HDMI Out > > > > > - Mini PCIe > > > > > - MIPI CSI > > > > > - 2x CAN > > > > > - Audio Out > > > > > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > > > > > > > i.Core MX8M Mini needs to mount on top of this Evaluation board for > > > > > creating complete i.Core MX8M Mini EDIMM2.2 Starter Kit. > > > > > > > > > > PCIe, DSI, CSI nodes will add it into imx8mm-engicam-edimm2.2.dtsi once > > > > > Mainline Linux supported. > > > > > > > > > > Add support for it. > > > > > > > > > > Signed-off-by: Matteo Lisi > > > > > Signed-off-by: Jagan Teki > > > > > --- > > > > > Changes for v2: > > > > > - updated commit message > > > > > - dropped engicam from filename since it aligned with imx6 engicam > > > > > dts files naming conventions. > > > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > > > .../freescale/imx8mm-engicam-edimm2.2.dtsi | 7 +++++++ > > > > > .../freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 21 +++++++++++++++++++ > > > > > 3 files changed, 29 insertions(+) > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > > > index 8d49a2c74604..43783076f856 100644 > > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > > @@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > > new file mode 100644 > > > > > index 000000000000..294df07289a2 > > > > > --- /dev/null > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-edimm2.2.dtsi > > > > > @@ -0,0 +1,7 @@ > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > > +/* > > > > > + * Copyright (c) 2020 Engicam srl > > > > > + * Copyright (c) 2020 Amarula Solutions(India) > > > > > + */ > > > > > + > > > > > +#include "imx8mm-engicam-common.dtsi" > > > > > > > > It seems you ignored my comments from previous email. That's not how we > > > > go with the process. > > > > > > > > Don't create confusing or overcomplicated hierarchy of includes. Don't > > > > create files which do nothing. > > > > > > Idea is to move common nodes in separate dtsi instead of adding > > > redundant nodes into respective areas. let me know if it still > > > confusing. > > > > A file which *only* includes another file does not fulfill this idea of > > moving common nodes to a separate DTSI file. Or if I still miss > > something, please point me, what common nodes are stored in > > imx8mm-engicam-edimm2.2.dtsi? > > imx8mm-engicam-edimm2.2.dtsi for EDIMM2.2 Carrier > imx8mm-engicam-ctouch2.dtsi for C.TOUCH2 Carrier > imx8mm-engicam-common.dtsi for common nodes for above 2 carrier boards. > > Yes, imx8mm-engicam-edimm2.2.dtsi is empty now Then that's the answer. We do not create empty files. > but nodes like PCIe, > CSI, DSI will support once the respective drivers are part of Mainline > but those are not supported in C.TOUCH2 carrier board dtsi. There are > some GPIO pins differences between EDIMM2.2 and C.TOUCH2 carriers on > WiFi/BT so those will be part of the respective carrier dtsi. It's the same clear as before. Don't create empty files. Once you decide to bring new features, you create a new file. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel