From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61662C433E0 for ; Wed, 23 Dec 2020 08:07:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BF0F207AA for ; Wed, 23 Dec 2020 08:07:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BF0F207AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H/nOtZsYeRa8G5NUiZtkVeVlIvaDSKnpik9xD/aLwuM=; b=pKNmKGObwWqm8XRB8LGyyLXzw rMgyj7eIgKuCwC3Hgr4NnNnNmlMdorXKlj3WEdQGduf05maDTwziE4a8Zy46NPKgqHJcNm3iAvDDl uJ1M6YOms4fBgvALAcjLTN4usXSeMrSk5UL6p/srd2Ea5OqasfiRxIdiPas3SFl8wI/fDY9V438se 96kQ5S9edcC4qxGvOKQMT5YcPQQ1prAKD27PMir49Rpur8p6PAoXNH5SB5vQvMHFklI6jlCyI6M3R ZXQg/wxK22Ak32v9AZcBMCLXZhI7dWVb+6mydO2z3Bt+0EMez3GaephqHoxbs6O2+sSzJqIUKBqd1 rzQ4HgYPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krz9U-0006Fr-La; Wed, 23 Dec 2020 08:05:44 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krz9R-0006F6-QZ for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2020 08:05:43 +0000 Received: by mail-pj1-x102b.google.com with SMTP id b5so2781820pjk.2 for ; Wed, 23 Dec 2020 00:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dFC4J3CXnrNqrkzDB7gTpiPIdHRvl+pO7Kvb2+g6hPU=; b=y8iB5eTxxElOlN4U05+HPq6VAmFYp5xXRIJcOeOnQTUIDTmTPXL1O0iKO58UdoFhMY TlfuxSIOZTFp4GIThvSNKT9P9YxuybgusN7NpN8U16VkTPRKVBvWofYcR0ou3RM5N/uh aEHGUb7l8lihOPYWWTUKVvSoXSvO9ickWFgLOkb7Ctspkcq08yqnOUPaD/n/4QlT2ME0 lfOZEgFa0erFa0QJdREj00KiJ8pg7SCZY7AhBsWwF9icVMuz8KysWCzxWW4HhCLhyu78 O7j52Colv6N2o0bYf5x9IJtwSogfL9dFUhABLIRyxFDS+aHEh7dW43blA91r3Y0682Hk tn9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dFC4J3CXnrNqrkzDB7gTpiPIdHRvl+pO7Kvb2+g6hPU=; b=cw/s+8SYU+RFwswqC8pX6gs6XCe1yBVXIiHoshrPyY+XZXqYMTRCSyT/7C4Dg9f320 8Kzz5taBoGizBu5CpQNU3m+UDeaJpSH2SXG094YDL7u6L5fHLHciALYLeeV2nIFW5tYP KvKbJK+2o1mFg88XmgvWes8hV2uYx2/eyLN6XxVi8i6AGqGtCY2yZPVdlQgbbF05CIz3 utz+4dV0r5FNvv6LH97PAodWbxaC6PGl/uPfUCd7BTAFmjoU1vlu+ORJIaEh1IYLz5Jz cWyEPioPUBqVNy7+IyGkGuFJ8e7hLvn8CAkY8NVmnejZe+9MdX8xYeaqguAJH+nHFGF+ Z4hg== X-Gm-Message-State: AOAM533rn1B9e8I9d+CoAniUSTR1EHFUAB3wYjEsCqeOpZlN6lLnEXhR mt4t042Jec7Yu3APmcAhRvHtvOFAf9gHi8lI X-Google-Smtp-Source: ABdhPJxloBm9jMvMcrrx9ZeCOoz9IXXT76CXaim0RPZg4wroSj7dQaH/jdLevVvjbupU3USpLRGbPA== X-Received: by 2002:a17:902:e9c5:b029:db:d1ae:46ba with SMTP id 5-20020a170902e9c5b02900dbd1ae46bamr24842540plk.38.1608710738806; Wed, 23 Dec 2020 00:05:38 -0800 (PST) Received: from leoy-ThinkPad-X240s ([38.94.108.168]) by smtp.gmail.com with ESMTPSA id g16sm21542904pfh.187.2020.12.23.00.05.35 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Dec 2020 00:05:37 -0800 (PST) Date: Wed, 23 Dec 2020 16:05:33 +0800 From: Leo Yan To: Denis Nikitin Subject: Re: [PATCH 3/3] rfc: perf: cs_etm: Detect pid in VMID for kernel running at EL2 Message-ID: <20201223080532.GA26191@leoy-ThinkPad-X240s> References: <20201110183313.1823760-1-suzuki.poulose@arm.com> <20201110183313.1823760-4-suzuki.poulose@arm.com> <20201113001105.GA22708@leoy-ThinkPad-X240s> <7e45fd42-0869-cd4f-1eaf-5d48e4464482@arm.com> <20201116094634.GA31795@leoy-ThinkPad-X240s> <0E201888-C3D2-4B9E-A3D5-9F1F62AB2D55@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201223_030542_165062_122A1182 X-CRM114-Status: GOOD ( 23.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: al.grant@arm.com, Anshuman Khandual , "coresight@lists.linaro.org" , Suzuki Poulose , "mike.leach@linaro.org" , "linux-arm-kernel@lists.infradead.org" , Daniel Kiss Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Denis, On Tue, Dec 22, 2020 at 01:57:41AM -0800, Denis Nikitin wrote: [...] > > > Below is the drafted patch for support PID format in the metadata and > > > I tested for "perf record" and "perf script" command and can work as > > > expected. > > > > > > P.s. I uploaded the patches into the github [1] and gave some minor > > > refactoring for your last patch "perf cs-etm: Detect pid in VMID for > > > kernel running at EL2". > > > I have tested the patches on Chrome OS EL2 kernel and they worked fine for > me. Thanks a lot for the testing! > Note that "perf cs-etm: Add PID format into metadata" patch breaks perf > backward compatibility. It may cause a problem in off-target decoding if > there is a version skew in perf. > I saw a discussion about perf compatibility in > https://lists.linaro.org/pipermail/coresight/2020-November/005326.html. > I understand that perf doesn't guarantee backward compatibility but in fact > incompatibility issues occur rarely. I think if there is an (easy) way to > do it the compatibility breakage should be avoided. Agreed. After reading the code and I think it's possible to do an extra checking the length of auxtrace info structure so that can know if the item CS_ETMV4_PID_FMT is valid or not. Thus we needs to write a parity function of intel_pt_has() for perf cs-etm; I will try to rework this patch. > This is a critical fix for Chrome OS. Please let me know what you think. So are you asking to upstream the changes to mainline kernel? You could see this patch is owned by Suzuki and I only proposed for one patch for perf related change. Suzuki, could you give some update for the plan of this patch set? I can help to prepare the perf patch based on Suzuki's plan. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel