From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEBB0C433E0 for ; Wed, 23 Dec 2020 08:28:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F72220C56 for ; Wed, 23 Dec 2020 08:28:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F72220C56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A7XLzD0ue9y91Y1Jr//t4CQLUoUo/AUcZEvI1Uvo+DY=; b=F/dzrjU0og4n7hxaDioObeuBf aCN+wEzt+BGvjD77GtWmPCVUYmirDGCRGZmLesWIjcpVKVJOSWtjR6/2p7v0PgDnbFRM/tD7W9vd8 e3IzTeL4y5nENqIXrLjgOfOBXAYUt1J0hCNFZcDmCdKhshARKxwZ3aIvl2SeqgJVBgCGTYaJWJYSM EZTRV4Peto38VDIXfrwhBbwiRjOjxwxDxOfN9MIlInGJv2UmDz62DMalUw7txeUseCFXYj5FHy8sY NMh63CxjiP3QKy5GbgMdJOE1cXydL+dFpdvc+PD2nhtomOkC16TJufXd13ub9Kj97/mxHWaQbgrGS gG55/B1EQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krzUY-0003kL-EL; Wed, 23 Dec 2020 08:27:30 +0000 Received: from mail-wr1-f44.google.com ([209.85.221.44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krzUU-0003hq-I9 for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2020 08:27:27 +0000 Received: by mail-wr1-f44.google.com with SMTP id r7so17746618wrc.5 for ; Wed, 23 Dec 2020 00:27:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mUVBf1H4BZsLh5EiHS+l8aTe/qKRYRM0fwXYQnOuMno=; b=tjD5WzH1fI17s2WKDB5b9BIItZxujuTkWMrtqeNVUs9totWGHTzplsxxW3Ife34Mgf uTDTYZNnD7zzlu1j40ted4p9p602VXyyYlGspiqTeqVLJmRIW1NdaCiT4u7LW6XzTC2a 0BwXyUn/xCiWXdtzsWo1D+4K1vvTr05Hwdt7lfwQ8m4RASj/GFm2YWgxqeUPuYcvNf/p dyrDM2y44np9uUcOqSbuDQ0mOrfJ59rGvYpwewqlkl4DWFbwLqBSwFjrkJEUj1iddYgQ bYrddzn0qq1ytgbNMrVIaUmN2u7PYHNGFF5OEZ+CPt10KPDjlnCQCfc5gkrOIewVoaRw 9Qpg== X-Gm-Message-State: AOAM531DtKNt2nHnNjyxVJYo5wOVTNVOy9nKhF/PvH9jiwUnRmuPaeQ3 Xh6u4OSYUa0ubcwnv+yWNrA= X-Google-Smtp-Source: ABdhPJz5X6Cf0bT7wSFl1EyCVBJePEFERj0lAztwVNT4Nv4+gegPgh9sxDuQYcJ9POAVur3wpM3Ldw== X-Received: by 2002:a5d:684b:: with SMTP id o11mr28315130wrw.157.1608712041535; Wed, 23 Dec 2020 00:27:21 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id c81sm31699679wmd.6.2020.12.23.00.27.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Dec 2020 00:27:20 -0800 (PST) Date: Wed, 23 Dec 2020 09:27:18 +0100 From: Krzysztof Kozlowski To: Timon Baetz Subject: Re: [PATCH v3 4/7] power: supply: max8997_charger: Set CHARGER current limit Message-ID: <20201223082718.GA5472@kozik-lap> References: <20201222070520.710096-1-timon.baetz@protonmail.com> <20201222070520.710096-4-timon.baetz@protonmail.com> <20201222084004.GD5026@kozik-lap> <20201223090114.750664cd.timon.baetz@protonmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201223090114.750664cd.timon.baetz@protonmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201223_032726_646688_97E673C0 X-CRM114-Status: GOOD ( 18.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Liam Girdwood , Rob Herring , Sebastian Reichel , Chanwoo Choi , MyungJoo Ham , ~postmarketos/upstreaming@lists.sr.ht, Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 23, 2020 at 08:09:55AM +0000, Timon Baetz wrote: > On Tue, 22 Dec 2020 09:40:04 +0100, Krzysztof Kozlowski wrote: (...) > > > .name = "max8997_pmic", > > > .type = POWER_SUPPLY_TYPE_BATTERY, > > > @@ -170,6 +237,33 @@ static int max8997_battery_probe(struct platform_device *pdev) > > > return PTR_ERR(charger->battery); > > > } > > > > > > + charger->reg = devm_regulator_get(&pdev->dev, "charger"); > > > > The code looks good but isn't it breaking all existing platforms? > > So there is 2 other DTS in the kernel sources that are using MAX8997 > pmic: > - Insignal Origen evaluation board > - Samsung Trats > Non of them have charging regulators. But still the power supply was probing on them (if not the error you mentioned). Now, the charger will fail. > Also probing of the charger has been failing for long time because of > https://lore.kernel.org/lkml/20201109194251.562203-2-timon.baetz@protonmail.com/ > but that seems to land in 5.11. That's a good argument supporting introduced breakage. Use it in commit message. Don't hide such information. > That being said, I guess I could make extcon and charger-supply > optional if you prefer. Since at least two boards will loose now power supply, I don't think you have a choice. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel