From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA19AC433E0 for ; Sat, 26 Dec 2020 12:19:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 815A0221E2 for ; Sat, 26 Dec 2020 12:19:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 815A0221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8QCzsu+K2VF36RN6AHLjNwcyX/bNjomB7u/CPfnj11Q=; b=jE0Fw2Qajs4dC/5xPw2uxYh6X CXnc9UXn74u4M+bbKQuYgCAOiXfUYqLf5h1+x8ZrlZ2Yvs8DrMaSBjkln9WA+irogm8yZnXivb7KN NRT2qjw6guHsdzVettlqrkgPaVgH/NRXPP+OsTl4KacIKqJCb+cRpJbom4qc3SIrwTFFNb7ZqqHui pFljXxnRq85Y7hZDG0NNDyXmvYkmCTrGYiH5K2b1xkYfhrPCKxeb0I7Q7unTliwKAhlmUduWtJ1CN pJrFDsJSDPvGN/8VXsgQsma8YtPAYNz+wjmhOS/vuvx1+inq9e36LbMb5cVjcmUbidOR7J7Qmuo4A kqfQVXJWQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kt8WC-0005CE-Jj; Sat, 26 Dec 2020 12:17:56 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kt8W9-00054c-Rf for linux-arm-kernel@lists.infradead.org; Sat, 26 Dec 2020 12:17:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QsnqwKrC8FAcmq1cPPiwc8IugCbcu9GsR0MUxmjHSGc=; b=GdsHm/xW8/6Or4SUsT5v5JOxj y7i8GCvXKGSuURt+XikaaV1zLN6oO4DvubALaS+xnIKWi2LuyhDOxXLqlyMYaTrLPxEznYRE5/ooL vq7xoTAJZQ7wKj2VMvjH+IZcACEtLvuA2rdEqQNSvC2jl4ZAfx/eC0dHhfU42B+Km3S6N1dr1QExp brh+rTrjA1girapFm+olYCAGamIYoVmWDSTkilFheGxBFLymjF5MtsH6HMnk/WQdWvvyvP1mlvUzO PucnDRtpwP+WpWQvBdOM0ZFxw2kPvfywCDh5AEOlql89M2VSSe2mrjAgxoiEAE4aOBBJZaF0lT65W D/66iXr3A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44538) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kt8U8-0003R4-71; Sat, 26 Dec 2020 12:15:48 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kt8U7-0006pi-Mc; Sat, 26 Dec 2020 12:15:47 +0000 Date: Sat, 26 Dec 2020 12:15:47 +0000 From: Russell King - ARM Linux admin To: "Leizhen (ThunderTown)" Subject: Re: [PATCH 1/1] ARM: LPAE: use phys_addr_t instead of unsigned long in outercache hooks Message-ID: <20201226121547.GC1551@shell.armlinux.org.uk> References: <20201225114458.1334-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201226_071753_942690_F0972278 X-CRM114-Status: GOOD ( 18.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Cooper , Arnd Bergmann , Greg Kroah-Hartman , Will Deacon , linux-kernel , Haojian Zhuang , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Dec 26, 2020 at 10:18:08AM +0800, Leizhen (ThunderTown) wrote: > On 2020/12/25 19:44, Zhen Lei wrote: > > The outercache of some Hisilicon SOCs support physical addresses wider > > than 32-bits. The unsigned long datatype is not sufficient for mapping > > physical addresses >= 4GB. The commit ad6b9c9d78b9 ("ARM: 6671/1: LPAE: > > use phys_addr_t instead of unsigned long in outercache functions") has > > already modified the outercache functions. But the parameters of the > > outercache hooks are not changed. This patch use phys_addr_t instead of > > unsigned long in outercache hooks: inv_range, clean_range, flush_range. > > > > To ensure the outercache that does not support LPAE works properly, do > > cast phys_addr_t to unsigned long by adding a middle-tier function. > > This patch will impact the outercache drivers that have not been merged into > the kernel. They should also update the datatype of the outercache hooks. This isn't much of a concern to mainline. If it's that big a problem for you, then please consider merging your code into mainline so that everyone can benefit from it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel