From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Michael Walle <michael@walle.cc>
Cc: Matus Ujhelyi <ujhelyi.m@gmail.com>,
acmattheis@gmx.net,
Christoph Mattheis <christoph.mattheis@arcor.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: Broken ethernet on SolidRun cubox-i
Date: Sat, 26 Dec 2020 12:34:21 +0000 [thread overview]
Message-ID: <20201226123421.GD1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <2ae000163aa34b963dd387c824bdc3c9@walle.cc>
On Sat, Dec 26, 2020 at 01:18:01PM +0100, Michael Walle wrote:
> Thus I suspect your commit 86b08bd5b994 ("ARM: dts: imx6-sr-som: add
> ethernet PHY configuration") to be the culprit ;) This will pin the
> PHY to address 0. I don't know how it was done before; like was there
> autoprobing if there is no "phy-handle" or did the bootloader fix that
> inplace. I don't have any cubox-i.
There is the need to move the AT803x quirk handling into DT rather than
using the PHY quirk system - the problem is, the PHY quirk system
applies the quirks to every iMX6 platform out there, whether the quirk
is right or wrong for that board.
I'd forgotten that there were boards out there with this problem...
the PHY address configuration is done via the LED_ACT pin, and SolidRun
omitted a pull resistor on it, so it "floats" with the leakage current
of the LED/pin - resulting in it sometimes appearing at address 0 and
sometimes at address 4.
I suppose there's no option but to revert the commit - but it needs to
be properly documented /why/ that is the case, and comments added to
ar8035_phy_fixup() in arch/arm/mach-imx/mach-imx6q.c to say why that
quirk can't be removed.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-26 12:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 12:18 Broken ethernet on SolidRun cubox-i Michael Walle
2020-12-26 12:34 ` Russell King - ARM Linux admin [this message]
2020-12-27 15:33 ` Michael Walle
2020-12-27 15:59 ` Michael Walle
2020-12-27 16:11 ` Russell King - ARM Linux admin
2020-12-27 18:07 ` Andrew Lunn
2021-01-08 11:53 ` Russell King - ARM Linux admin
2021-01-08 11:58 ` Michael Walle
2021-01-08 12:01 ` Russell King - ARM Linux admin
2021-01-08 12:14 ` Michael Walle
2021-01-08 12:25 ` Christoph Mattheis
2021-01-08 12:27 ` Russell King - ARM Linux admin
2021-01-08 12:33 ` Christoph Mattheis
2021-01-08 12:37 ` Russell King - ARM Linux admin
2021-01-08 12:51 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201226123421.GD1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=acmattheis@gmx.net \
--cc=christoph.mattheis@arcor.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=michael@walle.cc \
--cc=ujhelyi.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).