From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79FF7C433DB for ; Mon, 28 Dec 2020 02:42:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25D0C20796 for ; Mon, 28 Dec 2020 02:42:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25D0C20796 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=axis.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Date:Message-ID:MIME-Version:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=gZ2EVaZDzM5AhJfzOiouyf/AJ8zSckdkk79sbpp0PNs=; b=VrpKnjSH0Ts30nsYELpXLikYRQ 1ELTEarVrGGjwIjcBLLcmrGdMcDdk/lXJPhXlZcLnuiL0QFXt6SYrXEprWpcr9VIRInoZbUciWXNj rnGXS1L5BF5NLrvkxsJgFfg7xJLB0j+PzBr6xQ/fBiXxQgEuu7YUf8FMDzQ1f5mD2E2mrxLdksMPW kW80xoG+8D/20tFt4B/kqZoGyXdV3fNq8CtEvyaTTS6KMZsO5Q2iDAIGs/a3bs4Y7CxslazE+J+F4 s2IHVWBGUI+LDNm+HcpBSfoHPF132JxG4JxNPC3zkkdtj9yapwT0P2ScaOp9/jS4eSOzIuJIgK3YQ epqN3vrQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktiRo-00059Y-Fh; Mon, 28 Dec 2020 02:39:48 +0000 Received: from smtp2.axis.com ([195.60.68.18]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktiRl-00058R-T2 for linux-arm-kernel@lists.infradead.org; Mon, 28 Dec 2020 02:39:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1609123186; x=1640659186; h=from:to:cc:subject:mime-version: content-transfer-encoding:message-id:date; bh=V2SBeunGq+h3UtsNHb+tqmxZ59PpV2K+y2jJcGaooWM=; b=bDDpuGJNeMqB8Exz7zwJFObx/CnOtZPFbHWTukUoc1WbRByb+RCrkXu8 90c2Z9d5Y0QOaDlJ6NPTpwcSvwUy4Q965o9YRj9Y5ra7qq6Gchaan2QVE aUqShWIn8Uc8rb/soN2KQzCs1gB7VYb6NbIicDJe5wv2my9R07A7ZMToW fwmyw/I5mlcOvOVHFwJnd473FKdtJz6/x6yob0PrqmsfapuAwDEf1sryl Fbx6evdNrGdscyGTfrt75Dx/msEKASt6T0V7MMiXYGKmmdQwJ20ukzFK7 fu/NjyEt1cpUEUHBZPrh/pXwhYmcNZGv3Z2ZoDzaUgoI/z1c42pNo/sSK A==; From: Hans-Peter Nilsson To: , Subject: [PATCH] perf arm64: Fix mksyscalltbl, don't lose syscalls due to sort -nu MIME-Version: 1.0 Message-ID: <20201228023941.E0DE2203B5@pchp3.se.axis.com> Date: Mon, 28 Dec 2020 03:39:41 +0100 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201227_213946_247483_7D330F5F X-CRM114-Status: GOOD ( 10.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kim Phillips , Mathieu Poirier , Peter Zijlstra , Jiri Olsa , John Garry , Arnaldo Carvalho de Melo , Alexander Shishkin , Ingo Molnar , Leo Yan , Namhyung Kim , Will Deacon Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When using "sort -nu", arm64 syscalls were lost. That is, the io_setup syscall (number 0) and all but one (typically ftruncate; 64) of the syscalls that are defined symbolically (like "#define __NR_ftruncate __NR3264_ftruncate") at the point where "sort" is applied. This creation-of-syscalls.c-scheme is, judging from comments, copy-pasted from powerpc, and worked there because at the time, its tools/arch/powerpc/include/uapi/asm/unistd.h had *literals*, like "#define __NR_ftruncate 93". With sort being numeric and the non-numeric key effectively evaluating to 0, the sort option "-u" means these "duplicates" are removed. There's no need to remove syscall lines with duplicate numbers for arm64 because there are none, so let's fix that by just losing the "-u". Having the table numerically sorted on syscall-number for the rest of the syscalls looks nice, so keep the "-n". Signed-off-by: Hans-Peter Nilsson Cc: John Garry Cc: Will Deacon Cc: Mathieu Poirier Cc: Leo Yan Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Kim Phillips --- tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl index 459469b7222c..a7ca48d1e37b 100755 --- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl +++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl @@ -58,5 +58,5 @@ create_table() $gcc -E -dM -x c -I $incpath/include/uapi $input \ |sed -ne 's/^#define __NR_//p' \ - |sort -t' ' -k2 -nu \ + |sort -t' ' -k2 -n \ |create_table -- 2.11.0 brgds, H-P _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel