From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Alexander Dahl <post@lespocky.de>
Cc: devicetree@vger.kernel.org, Alexander Dahl <ada@thorsis.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-leds@vger.kernel.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v9 2/4] ARM: dts: berlin: Fix schema warnings for pwm-leds
Date: Tue, 29 Dec 2020 10:24:45 +0800 [thread overview]
Message-ID: <20201229102445.22c8587f@xhacker.debian> (raw)
In-Reply-To: <20201228163217.32520-3-post@lespocky.de>
On Mon, 28 Dec 2020 17:32:15 +0100
Alexander Dahl <post@lespocky.de> wrote:
>
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
> CHECK arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml: leds: 'red', 'white' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
Thanks for the patch.
I took this patch but sent out the PR late: https://www.spinics.net/lists/arm-kernel/msg862567.html
I will send out PR earlier for 5.12
> ---
>
> Notes:
> v8 -> v9:
> * rebased on v5.11-rc1
>
> v7 -> v8:
> * rebased on recent pavel/for-next (post v5.10-rc1)
>
> v6 -> v7:
> * split up patch (one per sub arch)
> * added actual warnings to commit message
>
> arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
> index 56fa951bc86f..c1d91424e658 100644
> --- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
> +++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
> @@ -34,19 +34,19 @@
> linux,usable-memory = <0x00000000 0x20000000>; /* 512 MB */
> };
>
> - leds {
> + led-controller {
> compatible = "pwm-leds";
> pinctrl-0 = <&ledpwm_pmux>;
> pinctrl-names = "default";
>
> - white {
> + led-1 {
> label = "white";
> pwms = <&pwm 0 600000 0>;
> max-brightness = <255>;
> linux,default-trigger = "default-on";
> };
>
> - red {
> + led-2 {
> label = "red";
> pwms = <&pwm 1 600000 0>;
> max-brightness = <255>;
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-29 2:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 16:32 [PATCH v9 0/4] leds: pwm: Make automatic labels work Alexander Dahl
2020-12-28 16:32 ` [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
2020-12-30 18:54 ` Pavel Machek
2020-12-31 8:33 ` Lee Jones
2020-12-31 9:39 ` Pavel Machek
2020-12-31 12:18 ` Lee Jones
2021-01-14 10:03 ` Lee Jones
2021-01-15 3:50 ` Jeff LaBundy
2021-01-15 9:42 ` Alexander Dahl
2021-01-18 4:02 ` Jeff LaBundy
2020-12-28 16:32 ` [PATCH v9 2/4] ARM: dts: berlin: " Alexander Dahl
2020-12-29 2:24 ` Jisheng Zhang [this message]
2020-12-28 16:32 ` [PATCH v9 3/4] ARM: dts: stm32: " Alexander Dahl
2021-01-14 16:07 ` Alexandre TORGUE
2020-12-28 16:32 ` [PATCH v9 4/4] arm64: dts: meson: " Alexander Dahl
2021-01-04 16:13 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229102445.22c8587f@xhacker.debian \
--to=jisheng.zhang@synaptics.com \
--cc=ada@thorsis.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=post@lespocky.de \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).