From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67816C433DB for ; Tue, 29 Dec 2020 16:13:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A68020771 for ; Tue, 29 Dec 2020 16:13:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A68020771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+NTuX4vk2v4ZOfF3gu1+SIUGIGlCwgXJuqAfM6bu2kw=; b=SgqmIgAFCzJPzvgbFx2OGvphY owPm6VuveAaWHyNaX76jOQlJKkImDG1Ry1HFbuqDUTP6wh7wHPrtwY3vDpW4h6zCv6ESSEgSoUT7B SnM61ePXASJBam57ac1iXDaZ2qO7gMzgK3Y3/ZmVmf3ZngKHvt6gfzlCAi+JWpT6k2stCrDgLJMRq Vcanxczvpv6LT+8d2HcrA/Y14yx0LcHxkryOXjbEOZ6T20wamiYrwlF4LBTCaMD5h98czhjtcF44I 0nQBp2yebz0goa/aeNwfLjSyd+WZDQqOzUHFwYX71c2jHpU/ozqxcQYmFA2IutpcNInP2Bn/iXBTw ozvwgCmXA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kuHbm-0003lN-VV; Tue, 29 Dec 2020 16:12:26 +0000 Received: from mail-ej1-f50.google.com ([209.85.218.50]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kuHbk-0003kr-M7 for linux-arm-kernel@lists.infradead.org; Tue, 29 Dec 2020 16:12:25 +0000 Received: by mail-ej1-f50.google.com with SMTP id b9so18776641ejy.0 for ; Tue, 29 Dec 2020 08:12:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+YkJE2LcLSD3EE6sqVw1hwvBfVG/re4CMN303q9UJPI=; b=a4HEDaghEdtmHzP6CZSJVquCx6DiTn7OMreiEOpdeK+0A8zrZ3v7bC7c25W78vbKNB kPr4ja53eI7VI34uSdZ4nQlURY5Gv+nkx6ZmRqq+fzcN2uotSulvybnpnV/GKH5GgQiz An5zucbyQ+VFam8u+yaFY97ajF2Can8fJqxFPFi/hfwU3v+8V+uf86jY6BO64eq3eyWO Lggc67eTHpCd0xYMgCt6xScaS91kczMlmKQgG+9qev8B+sJVClv7DBx14VWGqEi+S49C HcFWAdw7bodyLjg+sJjfpCV/2rYpoE6RW84YK/3CBqymYH8A72K+clAi6wZ7luN+7XH0 W3fw== X-Gm-Message-State: AOAM532wTM4BE2feq6YRNMrSq5gbwGH5vG+GDFZf3Fmok0Qdp8elkfxp v/vQfoWfCMJBk01eRBXFMVc= X-Google-Smtp-Source: ABdhPJyU2Jskq6lY2JPdVpTOdnHIeCIBF4ZPQop85MeCfQzVuVKl7vpA9H+qywu4qjOJrdr6vnGxVw== X-Received: by 2002:a17:906:9345:: with SMTP id p5mr45349274ejw.40.1609258343104; Tue, 29 Dec 2020 08:12:23 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id f11sm38247122edy.59.2020.12.29.08.12.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Dec 2020 08:12:22 -0800 (PST) Date: Tue, 29 Dec 2020 17:12:20 +0100 From: Krzysztof Kozlowski To: Adam Ford Subject: Re: [PATCH 2/4] arm64: dts: imx8mn: add spba bus node Message-ID: <20201229161220.GA17229@kozik-lap> References: <1609243245-9671-1-git-send-email-peng.fan@nxp.com> <1609243245-9671-3-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201229_111224_794085_36002F43 X-CRM114-Status: GOOD ( 23.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Peng Fan , Shawn Guo , Sascha Hauer , Linux Kernel Mailing List , Rob Herring , NXP Linux Team , Sascha Hauer , Fabio Estevam , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 29, 2020 at 06:26:41AM -0600, Adam Ford wrote: > On Tue, Dec 29, 2020 at 6:15 AM wrote: > > > > From: Peng Fan > > > > According to RM, there is a spba bus inside aips3 and aips1, add it. > > > > Signed-off-by: Peng Fan > > --- > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 362 +++++++++++----------- > > 1 file changed, 189 insertions(+), 173 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > index c824f2615fe8..91f85b8cee9a 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > @@ -269,117 +269,125 @@ aips1: bus@30000000 { > > #size-cells = <1>; > > ranges = <0x30000000 0x30000000 0x400000>; > > > > - sai1: sai@30010000 { > > - #sound-dai-cells = <0>; > > - compatible = "fsl,imx8mm-sai", "fsl,imx8mq-sai"; > > - reg = <0x30010000 0x10000>; > > - interrupts = ; > > - clocks = <&clk IMX8MM_CLK_SAI1_IPG>, > > - <&clk IMX8MM_CLK_SAI1_ROOT>, > > - <&clk IMX8MM_CLK_DUMMY>, <&clk IMX8MM_CLK_DUMMY>; > > - clock-names = "bus", "mclk1", "mclk2", "mclk3"; > > - dmas = <&sdma2 0 2 0>, <&sdma2 1 2 0>; > > - dma-names = "rx", "tx"; > > - status = "disabled"; > > - }; > > + bus@30000000 { > > There is already a bus@30000000 (aips1), and I think the system > doesn't like it when there are multiple busses with the same name. > > There was some discussion on fixing the 8mn [1], but it doesn't look > like it went anywhere. > > I am guessing the Mini will need something similar to the nano. > > [1] - https://patchwork.kernel.org/project/linux-arm-kernel/patch/1607324004-12960-1-git-send-email-shengjiu.wang@nxp.com/ Several replies from S.j. Wang are missing from LKML (and maybe patchwork?) but we reached a conclusion: https://lore.kernel.org/linux-arm-kernel/20201208090601.GA8347@kozik-lap/ Either you do some remapping of address space or just rename the "bus" nodes (e.g. generic bus-1 or a specific spba-bus). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel