From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A8BC433DB for ; Tue, 29 Dec 2020 21:23:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18B162074B for ; Tue, 29 Dec 2020 21:23:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18B162074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hHnAGDOQcSkTyMpEWaJpcOK6ZAj/tSfZ/alI4qi7n68=; b=bezJmXsE8fXLXnJoaHT+9aTt7 khmWNmxXjedjHdxlSgjyZrqZMfZgfhCZBiI038+yuOa7GVPA/m++FcypWloLt0oi/QqsvKpBZR5h1 rMnJxv7jpZVg1nTRMRVpubf7jO9dL05w75KIpK3/MSvCaDEj5dh+K6FEDiPQtZhHE1e9CaYlaUcPd SRzk1KmsZ+PBTzYZMJrLsvnLdFHmjNU9q+AQb98qtLoFS0njY3l8xQ+8koCeYGL+vWU7E0G5zLzbp lN7dhNF0uQzd44yJ5G2UfUkRuE6gV/Bekpe1tJOG2o0QBgXw7ry6JgGa066TABZfM3TRyS9c4+9sz UpCso8GHQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kuMRe-0002bx-TR; Tue, 29 Dec 2020 21:22:19 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kuMRY-0002ZI-Gt for linux-arm-kernel@lists.infradead.org; Tue, 29 Dec 2020 21:22:14 +0000 Received: from windsurf (unknown [91.174.235.35]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id D3861240002; Tue, 29 Dec 2020 21:22:06 +0000 (UTC) Date: Tue, 29 Dec 2020 22:22:05 +0100 From: Thomas Petazzoni To: Nadeem Athani Subject: Re: [PATCH v6 1/2] PCI: cadence: Retrain Link to work around Gen2 training defect. Message-ID: <20201229222205.576549d1@windsurf> In-Reply-To: <20201228140510.14641-2-nadeem@cadence.com> References: <20201228140510.14641-1-nadeem@cadence.com> <20201228140510.14641-2-nadeem@cadence.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201229_162212_670341_23390523 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lorenzo.pieralisi@arm.com, mparab@cadence.com, linux-pci@vger.kernel.org, pthombar@cadence.com, linux-kernel@vger.kernel.org, kishon@ti.com, tjoseph@cadence.com, sjakhade@cadence.com, bhelgaas@google.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, The commit title is incorrect, it doesn't match what the patch is doing. On Mon, 28 Dec 2020 15:05:09 +0100 Nadeem Athani wrote: > Moving the function above to remove compilation error. > No changes in function. Which compilation error? I guess there is no compilation error, except after your apply your PATCH 2/2. Is this correct ? If so, this should be explained in this commit log: "Move the function cdns_pcie_host_wait_for_link() further up in the file, as it's going to be used by upcoming additional code in the driver." Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel