From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7A8AC433E6 for ; Mon, 4 Jan 2021 12:10:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9935221E92 for ; Mon, 4 Jan 2021 12:10:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9935221E92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+XUzUxfcUK8LkBdJcLrmEN5Si+YWsNMMB2wPH2WEStY=; b=OLtFzukjrM0pCVHubwawpGtdY Nal5K3aI3m4uMwUQTkf6ySR07itAxt56XIHUQAi12fxHbc4q/RJG/7XDGinbMZAutFayqCw8/2fmf nIE8SiE5t/gUsB2JuzsiH2eMYnBQsNbYvxexCnYUcclP0ZUpo20bDUwhu+ootpyuWAyHdE+RlecdQ tqxZ3F3PXpO1NdBF4nRXsq4U8pPZsPNIrRqzZFuFguwa64u23gY0BueH6OT071YIOaPgwuvm676he 311qkSQPTPh2ZatM2GPqlUXM3p2hVz5mI8hg7udb0yPZk9Ji3ScILXE4fLyRSuAEWZ8nQ7tW/3rJV 6SMl+ITzQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwOea-0007it-MR; Mon, 04 Jan 2021 12:08:04 +0000 Received: from mga18.intel.com ([134.134.136.126]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwOeX-0007ZZ-SK for linux-arm-kernel@lists.infradead.org; Mon, 04 Jan 2021 12:08:02 +0000 IronPort-SDR: BKljXz9UK5ff3fkwYmVdr4Xg7vJT6x9e6eACb/gPhKu4h+T/15yBhteklolwqx6XveB9Bd39R8 hpqZSGQ8nNWQ== X-IronPort-AV: E=McAfee;i="6000,8403,9853"; a="164648823" X-IronPort-AV: E=Sophos;i="5.78,473,1599548400"; d="scan'208";a="164648823" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 04:07:55 -0800 IronPort-SDR: AljENoK4bHv16eucz7sir0b2XFg4vUGszlWhlXIDJ2uePSu+ZLzdmB9wT9pCaoJGYaexvuOdAg Xxrq3wDbAzNA== X-IronPort-AV: E=Sophos;i="5.78,473,1599548400"; d="scan'208";a="345880335" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 04:07:52 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id DAB59206FD; Mon, 4 Jan 2021 14:07:49 +0200 (EET) Date: Mon, 4 Jan 2021 14:07:49 +0200 From: Sakari Ailus To: Paul Kocialkowski Subject: Re: [PATCH v4 2/3] media: i2c: Add support for the OV8865 image sensor Message-ID: <20210104120749.GK11878@paasikivi.fi.intel.com> References: <20201231142702.3095260-1-paul.kocialkowski@bootlin.com> <20201231142702.3095260-3-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201231142702.3095260-3-paul.kocialkowski@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210104_070802_036237_89EFA355 X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?iso-8859-1?Q?K=E9vin_L'h=F4pital?= , devicetree@vger.kernel.org, Jernej Skrabec , linux-kernel@vger.kernel.org, Maxime Ripard , Hans Verkuil , Chen-Yu Tsai , Rob Herring , Thomas Petazzoni , Mauro Carvalho Chehab , kevin.lhopital@hotmail.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, On Thu, Dec 31, 2020 at 03:27:01PM +0100, Paul Kocialkowski wrote: > The OV8865 is a 8 Mpx CMOS image sensor producing 3264x2448 at 30 fps. > Other modes (including some with sub-sampling) are available too. > It outputs 10-bit bayer CFA data through a MIPI CSI-2 interface with > up to 4 lanes supported. I've added the patches to a pull request to Mauro; there appear to still be some checkpatch.pl issues in both of the drivers. I don't mind the warnings on the assignment or the mutex though. Could you address these in additional patches, please? -- Kind regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel