From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19083C433DB for ; Mon, 4 Jan 2021 12:37:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE74A20770 for ; Mon, 4 Jan 2021 12:37:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE74A20770 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wzmOUFow+PJ8HazQrmowIsvIsix9+gtvpxqalpwDyc4=; b=rW7jDJ1Qm9X6oqsdKUeLvR29s vCoz7WHaBrs1iKfVEoQAW8DuC91MjmgtD+Zvo58KcrMPGjkY8oNE0rKIYzL6jXza8R+14hB/MPfgF hz0byZz/AISbjZv9FbFVKUtQCh7Kg2vOWx5KAG5s0r81UgJ7quU6HniJhKxLvecuw7zdmcHrDGTKD pJvQ4HJnzhtfV+Y14I+0b/UGAPDsL7mgLqSWEJWiuf5uSwPcz/RcEcBpcTFLeqrXdEZcV6Rs90bsi GTasCUuDn57TwVPrOVDJOaK1E/H6Ll4LdBqf88A0y2k5iGNJY0+tdESJLIhYMot9ZtkxszZ6vXAXQ YwqAqAEWQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwP5x-00045I-Ry; Mon, 04 Jan 2021 12:36:21 +0000 Received: from mail-wm1-f48.google.com ([209.85.128.48]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwP5v-00044A-SQ for linux-arm-kernel@lists.infradead.org; Mon, 04 Jan 2021 12:36:20 +0000 Received: by mail-wm1-f48.google.com with SMTP id e25so19184786wme.0 for ; Mon, 04 Jan 2021 04:36:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bmz5H27nwmeYsTtVcS7MKZk8aIlltd6hD5uF34esfWQ=; b=BrdIXXifb0HbAT8i/nG5a9mux2MwauXB09upsMvl+jUgk9Og29ZeZv4QOl3tpnmF5x SNjXjExKbmgk7OaCjX/wC2Iyi80hvk0ghlHiwIkVao3/7TngLUUvmZA4is2LofLF+5A3 izd5YmP3lgC3UJvx0Z3yuWFb2W17j+5C6M2oqvqHL2iLamYZKz+LLzUR9jQsUw4K459Q YIhEQTzTNOYNiuCV+J+GcTkpTHdCFF+8n3nH/y8b1rNzkl0LeRrJaX1/itxt8LPrq5vN 6SQpledVDc0HAaMdbkgFccM8r/kdLdrWvMR7+DK9nYn0lCHSwqTcnRr097uaXseW+YGJ YuIQ== X-Gm-Message-State: AOAM533/x+QebXLjRwAL17kNPsa2s4NGqav3kAM++on/OrNPBCJSLFY4 dfPdjkXSENvqcg4HqTpH5Sc= X-Google-Smtp-Source: ABdhPJyadpQat5iRhp9+jBlw7vUIvZA96GAzQ3euhk4XTDmfFHQf63OdMYjHiYWaSimKOncjeOhROA== X-Received: by 2002:a1c:cc14:: with SMTP id h20mr26902395wmb.180.1609763778334; Mon, 04 Jan 2021 04:36:18 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id h15sm88230447wru.4.2021.01.04.04.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jan 2021 04:36:17 -0800 (PST) Date: Mon, 4 Jan 2021 13:36:15 +0100 From: Krzysztof Kozlowski To: Tim Harvey Subject: Re: [PATCH v4 2/2] arm64: dts: imx8mm: Add Gateworks i.MX 8M Mini Development Kits Message-ID: <20210104123615.GA5974@kozik-lap> References: <1609351123-22418-1-git-send-email-tharvey@gateworks.com> <1609351123-22418-2-git-send-email-tharvey@gateworks.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1609351123-22418-2-git-send-email-tharvey@gateworks.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210104_073619_935889_1814D770 X-CRM114-Status: GOOD ( 24.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 30, 2020 at 09:58:43AM -0800, Tim Harvey wrote: > The Gateworks Venice GW71xx-0x/GW72xx-0x/GW73xx-0x are development > kits comprised of a GW700x SoM and a Baseboard. Future SoM's such > as the GW701x will create additional combinations. > > The GW700x SoM contains: > - i.MX 8M Mini SoC > - LPDDR4 DRAM > - eMMC FLASH > - Gateworks System Controller (eeprom/pushbutton/reset/voltage-monitor) > - GbE PHY connected to the i.MX 8M Mini FEC > - Power Management IC > > The GW71xx Baseboard contains: > - 1x MiniPCIe Socket with USB2.0, PCIe, and SIM > - 1x RJ45 GbE (i.MX 8M Mini FEC) > - I/O connector with 1x-SPI/1x-I2C/1x-UART/4x-GPIO signals > - PCIe Clock generator > - GPS and accelerometer > - 1x USB 2.0 Front Panel connector > - wide range power supply > > The GW72xx Baseboard contains: > - 2x MiniPCIe Socket with USB2.0, PCIe, and SIM > - 2x RJ45 GbE (i.MX 8M Mini FEC and LAN743x) > - 1x MicroSD connector > - 1x USB 2.0 Front Panel connector > - 1x SPI connector > - 1x Serial connector supporting 2x-UART or 1x-UART configured as 1 of: > RS232 w/ flow-controll, RS485, RS422 > - PCIe Clock generator > - GPS and accelerometer > - Media Expansion connector (MIPI-CSI/MIPI-DSI/GPIO/I2S) > - I/O connector with 2x-ADC,2x-GPIO,1x-UART,1x-I2C > - wide range power supply > > The GW73xx Baseboard contains: > - 3x MiniPCIe Socket with USB2.0, PCIe, and SIM > - 2x RJ45 GbE (i.MX 8M Mini FEC and LAN743x) > - 1x MicroSD connector > - 1x USB 2.0 Front Panel connector > - 1x SPI connector > - 1x Serial connector supporting 2x-UART or 1x-UART configured as 1 of: > RS232 w/ flow-controll, RS485, RS422 > - WiFi/BT > - PCIe Clock generator > - GPS and accelerometer > - Media Expansion connector (MIPI-CSI/MIPI-DSI/GPIO/I2S) > - I/O connector with 2x-ADC,2x-GPIO,1x-UART,1x-I2C > - wide range power supply > > Signed-off-by: Tim Harvey > --- > v4: > - replace underscore with hyphen for gpio-keys node > - add 'off-board header' comments to i2c/spi/uart nodes that go off-board > - move node comments to own line above node > - add spaces after comma > - move uart2_gpio rs485 config pinmux to hoggroup as they don't necessarily > relate to uart2 > - fix fifo-depth dt property for phy > > v3: > - fix gpio controller node name > - add rtc node to SoM > - add pmic pinctrl to SoM > - fixed compatible string for SoM eeprom's > > v2: > - fix i.MX 8M Mini name in commit log > - consistent use of underscore vs hyphen in labels > - fix gsc interrupt type > - fix iomux group node names > - fix led-controller bindings: > (use correct node names, color, function and remove label) > - use accelerometer node name vs accel > - remove sai3 from gw71xx baseboard > - added serial connector description to commit message > - added I/O connector description to commit message > - removed unnecessary #address-cells/#size-cells from gpio-keys node > > Signed-off-by: Tim Harvey > --- > arch/arm64/boot/dts/freescale/Makefile | 3 + > .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 497 +++++++++++++++++++++ > .../boot/dts/freescale/imx8mm-venice-gw71xx-0x.dts | 19 + > .../boot/dts/freescale/imx8mm-venice-gw71xx.dtsi | 186 ++++++++ > .../boot/dts/freescale/imx8mm-venice-gw72xx-0x.dts | 20 + > .../boot/dts/freescale/imx8mm-venice-gw72xx.dtsi | 314 +++++++++++++ > .../boot/dts/freescale/imx8mm-venice-gw73xx-0x.dts | 19 + > .../boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 366 +++++++++++++++ > 8 files changed, 1424 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dts > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dts > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dts > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index f8d5943..ecdd233 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -32,6 +32,9 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw71xx-0x.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw72xx-0x.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw73xx-0x.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi > new file mode 100644 > index 00000000..5985a39 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi > @@ -0,0 +1,497 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2020 Gateworks Corporation > + */ > + > +#include > +#include > +#include > + > +/ { > + memory@40000000 { > + device_type = "memory"; > + reg = <0x0 0x40000000 0 0x80000000>; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + user_pb { All these nodes as well - hyphens instead of underscore. > + label = "user_pb"; > + gpios = <&gpio 2 GPIO_ACTIVE_LOW>; > + linux,code = ; > + }; > + > + user_pb1x { > + label = "user_pb1x"; > + linux,code = ; > + interrupt-parent = <&gsc>; > + interrupts = <0>; > + }; > + > + key_erased { > + label = "key_erased"; > + linux,code = ; > + interrupt-parent = <&gsc>; > + interrupts = <1>; > + }; > + > + eeprom_wp { > + label = "eeprom_wp"; > + linux,code = ; > + interrupt-parent = <&gsc>; > + interrupts = <2>; > + }; > + > + tamper { > + label = "tamper"; > + linux,code = ; > + interrupt-parent = <&gsc>; > + interrupts = <5>; > + }; > + > + switch_hold { > + label = "switch_hold"; > + linux,code = ; > + interrupt-parent = <&gsc>; > + interrupts = <7>; > + }; > + }; Rest of DTS looks ok, thanks! Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel