From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8881FC433E0 for ; Mon, 4 Jan 2021 12:57:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A7DE207B1 for ; Mon, 4 Jan 2021 12:57:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A7DE207B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1Ejx+dXTNd/6ww5N6T1Erh0uMp1vDE5l19wGTEUmtbw=; b=gBFCntZdzqaJSWf0thpz2o9ec YitOAs7Iv2YYVkUHCPp6MMDp6uHjDORMTcFL5ehZr1v53CvszSufuXAV34gHA0q4YnA6VWoKDLiXN 4W8+048pOTKcg59gjmgmx2CvBQqg5x/VpnYLNAyPI/WOCyYfHxsK7tS4q8LLHRp6PcViQhn1v7d2G U7XFyPakX60W/xxHcyf7fHHq9FY6Afo3bk/C9siUsj244gbMdRLfjntRLyiN/l9aGOzNPeCPHLPsO zNMKIhwMkwozZlJ7n5TTf/b9Znhp12nh9SZ5ozsFT423uwtr+Nz/WcsYNv2XBUYXsiSHsI6P04HT9 PnTmpkFlA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwPOq-00068V-9k; Mon, 04 Jan 2021 12:55:52 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwPOn-00065s-DS for linux-arm-kernel@lists.infradead.org; Mon, 04 Jan 2021 12:55:50 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 104CtjVK102918; Mon, 4 Jan 2021 06:55:45 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1609764945; bh=JiZZQu6dpjhga2YUtT9K1Udslqr6GMyu4soFi9cIwio=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=DzSiSZOOp8QBit06iy4hBadl2Qx6H08H2GD6CShGiZryvShximoPKvgBbnsc7+svK L89oWNvFUmbZ9Nq4MhUyk5XmCKT90qLrIE3JqQ7Jc3/Jzn7S+A6QT9y2RXgrngHaNQ WlYs1GoPwD3xawTOsrZlVsULogFOYIUUVGMYaU8Y= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 104CtjGO100189 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 4 Jan 2021 06:55:45 -0600 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 4 Jan 2021 06:55:44 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 4 Jan 2021 06:55:44 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 104CtiPX093860; Mon, 4 Jan 2021 06:55:44 -0600 Date: Mon, 4 Jan 2021 06:55:44 -0600 From: Nishanth Menon To: Kishon Vijay Abraham I Subject: Re: [PATCH v3 1/6] arm64: dts: ti: k3-j721e-main: Fix supported max outbound regions Message-ID: <20210104125544.arluqus2xbqwacez@curler> References: <20210104122232.24071-1-kishon@ti.com> <20210104122232.24071-2-kishon@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210104122232.24071-2-kishon@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210104_075549_550277_97248C63 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Rob Herring , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17:52-20210104, Kishon Vijay Abraham I wrote: > Cadence IP in J721E supports a maximum of 32 outbound regions. However > commit 4e5833884f66 ("arm64: dts: ti: k3-j721e-main: Add PCIe device > tree nodes") incorrectly added this as 16 outbound regions. Now that > "cdns,max-outbound-regions" is an optional property with default value > as 32, remove "cdns,max-outbound-regions" from endpoint DT node. > > Fixes: 4e5833884f66 ("arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes") ^^ Is this a backward compatible fixup. If I were to apply this on v5.10, wont we have a broken PCIe functionality? Drop the fixes if this is not backward compatible fixup (unless ofcourse the driver fixup is backported all the way back as well - I am assuming will be done in a manner to preserve compatibility with older dtb?) On master right now: $ git grep "cdns,max-outbound-regions" . Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml: cdns,max-outbound-regions = <16>; Documentation/devicetree/bindings/pci/cdns-pcie-ep.yaml: cdns,max-outbound-regions: Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml: cdns,max-outbound-regions: arch/arm64/boot/dts/ti/k3-j721e-main.dtsi: cdns,max-outbound-regions = <16>; arch/arm64/boot/dts/ti/k3-j721e-main.dtsi: cdns,max-outbound-regions = <16>; arch/arm64/boot/dts/ti/k3-j721e-main.dtsi: cdns,max-outbound-regions = <16>; arch/arm64/boot/dts/ti/k3-j721e-main.dtsi: cdns,max-outbound-regions = <16>; drivers/pci/controller/cadence/pcie-cadence-ep.c: of_property_read_u32(np, "cdns,max-outbound-regions", &ep->max_regions); > Signed-off-by: Kishon Vijay Abraham I > --- > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 ---- > 1 file changed, 4 deletions(-) > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel