linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu
Cc: Mark Rutland <mark.rutland@arm.com>,
	kernel-team@android.com,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	James Morse <james.morse@arm.com>,
	David Brazdil <dbrazdil@google.com>,
	Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
	Julien Thierry <julien.thierry.kdev@gmail.com>
Subject: [PATCH v2 15/17] arm64: Make kvm-arm.mode={nvhe, protected} an alias of id_aa64mmfr1.vh=0
Date: Mon,  4 Jan 2021 13:50:09 +0000	[thread overview]
Message-ID: <20210104135011.2063104-16-maz@kernel.org> (raw)
In-Reply-To: <20210104135011.2063104-1-maz@kernel.org>

Admitedly, passing id_aa64mmfr1.vh=0 on the command-line isn't
that easy to understand, and it is likely that users would much
prefer write "kvm-arm.mode=nvhe", or "...=protected".

So here you go. This has the added advantage that we can now
always honor the "kvm-arm.mode=protected" option, even when
booting on a VHE system.

Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 Documentation/admin-guide/kernel-parameters.txt | 3 +++
 arch/arm64/kernel/idreg-override.c              | 2 ++
 arch/arm64/kvm/arm.c                            | 3 +++
 3 files changed, 8 insertions(+)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index c722ec19cd00..e88e17bf5557 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -2257,6 +2257,9 @@
 	kvm-arm.mode=
 			[KVM,ARM] Select one of KVM/arm64's modes of operation.
 
+			nvhe: Standard nVHE-based mode, without support for
+			      protected guests.
+
 			protected: nVHE-based mode with support for guests whose
 				   state is kept private from the host.
 				   Not valid if the kernel is running in EL2.
diff --git a/arch/arm64/kernel/idreg-override.c b/arch/arm64/kernel/idreg-override.c
index 16bc8b3b93ae..1db54878b2c4 100644
--- a/arch/arm64/kernel/idreg-override.c
+++ b/arch/arm64/kernel/idreg-override.c
@@ -41,6 +41,8 @@ static const struct {
 	const char * const	alias;
 	const char * const	feature;
 } aliases[] __initdata = {
+	{ "kvm-arm.mode=nvhe",		"id_aa64mmfr1.vh=0" },
+	{ "kvm-arm.mode=protected",	"id_aa64mmfr1.vh=0" },
 };
 
 static int __init find_field(const char *cmdline, const struct reg_desc *reg,
diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
index 71a49eae9ea0..24aa57ee057c 100644
--- a/arch/arm64/kvm/arm.c
+++ b/arch/arm64/kvm/arm.c
@@ -1962,6 +1962,9 @@ static int __init early_kvm_mode_cfg(char *arg)
 		return 0;
 	}
 
+	if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode()))
+		return 0;
+
 	return -EINVAL;
 }
 early_param("kvm-arm.mode", early_kvm_mode_cfg);
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-01-04 14:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 13:49 [PATCH v2 00/17] arm64: Early CPU feature override, and an application to VHE Marc Zyngier
2021-01-04 13:49 ` [PATCH v2 01/17] arm64: Fix labels in el2_setup macros Marc Zyngier
2021-01-04 13:49 ` [PATCH v2 02/17] arm64: Fix outdated TCR setup comment Marc Zyngier
2021-01-04 13:49 ` [PATCH v2 03/17] arm64: Turn the MMU-on sequence into a macro Marc Zyngier
2021-01-04 13:49 ` [PATCH v2 04/17] arm64: Provide an 'upgrade to VHE' stub hypercall Marc Zyngier
2021-01-05 20:35   ` Jing Zhang
2021-01-05 21:03     ` Marc Zyngier
2021-01-04 13:49 ` [PATCH v2 05/17] arm64: Initialise as nVHE before switching to VHE Marc Zyngier
2021-01-04 13:50 ` [PATCH v2 06/17] arm64: Move VHE-specific SPE setup to mutate_to_vhe() Marc Zyngier
2021-01-04 13:50 ` [PATCH v2 07/17] arm64: Simplify init_el2_state to be non-VHE only Marc Zyngier
2021-01-04 13:50 ` [PATCH v2 08/17] arm64: Move SCTLR_EL1 initialisation to EL-agnostic code Marc Zyngier
2021-01-04 13:50 ` [PATCH v2 09/17] arm64: cpufeature: Add global feature override facility Marc Zyngier
2021-01-04 13:50 ` [PATCH v2 10/17] arm64: Extract early FDT mapping from kaslr_early_init() Marc Zyngier
2021-01-04 13:50 ` [PATCH v2 11/17] arm64: cpufeature: Add an early command-line cpufeature override facility Marc Zyngier
2021-01-06  2:16   ` Jing Zhang
2021-01-06  9:03     ` Marc Zyngier
2021-01-04 13:50 ` [PATCH v2 12/17] arm64: Allow ID_AA64MMFR1_EL1.VH to be overridden from the command line Marc Zyngier
2021-01-05 22:42   ` Jing Zhang
2021-01-04 13:50 ` [PATCH v2 13/17] arm64: Honor VHE being disabled from the command-line Marc Zyngier
2021-01-04 13:50 ` [PATCH v2 14/17] arm64: Add an aliasing facility for the idreg override Marc Zyngier
2021-01-04 13:50 ` Marc Zyngier [this message]
2021-01-04 13:50 ` [PATCH v2 16/17] KVM: arm64: Document HVC_VHE_RESTART stub hypercall Marc Zyngier
2021-01-05 22:58   ` Jing Zhang
2021-01-04 13:50 ` [PATCH v2 17/17] arm64: Move "nokaslr" over to the early cpufeature infrastructure Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210104135011.2063104-16-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=alexandru.elisei@arm.com \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dbrazdil@google.com \
    --cc=james.morse@arm.com \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).