From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707D0C433E6 for ; Mon, 4 Jan 2021 18:08:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C804207BC for ; Mon, 4 Jan 2021 18:08:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C804207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TECoWmqB7OXr8UNVZA6LPxqxZjj1DqkK5hu04yP+/VY=; b=MUodvI46ddwkPiZCBZxo4Wz3t Fko4LiX8g0uF55NXqy70/ZqUCfjcxTZslvfjJWYDHWEklmvTN8eNuS+Nf253dba+l8YYHNmW+bxod AQzJ8jkyQY71D3YxMZ0CF7meaij0BcoqLQvWyR6nzwjtiG9G4tw5oFX2ZaRF1hatS7nd8fuWoBl2I WPeLk9YePeaQMKAgUoLYWCVbispAaSDYFNSBS51Yq0tQFWY1JC4BdG/7euElO3GVd3QRD0LFNTDRA X4Vrbbio9kcwebwXNHjCjibtkdZMV6jabDKIDbQEEYMghbEHKxh0yzg5kkR2t3s4bM9nw2aTEYt0e 7sQ8TEYcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwUFq-0001uT-CZ; Mon, 04 Jan 2021 18:06:54 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwUFm-0001sZ-BR for linux-arm-kernel@lists.infradead.org; Mon, 04 Jan 2021 18:06:51 +0000 Received: by mail-pf1-x429.google.com with SMTP id q22so16865736pfk.12 for ; Mon, 04 Jan 2021 10:06:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xYzKEx9afcFRdGQjRh3dltv3hAqeS4dskEJcj64S+70=; b=XNRsly2hYSHBcOOcNaWdbOIbu6w+JfFI2KYJzN5hoFd/2I+CMbFGObjQ/SOsCJVl6g Qc+/OWCRIqconNwYuH6dTZRL7MmJC6fFkG0NvDvttBbr6QVk3bUOvx51acRmWhaz+BCV 3/8hbJxHWtD6zswOpT5YmxYSlYAInIklACWL9gHUK/glMo2xMh+sSjoIzlPashqRmdSD EUQxGtGEA85bkgDBWz/aU62d3uFT+EPfD7+4F6QQ3kSzZd3zdgY9eqGZbouskMxRzZMz BfwkGn25Ao098uQra2W4X2jeOPwycnoWd5HGrCHh1xawk7h7ehcy5U0LSNIJSkEtYv1p C3hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xYzKEx9afcFRdGQjRh3dltv3hAqeS4dskEJcj64S+70=; b=PVtcoRC7P5bS9XYeRXLcOjf3rQbZWaVe7I5dTUCoXUq+M1x9cvwLoQzgG0LZOevEXb OaMaHSHKmEEo+mNLtixguni7le3IHRrc01Wla+UMuyknjH9hPoPZqJ2meLkMDJNOE9E1 a0PtdiwPjfikP4l98/je4L7iqFZE1sQ7kdfTeA0E4hy8nn71Njq8JuWoCLP7sYEm9VT+ txPuvcXvjH/76hKE205fAYBz1pI12AJiwiXcE1LSuFhmyj9TefwuH3wu/anz+3AaFC4a VGMzGMJL73Kal3L/RwrHA/14gbQ6ks5D1iFxdUGd/iv4qPagow59Eg5YIZ9wErGGx0I9 jC2A== X-Gm-Message-State: AOAM531mpjqK/nP278lmwCTfRmfw8qAP8v6JmiSAza/lxXMzwyyK0Ij/ g8X78rPHNRCZ2zWPtxH0zjnNUQ== X-Google-Smtp-Source: ABdhPJy1DaXwvsO2uZwkaov1nMFboI2gR/SL9sER+2ptxcFfmkSWrOiygaIOz2zHQcOVYirS4cnjFA== X-Received: by 2002:a63:c80e:: with SMTP id z14mr71847475pgg.435.1609783605933; Mon, 04 Jan 2021 10:06:45 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id g26sm55169215pfo.35.2021.01.04.10.06.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jan 2021 10:06:45 -0800 (PST) Date: Mon, 4 Jan 2021 11:06:42 -0700 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH 3/3] rfc: perf: cs_etm: Detect pid in VMID for kernel running at EL2 Message-ID: <20210104180642.GA2702940@xps15> References: <20201110183313.1823760-4-suzuki.poulose@arm.com> <20201113001105.GA22708@leoy-ThinkPad-X240s> <7e45fd42-0869-cd4f-1eaf-5d48e4464482@arm.com> <20201116094634.GA31795@leoy-ThinkPad-X240s> <0E201888-C3D2-4B9E-A3D5-9F1F62AB2D55@arm.com> <20201223080532.GA26191@leoy-ThinkPad-X240s> <98445ac9-9ef9-e377-034c-c65351348359@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <98445ac9-9ef9-e377-034c-c65351348359@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210104_130650_550867_04CB8EAF X-CRM114-Status: GOOD ( 37.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: al.grant@arm.com, Denis Nikitin , Anshuman Khandual , "coresight@lists.linaro.org" , Leo Yan , Daniel Kiss , "linux-arm-kernel@lists.infradead.org" , "mike.leach@linaro.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suzuki, On Mon, Jan 04, 2021 at 05:33:50PM +0000, Suzuki K Poulose wrote: > Hi Leo, > > On 12/23/20 8:05 AM, Leo Yan wrote: > > Hi Denis, > > > > On Tue, Dec 22, 2020 at 01:57:41AM -0800, Denis Nikitin wrote: > > > > [...] > > > > > > > Below is the drafted patch for support PID format in the metadata and > > > > > I tested for "perf record" and "perf script" command and can work as > > > > > expected. > > > > > > > > > > P.s. I uploaded the patches into the github [1] and gave some minor > > > > > refactoring for your last patch "perf cs-etm: Detect pid in VMID for > > > > > kernel running at EL2". > > > > > > > I have tested the patches on Chrome OS EL2 kernel and they worked fine for > > > me. > > > > Thanks a lot for the testing! > > > > > Note that "perf cs-etm: Add PID format into metadata" patch breaks perf > > > backward compatibility. It may cause a problem in off-target decoding if > > > there is a version skew in perf. > > > I saw a discussion about perf compatibility in > > > https://lists.linaro.org/pipermail/coresight/2020-November/005326.html. > > > I understand that perf doesn't guarantee backward compatibility but in fact > > > incompatibility issues occur rarely. I think if there is an (easy) way to > > > do it the compatibility breakage should be avoided. > > > > Agreed. After reading the code and I think it's possible to do an extra > > checking the length of auxtrace info structure so that can know if > > the item CS_ETMV4_PID_FMT is valid or not. Thus we needs to write a > > parity function of intel_pt_has() for perf cs-etm; I will try to rework > > this patch. > > > > > This is a critical fix for Chrome OS. Please let me know what you think. > > > > So are you asking to upstream the changes to mainline kernel? You > > could see this patch is owned by Suzuki and I only proposed for one > > patch for perf related change. > > > > Suzuki, could you give some update for the plan of this patch set? > > I can help to prepare the perf patch based on Suzuki's plan. > > I am happy for you to pick up the perf tool changes as needed. I believe > there are no changes required for the patches, 1 & 2, which adds the basic > kernel and perf tool support. As I have mentioned in the description of this > patch, this is clearly an RFC and is a hack. So I am happy that you can > fix this properly in perf tool decoding. > > Mathieu, > > Are you happy with the proposed series to solve this issue ? I could respin > the series on the latest upstream tree if you like. Looking at my (extensive) patch log this morning I was wondering what to do about that patchset. Yes, please respin it on rc2 and I'll look at it. Reading through the above conversation with Leo, should I expect your next patchset to replace your perf tools changes with Leo's work? Alternatively and knowing Leo is working on it I'd be happy with just the kernel changes. Thanks, Mathieu > > Kind regards > Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel