From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B9F5C433E0 for ; Tue, 5 Jan 2021 14:43:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 390FB22B45 for ; Tue, 5 Jan 2021 14:43:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 390FB22B45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EIdF9Fe+pQmQCmdO330GrMH3z+sgXxZPlADhwW4tbiE=; b=2sSF2/6nlh4t5RL/RyMFCaT+o 4CqzyF1mERmSLAGYs+YBtRPpgLBAzy4wYM4sj8M8DpIEmiagmfbz2Wa6VPC+Su2ktUaFEeTvL4gZ/ /dSvOxr3VkgvUx6ydBq2/emzuw8HkrivbqZwkmjynArHaIMYF8QErdnvwenJatmGxLpZPIgZkh++5 DaEIpqJhLsrO5detZLpdxUTiJEyR06pNtOuC2dLBwXZzoog2KU2/5KaTlFoy6QNu1zxfNVzKXGYGO jUjgMU7TWnl8r7tM7MpJFN0v1FZBU84urflXcJ/ODoDVYuCq4VuCPdC1LT9HsM1PACHt8SUfS9CN5 tJRSOVG6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwnX7-0001kf-TN; Tue, 05 Jan 2021 14:42:02 +0000 Received: from mga11.intel.com ([192.55.52.93]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwnX4-0001jr-QW for linux-arm-kernel@lists.infradead.org; Tue, 05 Jan 2021 14:41:59 +0000 IronPort-SDR: ThfbTJSUCiLEMg4lux46swqElyBhVYRJG2czTtWjRvcuWTGekqQMIREUqAnaFfMTmT1Cm6J0mT v0Nrmrs/O1vA== X-IronPort-AV: E=McAfee;i="6000,8403,9854"; a="173604033" X-IronPort-AV: E=Sophos;i="5.78,477,1599548400"; d="scan'208";a="173604033" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 06:41:56 -0800 IronPort-SDR: bpivkxY+nxz/ZxLQsHPsFGGX4EmiEFv4XieEvrtWP21TnXDbfi4io+N4fhpOYVmtcVsUx2apXH mvhvVF0qNRBg== X-IronPort-AV: E=Sophos;i="5.78,477,1599548400"; d="scan'208";a="361188842" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 06:41:52 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id D694F206FD; Tue, 5 Jan 2021 16:41:50 +0200 (EET) Date: Tue, 5 Jan 2021 16:41:50 +0200 From: Sakari Ailus To: Paul Kocialkowski Subject: Re: [PATCH v4 2/3] media: i2c: Add support for the OV8865 image sensor Message-ID: <20210105144150.GS11878@paasikivi.fi.intel.com> References: <20201231142702.3095260-1-paul.kocialkowski@bootlin.com> <20201231142702.3095260-3-paul.kocialkowski@bootlin.com> <20210104120749.GK11878@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_094159_020511_A4AFE2FF X-CRM114-Status: GOOD ( 22.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?iso-8859-1?Q?K=E9vin_L'h=F4pital?= , devicetree@vger.kernel.org, Jernej Skrabec , linux-kernel@vger.kernel.org, Maxime Ripard , Hans Verkuil , Chen-Yu Tsai , Rob Herring , Thomas Petazzoni , Mauro Carvalho Chehab , kevin.lhopital@hotmail.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, On Tue, Jan 05, 2021 at 10:38:47AM +0100, Paul Kocialkowski wrote: > Hi Sakari, > > On Mon 04 Jan 21, 14:07, Sakari Ailus wrote: > > Hi Paul, > > > > On Thu, Dec 31, 2020 at 03:27:01PM +0100, Paul Kocialkowski wrote: > > > The OV8865 is a 8 Mpx CMOS image sensor producing 3264x2448 at 30 fps. > > > Other modes (including some with sub-sampling) are available too. > > > It outputs 10-bit bayer CFA data through a MIPI CSI-2 interface with > > > up to 4 lanes supported. > > > > I've added the patches to a pull request to Mauro; there appear to still be > > some checkpatch.pl issues in both of the drivers. > > > > I don't mind the warnings on the assignment or the mutex though. Could you > > address these in additional patches, please? > > Sorry about that, I realized that I never run checkpatch with --strict > so I completely missed those. > > I'll fix the cosmetic issues in a following patch. > > Just to clarify one thing: > #define OV8865_PAD_PK_DRIVE_STRENGTH_2X (1 << 5) > #define OV8865_BLC_CTRL1_COL_SHIFT_128 (1 << 4) > > these are not single-bit fields so even though it looks like they should > use BIT(), this would be incoherent with other possible values, such as: > #define OV8865_PAD_PK_DRIVE_STRENGTH_3X (2 << 5) > #define OV8865_BLC_CTRL1_COL_SHIFT_64 (2 << 4) Agreed. You might not assign the top bit, but if you did, the left operand would have to be unsigned to guarantee the intended result (otherwise it's undefined). -- Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel