From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C33C433DB for ; Tue, 5 Jan 2021 16:22:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D364622C9D for ; Tue, 5 Jan 2021 16:22:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D364622C9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=XGQV0EpGP8H6Wm/7v2S1PC7HgKDTVfZegzwPRo/uIak=; b=UPz8dP2I/lO4T4lHPikZjUyFSA P0eB+Q4k+uCw5mPDxhYEmfXqcBG9Ph/kcfESozzjYvevMqXBCggkOMBfpQ7aXJF7kUDaA3U+9cn3k nJ4jpCLbP1DWiTMqhgIZhtEUpZa6nAVv8ixkoI5l+CliabLgl8YMExlB4VeI8RpYC/oFK4XIvxytR LSRjSNu4GV9mERJHTUnAqtZGhL/20YHiU/C7HxPd2JVvrfakNgju1S+gWZ6gw02lvUbqW/UALrKxH HkLXJc0DR50AYSe0uN2LOmME7i6OddTuQzvH6fXbioOEremBTl6LEw8RiR8aI9sHNlc1ahbtJa4q4 c6rnmGkQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwp4e-0000D9-Nj; Tue, 05 Jan 2021 16:20:44 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwp4b-0000Bx-K5 for linux-arm-kernel@lists.infradead.org; Tue, 05 Jan 2021 16:20:42 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 190so94981wmz.0 for ; Tue, 05 Jan 2021 08:20:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=amMDYdE1HwB0WK+aIbkC3QuSFtKRTKZ4qviNmoyJMUA=; b=mHASkIvWK2g3oOY6ikhu7Y32PpyxHXD6Zq8XuVGq4Oe7yMIPft36r6TAp0r7YBEJFJ Z4lSAjdHzKBuXHsX8MhWaffFfP5ll1oQYrSeLhwzFE/2FHUWlkJjLguAEUi0xT22AEb8 PGdJMHEycAZ2B+gjc1AXHA1j7I39A5Y04EZTFZR1edVY+WJGTyOos5+gj5oWDLE6Pwir rE9H0A1XmSU8J015jeO8Kp84WGGPvSWEn3h2Ymaq+YKHxzz0BBZfDeii2fmi2zDIAuNk AQ+lnvvotXGrA9yalixQxaidrlOp6w/eIRX5NHhB7ewmwMOeoP1TPNQD7Nlh8Ez/h5dD qVJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=amMDYdE1HwB0WK+aIbkC3QuSFtKRTKZ4qviNmoyJMUA=; b=pXc6jtMHPonTIYGyMhkFgT39FOOBl5OZzdxUYDl9GMTSV2ZpnzQMPVdMUMYhk4fm5w 0XZ3FhFLCiC6zavgXenFFh+dNUTrthQRiZtdIn/7lMrcKqWaUcwrhokhVY9+QbRb0nKi 0ZDHvOasfTlP4KIhePEIFCwLk+/aD7xcNQxRiuQ3g/l0vQ/OUfNcvJIhiTsorcHDqrNN l8QYb5hGQdeZn5ELNVfyCuLbjOMH4yKdv/zeSsyBOGgzGjm3QdhKdlII8LgWcAw/w6UZ zGD+B7brxeSG31mgT+4DYZmDoLGqukypyP7GnptuJ3Lmve9uA5qH43S5ecGZ49gGAphb CMyg== X-Gm-Message-State: AOAM531UP84HK6l+r7wU657ukwJxquoTeJWctGtccEwIImxDVxOcYWu3 hrGWJVAVnqbcMGD9/FuRytZXXw== X-Google-Smtp-Source: ABdhPJxeI583lCyrqA9RmKhDOT9SoGEFZsgFAgBrrnnNpTK8pYh7AXzweAhM3C552e5oz384VM5QJw== X-Received: by 2002:a05:600c:210e:: with SMTP id u14mr65084wml.48.1609863638517; Tue, 05 Jan 2021 08:20:38 -0800 (PST) Received: from buildbot.pitowers.org ([2a00:1098:3142:14:ae1f:6bff:fedd:de54]) by smtp.gmail.com with ESMTPSA id r82sm6654wma.18.2021.01.05.08.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jan 2021 08:20:37 -0800 (PST) From: Phil Elwell To: Nicolas Saenz Julienne , Greg Kroah-Hartman , Arnd Bergmann , Dan Carpenter , Stefan Wahren , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org Subject: [PATCH v2 0/3] A trio of vchiq bulk transfer fixes Date: Tue, 5 Jan 2021 16:20:27 +0000 Message-Id: <20210105162030.1415213-1-phil@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_112041_725841_9494BEAB X-CRM114-Status: GOOD ( 14.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Phil Elwell Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The recent batch of vchiq improvements broke bulk transfers in two ways: 1. The userdata associated with a transfer was lost in the case that a non-blocking mode was used. 2. The 64-bit ioctl compatibility shim for a bulk transfer used the wrong ioctl command. This patch set fixes both of those bugs, and adds a security-related note to the TODO file. Changes in v2: - Expand the commit message on patch 1 to clarify the impact of the bug, and add Tested-by. - Add commit 3 with an additional TODO item. - Change the name of the patch set to be numerically accurate. Phil Elwell (3): staging: vchiq: Fix bulk userdata handling staging: vchiq: Fix bulk transfers on 64-bit builds staging: vc04_services: Add a note to the TODO drivers/staging/vc04_services/interface/TODO | 4 ++++ .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 ++++-- 2 files changed, 8 insertions(+), 2 deletions(-) -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel